Re: [PATCH v3 0/2] imagebuilder, sdk: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archives

2021-05-05 Thread Sven Roederer
Am Montag, 26. April 2021, 16:58:20 CEST schrieb Sven Roederer:
> Using the BINARY_FOLDER or DOWNLOAD_FOLDER options make them escape from the
> build-system to the system the archives run later.
> As the build-time path will usually not work on the other system, restore
> the intree defaults.
> 
> 
Hi,

are there any concerns with this patch series?

Best Sven



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH] tplink-safeloader: fix C7v5 factory flashing from vendor fw > v1.1.x

2021-05-05 Thread Henrique de Moraes Holschuh

Any updates on this?

An user reported to us this same issue with the latest 2021 version of 
the C7v5-US tp-link firmware [as available in Brazil].


Install was possible only through tftp: the tp-link stock firmware web 
page would refuse the factory image.


On 13/04/2021 05:26, Petr Štetiar wrote:

Adrian Schmutzler  [2021-04-10 18:55:10]:

Hi,


Currently it's not possible to flash factory images on devices shipped with
vendor firmware versions 1.1.0 Build 20201120 rel. 50406 (published
2020-12-22):


Will this prevent flashing back vendor firmware via TFTP or is a different 
comparison used there?


nope, it seems like U-Boot has different kind of checks. For example my
testing unit has following U-Boot:

  U-Boot 1.1.4-gbec22107-dirty (Nov 18 2020 - 18:19:12)

and flashing from OpenWrt back to stock with latest factory vendor image
c7v5_us-up-ver1-1-2-P1[20210125-rel37999]_2021-01-25_10.33.55.bin
works as expected:

  Firmware downloaded... filesize = 0xeeae77 fileaddr = 0x8006.
  Firmware Recovery file length : 15642231
  Firmware process id 2.
  handle_fw_cloud 146
  Image verify OK!
  Firmware file Verify ok!
  product-info:product_name:Archer C7
  product_ver:5.0.0
  special_id:5553
  [Error]sysmgr_cfg_checkSupportList(): 1023 @ specialId 4555 NOT Match.
  Firmware supports, check OK.
  Firmware Recovery check ok!

-- ynezz

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel




--
Henrique de Moraes Holschuh
Analista de Projetos
Centro de Estudos e Pesquisas em Tecnologias de Redes e Operações 
(Ceptro.br)

+55 11 5509-3537 R.:4023
INOC 22548*625
www.nic.br

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH opkg] libopkg: pkg_hash: print unresolved dependencies

2021-05-05 Thread Philip Prindeville



> On May 2, 2021, at 5:13 PM, Daniel Golle  wrote:
> 
> On Sun, May 02, 2021 at 10:59:12PM +0200, Hauke Mehrtens wrote:
>> When a package is not installed because it has unresolved dependencies
>> normally we get only an error message like this:
>> * pkg_hash_fetch_best_installation_candidate: Packages for ltq-vdsl-app 
>> found, but incompatible with the architectures configured
>> * opkg_install_cmd: Cannot install package ltq-vdsl-app.
>> 
>> Log in addition the following error message:
>> * pkg_hash_check_unresolved: can not find dependency ltq-dsl-base for 
>> ltq-vdsl-app
>> 
>> Signed-off-by: Hauke Mehrtens 
>> ---
>> 
>> I am not sure if this would happen in normal cases too and spam the 
>> error log, I only saw this in an error case.
>> 
>> libopkg/pkg_hash.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/libopkg/pkg_hash.c b/libopkg/pkg_hash.c
>> index a07a25e..6c04ab2 100644
>> --- a/libopkg/pkg_hash.c
>> +++ b/libopkg/pkg_hash.c
>> @@ -263,8 +263,10 @@ pkg_hash_check_unresolved(pkg_t *maybe)
>>  if (unresolved) {
>>  res = 1;
>>  tmp = unresolved;
>> -while (*tmp)
>> +while (*tmp) {
>> +opkg_msg(ERROR, "can not find dependency %s for %s\n", 
>> *tmp, maybe->name);
>^
> Should be 'cannot', it's spelled as one word in English (natives:
> correct me if I'm wrong!)


Correct.


> 
>>  free(*(tmp++));
>> +}
>>  free(unresolved);
>>  }
>>  pkg_vec_free(depends);
>> -- 
>> 2.30.2
>> 
>> 
>> ___
>> openwrt-devel mailing list
>> openwrt-devel@lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> 
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH] added support for comfast jw-ew74

2021-05-05 Thread Paul Spooren



On 5/4/21 5:28 PM, e...@daloft.com wrote:

From: eric 

---


Hi Eric,

thank you very much for your contribution!

Please read the following guide, there are some formal issues with this 
patch:


https://openwrt.org/submitting-patches

Patches should always include the full and real name of the author and a 
commit message which describes the patch. Especially when adding new 
devices, the commit message should include steps to flash the device and 
a hardware overview. Please see the git log to find examples.


Kind regards,
Paul


  .../ramips/dts/mt7628an_comfast_jw-ew74.dts   | 147 ++
  target/linux/ramips/image/mt76x8.mk   |   9 ++
  .../mt76x8/base-files/etc/board.d/01_leds |   7 +
  .../mt76x8/base-files/etc/board.d/02_network  |   4 +
  4 files changed, 167 insertions(+)
  create mode 100644 target/linux/ramips/dts/mt7628an_comfast_jw-ew74.dts

diff --git a/target/linux/ramips/dts/mt7628an_comfast_jw-ew74.dts 
b/target/linux/ramips/dts/mt7628an_comfast_jw-ew74.dts
new file mode 100644
index 00..dc6aaeb4fe
--- /dev/null
+++ b/target/linux/ramips/dts/mt7628an_comfast_jw-ew74.dts
@@ -0,0 +1,147 @@
+/dts-v1/;
+
+#include "mt7628an.dtsi"
+
+#include 
+#include 
+
+/ {
+   #address-cells = <0x01>;
+   #size-cells = <0x01>;
+   compatible = "comfast,jw-ew74\0mediatek,mt7628an-soc";
+   model = "Comfast JW-EW74";
+
+   chosen {
+   bootargs = "console=ttyS0,115200";
+   };
+
+
+
+   gpio-keys-polled {
+   #address-cells = <0x01>;
+   #size-cells = <0x00>;
+   compatible = "gpio-keys-polled";
+   poll-interval = <0x14>;
+
+   reset {
+   gpios = <&gpio 0x06 0x01>;
+   label = "reset";
+   linux,code = ;
+   };
+   };
+
+   gpio-leds {
+   compatible = "gpio-leds";
+
+   wifi {
+   gpios = <&gpio 0x0c 0x01>;
+   label = "comfast:blue:wifi";
+   };
+
+   wifi0 {
+   gpios = <&gpio 0x0b 0x01>;
+   label = "comfast:blue:wifi0";
+   };
+
+   wifi1 {
+   gpios = <&gpio 0x05 0x01>;
+   label = "comfast:blue:wifi1";
+   };
+
+   wifi2 {
+   gpios = <&gpio 0x0d 0x01>;
+   label = "comfast:blue:wifi2";
+   };
+   };
+
+};
+
+
+
+
+
+&spi0 {
+status = "okay";
+
+flash@0 {
+compatible = "jedec,spi-nor";
+reg = <0>;
+spi-max-frequency = <1000>;
+
+   partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+
+   partition@0 {
+   label = "u-boot";
+   read-only;
+   reg = <0x00 0x3>;
+   };
+
+
+   partition@3 {
+   label = "u-boot-env";
+   read-only;
+   reg = <0x3 0x1>;
+   };
+
+   factory: partition@4 {
+   label = "factory";
+   read-only;
+   reg = <0x4 0x1>;
+   };
+
+   partition@5 {
+   compatible = "denx,uimage";
+   label = "firmware";
+   reg = <0x5 0x77>;
+   };
+
+   partition@7c {
+   label = "configs";
+   reg = <0x7c 0x4>;
+   };
+   partition@100 {
+label = "reserve";
+reg = <0x100 0x100>;
+};
+
+   };
+   };
+};
+
+ðernet {
+   mtd-mac-address = <&factory 0xe00 >;
+};
+
+
+&wmac {
+
+   status = "okay";
+   mtd-mac-address = <&factory 0xe00>;
+   mtd-mac-address-increment = <1>;
+
+};
+
+
+&pcie {
+   status = "okay";
+};
+
+
+&pcie0 {
+wifi: mt76@0,0 {
+reg = <0x 0 0 0 0>;
+   mediatek,5ghz = <0x00>;
+mediatek,mtd-eeprom = <&factory 0x8000>;
+   ieee80211-freq-limit = <500 600>;
+   mtd-mac-address = <&factory 0xe00>;
+   mtd-mac-address-increment = <2>;
+   
+};
+};
+&i2c   {
+   status = "okay";
+};
diff --git a/target/linux/ramips/image/mt76x8.mk 
b/targ

Re: [PATCH] fstools: block: fix segfault on mount with no target

2021-05-05 Thread Paul Spooren



On 5/4/21 3:23 PM, Daniel Danzberger wrote:

When a UCI fstab mount config doesn't contain a target option,
a 'block mount' call segfaults when comparing a mount's target (NULL)
to a found mount point returned by find_mount_point()

Signed-off-by: Daniel Danzberger 
---

Acked-by: Paul Spooren 

  block.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index f094216..c6d93d1 100644
--- a/block.c
+++ b/block.c
@@ -1021,7 +1021,7 @@ static int mount_device(struct probe_info *pr, int type)
  
  	mp = find_mount_point(pr->dev);

if (mp) {
-   if (m && m->type == TYPE_MOUNT && strcmp(m->target, mp)) {
+   if (m && m->type == TYPE_MOUNT && m->target && 
strcmp(m->target, mp)) {
ULOG_ERR("%s is already mounted on %s\n", pr->dev, mp);
err = -1;
} else


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[PATCH] procd: Use /dev/console for serial console if exists

2021-05-05 Thread Gaurav Pathak
inittab.c: Use "/dev/console" if it is present, before trying
"/sys/class/tty/console/active" in case if console kernel command
line is not provided during boot and to allow container environment
to use it as login PTY console.

Signed-off-by: Gaurav Pathak 
---
 inittab.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/inittab.c b/inittab.c
index 2c2270c..b2ffc9a 100644
--- a/inittab.c
+++ b/inittab.c
@@ -190,7 +190,10 @@ static void askconsole(struct init_action *a)
 */
tty = get_cmdline_val("console", line, sizeof(line));
if (tty == NULL) {
-   tty = get_active_console(line, sizeof(line));
+   if (dev_exist("console"))
+   tty = "console";
+   else
+   tty = get_active_console(line, sizeof(line));
}
if (tty != NULL) {
split = strchr(tty, ',');
-- 
2.25.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel