Re: [PATCH RFC/RFT] ath10k: use xmit encapsulation offloading
Il giorno gio 19 mag 2022 alle ore 01:17 Edward Matijevic ha scritto: > > Reporting an issue running these patches with the ath10k-ct driver > from OpenWrt 22.03-rc1 crashing repeatedly on my IPQ8064+QCA9980 > router > The patches only require an edit to the file locations to the > directory ath10k-5.15/ and the offsets apply without issue > Below is a log from the hardware crashing repeatedly, only lines > removed included MACs > > ieee80211 phy0: Hardware restart was requested > ath10k_pci :01:00.0: 10.4 wmi init: vdevs: 16 peers: 48 tid: 96 > ath10k_pci :01:00.0: msdu-desc: 2500 skid: 32 > ath10k_pci :01:00.0: wmi print 'P 48/48 V 16 K 144 PH 176 T 186 > msdu-desc: 2500 sw-crypt: 0 ct-sta: 0' > ath10k_pci :01:00.0: wmi print 'free: 31080 iram: 23028 sram: 9596' > ath10k_pci :01:00.0: rts threshold -1 > ath10k_pci :01:00.0: Firmware lacks feature flag indicating a > retry limit of > 2 is OK, requested limit: 4 > ath10k_pci :01:00.0: device successfully recovered > ath10k_pci :01:00.0: firmware crashed! (guid > dacbb411-7d89-4a0b-b4a8-1e25f10d9838) > ath10k_pci :01:00.0: qca99x0 hw2.0 target 0x0100 chip_id > 0x003b01ff sub 168c:0002 > ath10k_pci :01:00.0: kconfig debug 0 debugfs 1 tracing 0 dfs 1 testmode 0 > ath10k_pci :01:00.0: firmware ver 10.4b-ct-9980-fW-13-5ae337bb1 > api 5 features > mfp,peer-flow-ctrl,txstatus-noack,wmi-10.x-CT,ratemask-CT,regdump-CT,txrate-CT,flush-all-CT,pingpong-CT,ch-regs-CT,nop-CT,set-special-CT,tx-rc-CT,cust-stats-CT,txrate2-CT,beacon-cb-CT,wmi-block-ack-CT,wmi-bcn-rc-CT > crc32 b36a12bf > ath10k_pci :01:00.0: board_file api 2 bmi_id 1:1 crc32 e4a0f655 > ath10k_pci :01:00.0: htt-ver 2.2 wmi-op 6 htt-op 4 cal > pre-cal-nvmem max-sta 32 raw 0 hwcrypto 1 > ath10k_pci :01:00.0: firmware register dump: > ath10k_pci :01:00.0: [00]: 0x0009 0x 0x0098C64F 0x > ath10k_pci :01:00.0: [04]: 0x 0x00060124 0x 0x > ath10k_pci :01:00.0: [08]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [12]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [16]: 0x009BFE03 0x009C0489 0x0097F8C6 0x0098C64F > ath10k_pci :01:00.0: [20]: 0x 0x00401C20 0x 0x > ath10k_pci :01:00.0: [24]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [28]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [32]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [36]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [40]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [44]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [48]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [52]: 0x 0x 0x 0x > ath10k_pci :01:00.0: [56]: 0x 0x 0x 0x > ath10k_pci :01:00.0: Copy Engine register dump: > ath10k_pci :01:00.0: [00]: 0x0004a000 0 0 3 3 > ath10k_pci :01:00.0: [01]: 0x0004a400 3 3 73 74 > ath10k_pci :01:00.0: [02]: 0x0004a800 51 51 50 51 > ath10k_pci :01:00.0: [03]: 0x0004ac00 29 29 1 29 > ath10k_pci :01:00.0: [04]: 0x0004b000 23 23 52 14 > ath10k_pci :01:00.0: [05]: 0x0004b400 22 22 53 54 > ath10k_pci :01:00.0: [06]: 0x0004b800 8 8 8 8 > ath10k_pci :01:00.0: [07]: 0x0004bc00 1 1 1 1 > ath10k_pci :01:00.0: [08]: 0x0004c000 0 0 127 0 > ath10k_pci :01:00.0: [09]: 0x0004c400 1 1 1 1 > ath10k_pci :01:00.0: [10]: 0x0004c800 0 0 0 0 > ath10k_pci :01:00.0: [11]: 0x0004cc00 0 0 0 0 > ath10k_pci :01:00.0: debug log header, dbuf: 0x4197f8 dropped: 0 > ath10k_pci :01:00.0: [0] next: 0x4197e0 buf: 0x4158b0 sz: 1500 > len: 0 count: 0 free: 0 > ath10k_pci :01:00.0: [1] next: 0x4197f8 buf: 0x4152c0 sz: 1500 > len: 0 count: 0 free: 0 > There should be a beta firmware with the crash fixed... But anyway the ct firmware doesn't work with offload and this is the main reason i never actually put effort in getting this merged. Openwrt use ath10k-ct and offload doesn't work, the dev didn't bother to fix it so rip any use of this since the original ath10k is not usable for some user. > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH RFC/RFT] ath10k: use xmit encapsulation offloading
Reporting an issue running these patches with the ath10k-ct driver from OpenWrt 22.03-rc1 crashing repeatedly on my IPQ8064+QCA9980 router The patches only require an edit to the file locations to the directory ath10k-5.15/ and the offsets apply without issue Below is a log from the hardware crashing repeatedly, only lines removed included MACs ieee80211 phy0: Hardware restart was requested ath10k_pci :01:00.0: 10.4 wmi init: vdevs: 16 peers: 48 tid: 96 ath10k_pci :01:00.0: msdu-desc: 2500 skid: 32 ath10k_pci :01:00.0: wmi print 'P 48/48 V 16 K 144 PH 176 T 186 msdu-desc: 2500 sw-crypt: 0 ct-sta: 0' ath10k_pci :01:00.0: wmi print 'free: 31080 iram: 23028 sram: 9596' ath10k_pci :01:00.0: rts threshold -1 ath10k_pci :01:00.0: Firmware lacks feature flag indicating a retry limit of > 2 is OK, requested limit: 4 ath10k_pci :01:00.0: device successfully recovered ath10k_pci :01:00.0: firmware crashed! (guid dacbb411-7d89-4a0b-b4a8-1e25f10d9838) ath10k_pci :01:00.0: qca99x0 hw2.0 target 0x0100 chip_id 0x003b01ff sub 168c:0002 ath10k_pci :01:00.0: kconfig debug 0 debugfs 1 tracing 0 dfs 1 testmode 0 ath10k_pci :01:00.0: firmware ver 10.4b-ct-9980-fW-13-5ae337bb1 api 5 features mfp,peer-flow-ctrl,txstatus-noack,wmi-10.x-CT,ratemask-CT,regdump-CT,txrate-CT,flush-all-CT,pingpong-CT,ch-regs-CT,nop-CT,set-special-CT,tx-rc-CT,cust-stats-CT,txrate2-CT,beacon-cb-CT,wmi-block-ack-CT,wmi-bcn-rc-CT crc32 b36a12bf ath10k_pci :01:00.0: board_file api 2 bmi_id 1:1 crc32 e4a0f655 ath10k_pci :01:00.0: htt-ver 2.2 wmi-op 6 htt-op 4 cal pre-cal-nvmem max-sta 32 raw 0 hwcrypto 1 ath10k_pci :01:00.0: firmware register dump: ath10k_pci :01:00.0: [00]: 0x0009 0x 0x0098C64F 0x ath10k_pci :01:00.0: [04]: 0x 0x00060124 0x 0x ath10k_pci :01:00.0: [08]: 0x 0x 0x 0x ath10k_pci :01:00.0: [12]: 0x 0x 0x 0x ath10k_pci :01:00.0: [16]: 0x009BFE03 0x009C0489 0x0097F8C6 0x0098C64F ath10k_pci :01:00.0: [20]: 0x 0x00401C20 0x 0x ath10k_pci :01:00.0: [24]: 0x 0x 0x 0x ath10k_pci :01:00.0: [28]: 0x 0x 0x 0x ath10k_pci :01:00.0: [32]: 0x 0x 0x 0x ath10k_pci :01:00.0: [36]: 0x 0x 0x 0x ath10k_pci :01:00.0: [40]: 0x 0x 0x 0x ath10k_pci :01:00.0: [44]: 0x 0x 0x 0x ath10k_pci :01:00.0: [48]: 0x 0x 0x 0x ath10k_pci :01:00.0: [52]: 0x 0x 0x 0x ath10k_pci :01:00.0: [56]: 0x 0x 0x 0x ath10k_pci :01:00.0: Copy Engine register dump: ath10k_pci :01:00.0: [00]: 0x0004a000 0 0 3 3 ath10k_pci :01:00.0: [01]: 0x0004a400 3 3 73 74 ath10k_pci :01:00.0: [02]: 0x0004a800 51 51 50 51 ath10k_pci :01:00.0: [03]: 0x0004ac00 29 29 1 29 ath10k_pci :01:00.0: [04]: 0x0004b000 23 23 52 14 ath10k_pci :01:00.0: [05]: 0x0004b400 22 22 53 54 ath10k_pci :01:00.0: [06]: 0x0004b800 8 8 8 8 ath10k_pci :01:00.0: [07]: 0x0004bc00 1 1 1 1 ath10k_pci :01:00.0: [08]: 0x0004c000 0 0 127 0 ath10k_pci :01:00.0: [09]: 0x0004c400 1 1 1 1 ath10k_pci :01:00.0: [10]: 0x0004c800 0 0 0 0 ath10k_pci :01:00.0: [11]: 0x0004cc00 0 0 0 0 ath10k_pci :01:00.0: debug log header, dbuf: 0x4197f8 dropped: 0 ath10k_pci :01:00.0: [0] next: 0x4197e0 buf: 0x4158b0 sz: 1500 len: 0 count: 0 free: 0 ath10k_pci :01:00.0: [1] next: 0x4197f8 buf: 0x4152c0 sz: 1500 len: 0 count: 0 free: 0 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] ramips: use hotplug script for EAP615-Wall MACs
Hi Stijn,
Op dinsdag 17 mei 2022 om 17u57 schreef Stijn Tintel
:
Using nvmem-cells to set the MAC address for a DBDC device results in
both PHY devices using the same MAC address. This in turn will result
in
multiple BSSes using the same BSSID, which can cause various problems.
Use the hotplug script for the EAP615-Wall instead to avoid this.
Fixes: a1b8a4d7b3ff ("ramips: support TP-Link EAP615-Wall")
Signed-off-by: Stijn Tintel
As advertised ;-). Tested on 22.03 branch, both radios use different
MAC now.
Tested-by: Stijn Segers
---
target/linux/ramips/dts/mt7621_tplink_eap615-wall-v1.dts | 2 --
.../mt7621/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac | 4
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/linux/ramips/dts/mt7621_tplink_eap615-wall-v1.dts
b/target/linux/ramips/dts/mt7621_tplink_eap615-wall-v1.dts
index a0c3912d8e..0be4af39e8 100644
--- a/target/linux/ramips/dts/mt7621_tplink_eap615-wall-v1.dts
+++ b/target/linux/ramips/dts/mt7621_tplink_eap615-wall-v1.dts
@@ -144,8 +144,6 @@
compatible = "mediatek,mt76";
reg = <0x 0 0 0 0>;
mediatek,mtd-eeprom = < 0x0>;
- nvmem-cells = <_info_8>;
- nvmem-cell-names = "mac-address";
};
};
diff --git
a/target/linux/ramips/mt7621/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
b/target/linux/ramips/mt7621/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
index a35e9dcc28..5b12416872 100644
---
a/target/linux/ramips/mt7621/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
+++
b/target/linux/ramips/mt7621/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
@@ -90,6 +90,10 @@ case "$board" in
hw_mac_addr="$(mtd_get_mac_binary factory 0x4)"
[ "$PHYNBR" = "1" ] && macaddr_add $hw_mac_addr "0x10" >
/sys${DEVPATH}/macaddress
;;
+ tplink,eap615-wall-v1)
+ hw_mac_addr="$(mtd_get_mac_binary product-info 0x8)"
+ macaddr_add "$hw_mac_addr" "$PHYNBR" >
"/sys${DEVPATH}/macaddress"
+ ;;
yuncore,ax820)
[ "$PHYNBR" = "1" ] && \
macaddr_setbit_la "$(mtd_get_mac_binary Factory 0xe000)" >
/sys${DEVPATH}/macaddress
--
2.35.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH firewall4] ruleset: add missing pre_* chains
Hi,
can't you do the same by dropping a snippet into /etc/nftables.d/ which simply
registers chain with lower priority hooks? In fact there already is an example
[1].
So in order to achieve what you want, create an
`/etc/nftables.d/10-pre-chains.nft with the following contents:
-- 8< --
chain pre_input {
type filter hook input priority -1; policy accept;
}
chain pre_forward {
type filter hook forward priority -1; policy accept;
}
chain pre_output {
type filter hook output priority -1; policy accept;
}
-- >8 --
Since nftables makes it easy to have many hooks, I doubt that such a generic,
mostly unused facility is needed at all. If your package/process/use case
requires staging custom rules before the default ones, drop a partial into
/etc/nftables.d/ which declares own chains with lower priority hooks along
with the rules you need.
~ Jo
1:
https://git.openwrt.org/?p=project/firewall4.git;a=blob;f=root/etc/nftables.d/10-custom-filter-chains.nft;h=4cb421308f2f8b084add77fc51f8430596d83abf;hb=b2682251a173103490a4a2556fb87e4df1d627b3#l8
signature.asc
Description: OpenPGP digital signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH firewall4] ruleset: add missing pre_* chains
There is the option to add a user change, but if the rule applies, the
fw4 rules are still processed. This is because these chains are
top-level chains that only have a different priority.
This priority indicates whether they are processed before or after the
fw4 chains.
So that rules can also be processed in the context of the fw4 and are
not passed on to the next toplevel chain in the event of an apply. The
rule must be processed in the context of the fw4 tables. This commit
adds a pre chain for input, output and forward.
Firewall rules, that are not handeled by the fw4 can then be hooked into
this, which are then processed in the context of the fw4 and are thus
allowed through by the fw4 in the event of an accept.
Signed-off-by: Florian Eckert
(cherry picked from commit 596f9f7973560210a8ccf386d7017aaa07ea77d2)
---
root/usr/share/firewall4/templates/ruleset.uc | 15 +++
1 file changed, 15 insertions(+)
diff --git a/root/usr/share/firewall4/templates/ruleset.uc
b/root/usr/share/firewall4/templates/ruleset.uc
index 0142d5a..79401d2 100644
--- a/root/usr/share/firewall4/templates/ruleset.uc
+++ b/root/usr/share/firewall4/templates/ruleset.uc
@@ -67,11 +67,16 @@ table inet fw4 {
# Filter rules
#
+ chain pre_input {
+
+ }
+
chain input {
type filter hook input priority filter; policy {{
fw4.input_policy(true) }};
iifname "lo" accept comment "!fw4: Accept traffic from loopback"
+ jump pre_input
ct state established,related accept comment "!fw4: Allow
inbound established and related flows"
{% if (fw4.default_option("drop_invalid")): %}
ct state invalid drop comment "!fw4: Drop flows with invalid
conntrack state"
@@ -90,9 +95,14 @@ table inet fw4 {
{% endif %}
}
+ chain pre_forward {
+
+ }
+
chain forward {
type filter hook forward priority filter; policy {{
fw4.forward_policy(true) }};
+ jump pre_forward
{% if (length(flowtable_devices) > 0): %}
meta l4proto { tcp, udp } flow offload @ft;
{% endif %}
@@ -111,11 +121,16 @@ table inet fw4 {
{% endif %}
}
+ chain pre_output {
+
+ }
+
chain output {
type filter hook output priority filter; policy {{
fw4.output_policy(true) }};
oifname "lo" accept comment "!fw4: Accept traffic towards
loopback"
+ jump pre_output
ct state established,related accept comment "!fw4: Allow
outbound established and related flows"
{% if (fw4.default_option("drop_invalid")): %}
ct state invalid drop comment "!fw4: Drop flows with invalid
conntrack state"
--
2.30.2
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
