[PATCH] image: fix device profile specific COMPILE targets
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.
To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
Commit a01d23e75 ("image: always rebuild kernel loaders")
is a step in the right direction, but exposed some issues
and regressions in the makefile.
1. Some of the files made by device specific COMPILE targets
start with an "append" command (i.e. >> instead of > redirection)
and if the file already exists, the target file is the
input to itself before the first recipe-specified input.
2. Some of the device specific COMPILE targets, like the lzma-loader
have multiple steps and the uImage target requires the bin or ELF first,
so the two COMPILE operations cannot be run in parallel.
Fixes: a01d23e75 ("image: always rebuild kernel loaders")
Fixes: a7fb589e8 ("image: always rebuild kernel loaders")
Signed-off-by: Michael Pratt
---
include/image.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/image.mk b/include/image.mk
index e9dc53f82e..575df15899 100644
--- a/include/image.mk
+++ b/include/image.mk
@@ -520,8 +520,11 @@ define Device/Build/compile
$$(_COMPILE_TARGET): $(KDIR)/$(1)
$(eval $(call Device/Export,$(KDIR)/$(1)))
$(KDIR)/$(1): FORCE
+ rm -f $(KDIR)/$(1)
$$(call concat_cmd,$(COMPILE/$(1)))
+ .NOTPARALLEL: $$(_COMPILE_TARGET)
+
endef
ifndef IB
--
2.30.2
--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v2 2/9] uci: maintain option position in uci_set
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.
To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
Op 20 nov. 2022, om 02:08 heeft Jan Venekamp het volgende
geschreven:
>
> Maintain the position of an option in the list when updating an option
> in uci_set.
>
> Signed-off-by: Jan Venekamp
> ---
> list.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/list.c b/list.c
> index ac3686c..a8f2a2c 100644
> --- a/list.c
> +++ b/list.c
> @@ -76,7 +76,7 @@ uci_free_element(struct uci_element *e)
> }
>
> static struct uci_option *
> -uci_alloc_option(struct uci_section *s, const char *name, const char *value)
> +uci_alloc_option(struct uci_section *s, const char *name, const char *value,
> struct uci_list *after)
> {
> struct uci_package *p = s->package;
> struct uci_context *ctx = p->ctx;
> @@ -87,7 +87,7 @@ uci_alloc_option(struct uci_section *s, const char *name,
> const char *value)
> o->v.string = uci_dataptr(o);
> o->section = s;
> strcpy(o->v.string, value);
> - uci_list_add(>options, >e.list);
> + uci_list_insert(after ? after : s->options.prev, >e.list);
>
> return o;
> }
> @@ -719,7 +719,7 @@ int uci_set(struct uci_context *ctx, struct uci_ptr *ptr)
>
> return uci_delete(ctx, ptr);
> } else if (!ptr->o && ptr->option) { /* new option */
> - ptr->o = uci_alloc_option(ptr->s, ptr->option, ptr->value);
> + ptr->o = uci_alloc_option(ptr->s, ptr->option, ptr->value,
> NULL);
> ptr->last = >o->e;
> } else if (!ptr->s && ptr->section) { /* new section */
> ptr->s = uci_alloc_section(ptr->p, ptr->value, ptr->section);
> @@ -731,7 +731,7 @@ int uci_set(struct uci_context *ctx, struct uci_ptr *ptr)
> !strcmp(ptr->o->v.string, ptr->value))
> return 0;
>
> - ptr->o = uci_alloc_option(ptr->s, ptr->option, ptr->value);
> + ptr->o = uci_alloc_option(ptr->s, ptr->option, ptr->value,
> >e.list);
> if (ptr->option == old->e.name)
> ptr->option = ptr->o->e.name;
> uci_free_option(old);
> --
> 2.32.0 (Apple Git-132)
>
>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Nice, as this keeps tediously hand-edited config files better intact.
Paul
--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v2 2/9] uci: maintain option position in uci_set
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.
To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
Op 20 nov. 2022, om 02:08 heeft Jan Venekamp het volgende
geschreven:
>
> Maintain the position of an option in the list when updating an option
> in uci_set.
>
> Signed-off-by: Jan Venekamp
> ---
> list.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/list.c b/list.c
> index ac3686c..a8f2a2c 100644
> --- a/list.c
> +++ b/list.c
> @@ -76,7 +76,7 @@ uci_free_element(struct uci_element *e)
> }
>
> static struct uci_option *
> -uci_alloc_option(struct uci_section *s, const char *name, const char *value)
> +uci_alloc_option(struct uci_section *s, const char *name, const char *value,
> struct uci_list *after)
> {
> struct uci_package *p = s->package;
> struct uci_context *ctx = p->ctx;
> @@ -87,7 +87,7 @@ uci_alloc_option(struct uci_section *s, const char *name,
> const char *value)
> o->v.string = uci_dataptr(o);
> o->section = s;
> strcpy(o->v.string, value);
> - uci_list_add(>options, >e.list);
> + uci_list_insert(after ? after : s->options.prev, >e.list);
>
> return o;
> }
> @@ -719,7 +719,7 @@ int uci_set(struct uci_context *ctx, struct uci_ptr *ptr)
>
> return uci_delete(ctx, ptr);
> } else if (!ptr->o && ptr->option) { /* new option */
> - ptr->o = uci_alloc_option(ptr->s, ptr->option, ptr->value);
> + ptr->o = uci_alloc_option(ptr->s, ptr->option, ptr->value,
> NULL);
> ptr->last = >o->e;
> } else if (!ptr->s && ptr->section) { /* new section */
> ptr->s = uci_alloc_section(ptr->p, ptr->value, ptr->section);
> @@ -731,7 +731,7 @@ int uci_set(struct uci_context *ctx, struct uci_ptr *ptr)
> !strcmp(ptr->o->v.string, ptr->value))
> return 0;
>
> - ptr->o = uci_alloc_option(ptr->s, ptr->option, ptr->value);
> + ptr->o = uci_alloc_option(ptr->s, ptr->option, ptr->value,
> >e.list);
> if (ptr->option == old->e.name)
> ptr->option = ptr->o->e.name;
> uci_free_option(old);
> --
> 2.32.0 (Apple Git-132)
>
>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Nice, as this keeps tediously hand-edited config files better intact.
Paul
--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: 24 core buildbot server donation feasible
I advise to not to accept this from Equinix for the bad they have been doing in the interconnection market in different places. Sometimes is just better to pay for what you need with donations received it rather than accept something from certain companies. On 21/11/2022 05:39, Petr Štetiar wrote: Dave Taht [2022-11-19 06:56:01]: Hi Dave, And let me know, and I'll expedite with the manager in charge. thank you for making us aware, I've just filled that application form. Cheers, Petr ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: 24 core buildbot server donation feasible
Dave Taht [2022-11-19 06:56:01]: Hi Dave, > And let me know, and I'll expedite with the manager in charge. thank you for making us aware, I've just filled that application form. Cheers, Petr ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
