some github runner failers
https://github.com/openwrt/packages/actions/runs/7908507874/job/21587828762?pr=23415 for various platforms errors: #4 [internal] load metadata for docker.io/openwrt/rootfs:i386_pentium-mmx-openwrt-23.05 #4 ERROR: no match for platform in manifest sha256:7a53f3d962d2ecbd00ee1f5b12794be788ca9312c1f2bc51d4ff36376a2b362d: not found -- > [internal] load metadata for docker.io/openwrt/rootfs:i386_pentium-mmx-openwrt-23.05: -- Dockerfile:2 1 | ARG ARCH=x86-64 2 | >>> FROM openwrt/rootfs:$ARCH 3 | 4 | ADD entrypoint.sh /entrypoint.sh ERROR: failed to solve: openwrt/rootfs:i386_pentium-mmx-openwrt-23.05: no match for platform in manifest sha256:7a53f3d962d2ecbd00ee1f5b12794be788ca9312c1f2bc51d4ff36376a2b362d: not found Error: Process completed with exit code 1. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v2] scripts: create kernel configuration upgrade script
On Wed, Feb 14, 2024 at 10:03:00AM +0100, Rafał Miłecki wrote: > On 7.02.2024 02:16, Elliott Mitchell wrote: > > diff --git a/scripts/kernel_upgrade.pl b/scripts/kernel_upgrade.pl > > new file mode 100755 > > index 00..b9fe5882a3 > > --- /dev/null > > +++ b/scripts/kernel_upgrade.pl > > @@ -0,0 +1,261 @@ > > +#!/usr/bin/env perl > > +# > > +# Copyright (C) 2024 Elliott Mitchell > > # > > +# # > > +# This is free software, licensed under the GNU General Public License > > # > > +# v3. See /LICENSE for more information. # > > +# > > OpenWrt is GPL 2.0 licensed. This this is GPL 3.0 only. > > It seems to be independent script (right now) but: > 1. What if one day we make it share some common code? Then you have GPLv3. Question is whether the common portion comes from this script? If yes, then we consider LGPL versus everything being GPLv3. This seems pretty unlikely as this is a rather specific task. `git fast-import` isn't likely to be useful in very many places. Also, `git` isn't something I would expect to see on a 128MB RAM device. > 2. What about using it to produce GPL 2.0 code? This is very well-understood. GPL applies to source code and the tools. GIMP is routinely used to produce non-GPL images. `git` is now used by MS for handling their source code, most of it remains non-GPL and no lawsuits have resulted. GCC is routinely used to build non-GPL software. Anything not directly linked in is completely uneffected. In particular while it does manipulate git's data, none of that is linked into the script and therefore has no license effects. This won't have any particularly notable effects. -- (\___(\___(\__ --=> 8-) EHM <=-- __/)___/)___/) \BS (| ehem+sig...@m5p.com PGP 87145445 |) / \_CS\ | _ -O #include O- _ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] base-files: sysupgrade: include uci-defaults script disabling services
(Not directly commenting on this change set) Would services not do better to be tracked within uci and its config files in /etc/config? Or do changes to those files there risk triggering other procd actions to the services they dictate? On 2024-02-14 16:05, Rafał Miłecki wrote: From: Rafał Miłecki Disabled services should be kept disabled after sysupgrade. This can be easily handled using a proper uci-defaults script. Extend sysupgrade to check for disabled services, generate uci-defaults script disabling them and include it in backup. Cc: Christian Marangi Cc: Jo-Philipp Wich Cc: Jonas Gorski Signed-off-by: Rafał Miłecki --- package/base-files/files/sbin/sysupgrade | 10 ++ 1 file changed, 10 insertions(+) diff --git a/package/base-files/files/sbin/sysupgrade b/package/base-files/files/sbin/sysupgrade index 1e09f65e07..b1ada062ed 100755 --- a/package/base-files/files/sbin/sysupgrade +++ b/package/base-files/files/sbin/sysupgrade @@ -273,6 +273,16 @@ create_backup_archive() { \) | sed -e 's,.*/,,;s/\.control /\t/' > "$dir/${INSTALLED_PACKAGES}" fi + mkdir -p $dir/etc/uci-defaults/ + touch $dir/etc/uci-defaults/10_disable_services + for service in /etc/init.d/*; do + if ! $service enabled; then + echo "$service disable" >> $dir/etc/uci-defaults/10_disable_services + fi + done + echo "exit 0" >> $dir/etc/uci-defaults/10_disable_services + echo "/etc/uci-defaults/10_disable_services" >> "$CONFFILES" + v "Saving config files..." sed -i 's/^\///' "$CONFFILES" # Drop leading slashes [ "$VERBOSE" -gt 1 ] && TAR_V="v" || TAR_V="" ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: procd error messages
On 2024-02-13 00:23, Hartmut Birr wrote: Hi, I let /etc/init.d/network log some more things by changing: --- network.rom 2024-02-12 20:46:51.0 +0100 +++ network 2024-02-12 23:18:07.0 +0100 @@ -16,8 +16,10 @@ start_service() { init_switch procd_open_instance - procd_set_param command /sbin/netifd + procd_set_param command /sbin/netifd -l 5 -d 15 procd_set_param respawn + procd_set_param stdout 1 + procd_set_param stderr 1 procd_set_param watch network.interface [ -e /proc/sys/kernel/core_pattern ] && { procd_set_param limits core="unlimited" It reports some errors by using logread -e netifd: Mon Feb 12 23:30:27 2024 daemon.err netifd[29247]: device_claim(694): Claim Network device pppoe-wan, new active count: 2 Mon Feb 12 23:30:27 2024 daemon.err netifd[29247]: proto_shell_handler(231): run setup for interface 'wan_6' Mon Feb 12 23:30:27 2024 daemon.err netifd[29247]: __device_add_user(1037): Add user for device 'pppoe-wan', refcount=2 Mon Feb 12 23:30:27 2024 daemon.debug pppd[24514]: Script /lib/netifd/ppp6-up finished (pid 24752), status = 0x0 Mon Feb 12 23:30:45 2024 daemon.err netifd[29247]: sh: missing ] Mon Feb 12 23:30:45 2024 daemon.err netifd[29247]: device_claim(694): Claim Network alias pppoe-wan, new active count: 2 Mon Feb 12 23:30:45 2024 daemon.err netifd[29247]: interface_add_dns_server(1435): Add IPv6 DNS server: 2003:180:2::: Mon Feb 12 23:30:45 2024 daemon.err netifd[29247]: interface_add_dns_server(1435): Add IPv6 DNS server: 2003:180:2::: Mon Feb 12 23:30:45 2024 daemon.err netifd[29247]: interface_queue_event(124): Queue hotplug handler for interface 'wan_6', event 'ifup' Mon Feb 12 23:30:45 2024 daemon.notice netifd: Interface 'wan_6' is now up Mon Feb 12 23:30:50 2024 daemon.err netifd[29247]: task_complete(109): Complete hotplug handler for interface 'wan' Mon Feb 12 23:30:50 2024 daemon.err netifd[29247]: call_hotplug(100): Call hotplug handler for interface 'wan', event 'ifupdate' (pppoe-wan) Call exits netifd. Does it go to ppp.sh? It could be that some ' -a ' condition is breaking down...? [ blah -a blah2 ] ? https://git.openwrt.org/?p=project/netifd.git;a=blob;f=examples/proto/ppp.sh;hb=f01345ec13b9b27ffd314d8689fb2d3f9c81a47d https://git.openwrt.org/?p=project/netifd.git;a=blob;f=scripts/netifd-proto.sh;h=87d337df07e9aa94b80ea53d050eadde791739d9;hb=refs/heads/master Mon Feb 12 23:31:05 2024 daemon.err netifd[29247]: sh: missing ] Mon Feb 12 23:31:07 2024 daemon.err netifd[29247]: sh: out of range Mon Feb 12 23:31:07 2024 daemon.err netifd[29247]: task_complete(109): Complete hotplug handler for interface 'wan' Mon Feb 12 23:31:07 2024 daemon.err netifd[29247]: call_hotplug(100): Call hotplug handler for interface 'wan_6', event 'ifup' (pppoe-wan) Mon Feb 12 23:31:07 2024 daemon.err netifd[29247]: /sbin/uci: Invalid argument Mon Feb 12 23:31:16 2024 daemon.err netifd[29247]: sh: missing ] Is it possible to let print netifd more informations related to errors from executed commands like: Mon Feb 12 23:31:05 2024 daemon.err netifd[29247]: sh: missing ] Mon Feb 12 23:31:07 2024 daemon.err netifd[29247]: sh: out of range Mon Feb 12 23:31:07 2024 daemon.err netifd[29247]: /sbin/uci: Invalid argument I'm not able to identify the executed scripts. Regards, Hartmut ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [VOTE] New member proposal: Robimarko (Robert Marko)
On Wed, 14 Feb 2024 at 22:15, Christian Marangi (Ansuel) wrote: > > > > > Robert is active in OpenWrt since 2017 and with some recent stats, he > > has more than 310 commits merged in OpenWrt. > > He also have uncounted Reviewed-by tag on various PR and merged commits > > and generally helps in everything related to IPQ (ipq806x, ipq40xx and > > ipq807x) and some mvebu targets. > > > > He did the conversion of ipq40xx target to DSA and made possible the > > introduction of the ipq807x target by sorting all the QSDK downstream > > patch and pushing them upstream. > > > > With his help, also the ipq60xx is very close on getting merged and > > actually used permitting support of even more device for OpenWrt. > > > > Also he is almost always reachable on IRC openwrt-devel and never had > > a problem in coordinating and collaborating with him. > > > > I think Robert is a good addition to our team and would massively help > > me (Ansuel) in maintaining each IPQ target and review all the related > > PR on github and patchwork. > > I would like to add Robert to the OpenWrt committers team. > > > > The vote shall be concluded within 14 days. (13/02/2024) > > Vote ended. > - 23/40 Participants. Quorum reached. > - 23 yes. > > https://openwrt.org/voting/2024-02-new-member-robimarko > > All welcomes Robert Marko as a new member of the OpenWrt Team. I would like to thank everybody who voted, glad to join the team. Regards, Robert > > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [VOTE] New member proposal: Robimarko (Robert Marko)
> > Robert is active in OpenWrt since 2017 and with some recent stats, he > has more than 310 commits merged in OpenWrt. > He also have uncounted Reviewed-by tag on various PR and merged commits > and generally helps in everything related to IPQ (ipq806x, ipq40xx and > ipq807x) and some mvebu targets. > > He did the conversion of ipq40xx target to DSA and made possible the > introduction of the ipq807x target by sorting all the QSDK downstream > patch and pushing them upstream. > > With his help, also the ipq60xx is very close on getting merged and > actually used permitting support of even more device for OpenWrt. > > Also he is almost always reachable on IRC openwrt-devel and never had > a problem in coordinating and collaborating with him. > > I think Robert is a good addition to our team and would massively help > me (Ansuel) in maintaining each IPQ target and review all the related > PR on github and patchwork. > I would like to add Robert to the OpenWrt committers team. > > The vote shall be concluded within 14 days. (13/02/2024) Vote ended. - 23/40 Participants. Quorum reached. - 23 yes. https://openwrt.org/voting/2024-02-new-member-robimarko All welcomes Robert Marko as a new member of the OpenWrt Team. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
vlan on kernel 6.1
Hi, I've trouble with kernel 6.1. My configuration for tagged vlan's with hostapd works on kernel 5.15 but not on 6.1. Vlan interfaces like ethx.y are not coming up. This happens on two different routers (Asus RT-AX53u and TP-Link Archer C7v2). When I try this manually I get: ip link add link eth0 name eth0.8 type vlan id 8 RTNETLINK answers: Resource busy The same command works on kernel 5.15. Regards, Hartmut ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH] base-files: sysupgrade: include uci-defaults script disabling services
From: Rafał Miłecki Disabled services should be kept disabled after sysupgrade. This can be easily handled using a proper uci-defaults script. Extend sysupgrade to check for disabled services, generate uci-defaults script disabling them and include it in backup. Cc: Christian Marangi Cc: Jo-Philipp Wich Cc: Jonas Gorski Signed-off-by: Rafał Miłecki --- package/base-files/files/sbin/sysupgrade | 10 ++ 1 file changed, 10 insertions(+) diff --git a/package/base-files/files/sbin/sysupgrade b/package/base-files/files/sbin/sysupgrade index 1e09f65e07..b1ada062ed 100755 --- a/package/base-files/files/sbin/sysupgrade +++ b/package/base-files/files/sbin/sysupgrade @@ -273,6 +273,16 @@ create_backup_archive() { \) | sed -e 's,.*/,,;s/\.control /\t/' > "$dir/${INSTALLED_PACKAGES}" fi + mkdir -p $dir/etc/uci-defaults/ + touch $dir/etc/uci-defaults/10_disable_services + for service in /etc/init.d/*; do + if ! $service enabled; then + echo "$service disable" >> $dir/etc/uci-defaults/10_disable_services + fi + done + echo "exit 0" >> $dir/etc/uci-defaults/10_disable_services + echo "/etc/uci-defaults/10_disable_services" >> "$CONFFILES" + v "Saving config files..." sed -i 's/^\///' "$CONFFILES" # Drop leading slashes [ "$VERBOSE" -gt 1 ] && TAR_V="v" || TAR_V="" -- 2.35.3 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH firmware-utils] zycast: disable build on non-Linux OS
Hi Tomasz, On Mon, 2024-02-12 at 17:18 +0100, Tomasz Maciej Nowak wrote: > From: Tomasz Maciej Nowak > > Fails with following errors on MacOS builder: > > [ 96%] Building C object CMakeFiles/zycast.dir/src/zycast.c.o > /usr/bin/gcc > -I/Users/runner/work/firmware-utils/firmware-utils/openwrt/tools/include > -I/usr/local/opt/libressl/include -O3 -DNDEBUG -isysroot > /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs > /MacOSX13.1.sdk -mmacosx-version-min=12.7 -Wall -Wno-unused-parameter -MD > -MT > CMakeFiles/zycast.dir/src/zycast.c.o -MF > CMakeFiles/zycast.dir/src/zycast.c.o.d -o > CMakeFiles/zycast.dir/src/zycast.c.o -c > /Users/runner/work/firmware-utils/firmware- > utils/src/zycast.c > /Users/runner/work/firmware-utils/firmware-utils/src/zycast.c:205:35: error: > use of > undeclared identifier 'MSG_MORE' > if (send(sockfd, phdr, HDRSIZE, MSG_MORE | MSG_DONTROUTE) < 0) > ^ > /Users/runner/work/firmware-utils/firmware-utils/src/zycast.c:285:39: error: > use of > undeclared identifier 'SO_BINDTODEVICE' > if (setsockopt(sockfd, SOL_SOCKET, SO_BINDTODEVICE, > optarg, > strlen(optarg)) < 0) > ^ > 2 errors generated. > > These seem to be Linux only definitions and there are no equivalents, > so leave rewrite of zycast to someone interested in running it on > other OS. > > Signed-off-by: Tomasz Maciej Nowak > --- Thanks for the patch, pushed to firmware-utils/master. I've trimmed the error output in the commit message, so it doesn't contain the full paths and all compiler options. Best, Sander ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v2] scripts: create kernel configuration upgrade script
On 7.02.2024 02:16, Elliott Mitchell wrote: diff --git a/scripts/kernel_upgrade.pl b/scripts/kernel_upgrade.pl new file mode 100755 index 00..b9fe5882a3 --- /dev/null +++ b/scripts/kernel_upgrade.pl @@ -0,0 +1,261 @@ +#!/usr/bin/env perl +# +# Copyright (C) 2024 Elliott Mitchell # +# # +# This is free software, licensed under the GNU General Public License # +# v3. See /LICENSE for more information. # +# OpenWrt is GPL 2.0 licensed. This this is GPL 3.0 only. It seems to be independent script (right now) but: 1. What if one day we make it share some common code? 2. What about using it to produce GPL 2.0 code? This may be more or less obvious to some of us but should we have a lawyer opinion to be sure? Personally I'm against such mixing licenses in our tools (script). Also: please use SPDX header to simplify licensing info. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel