Hi,
Thanks for your advice. I will fix these problems and resubmit the patch
Best regards
Luochongjun
From: Chuanhong Guo
Date: 2019-08-13 14:38
To: Luochongjun
CC: openwrt-devel
Subject: Re: [OpenWrt-Devel] [PATCH] ath79: add support for gl-ar750
Hi! Sorry for the late reply.
Here are 3 more nitpickings below:
On Fri, Jul 26, 2019 at 11:14 AM Luochongjun wrote:
>
> This patch supports gl-ar750, which was previously supported by ar71xx.
>
> Specification:
> - SOC: QCA9531 (650MHz)
> - Flash: 16 MiB (W25Q128FVSG)
> - RAM: 128 MiB DDR2
> - Ethernet: 10/100: 2xLAN + 10/100: 1xWAN
A proper VLAN setup for the two LAN ports should be added in
target/linux/ath79/base-files/etc/board.d/02_network.
> - Wireless: 2.4GHz (bgn) and 5GHz (ac)
> - USB: 1x USB 2.0 port
> - Switch: 1x switch
> - Button: 1x reset button
> - LED: 3x LEDS (white)
>
> Flash instruction:
> Support for sysupgrade directive upgrades, as well as luci upgrades.
>
> Signed-off-by: Luochongjun
> ---
> .../etc/hotplug.d/firmware/11-ath10k-caldata | 1 +
> target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts | 149
> +
> target/linux/ath79/image/generic.mk| 10 ++
> 3 files changed, 160 insertions(+)
> create mode 100644 target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts
>
> diff --git
> a/target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
> b/target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
> index 4118685..5c9fa2f 100644
> --- a/target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
> +++ b/target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
> @@ -117,6 +117,7 @@ case "$FIRMWARE" in
> ath10kcal_extract "art" 20480 2116
> ath10kcal_patch_mac $(macaddr_add $(cat
> /sys/class/net/eth0/address) +1)
> ;;
> + glinet,gl-ar750|\
> glinet,gl-ar750s)
> ath10kcal_extract "art" 20480 2116
> ath10kcal_patch_mac $(macaddr_add $(mtd_get_mac_binary art 0)
> +1)
> diff --git a/target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts
> b/target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts
> new file mode 100644
> index 000..b8f9735
> --- /dev/null
> +++ b/target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts
> @@ -0,0 +1,149 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/dts-v1/;
> +
> +#include
> +#include
> +
> +#include "qca953x.dtsi"
> +
> +/ {
> + compatible = "glinet,gl-ar750", "qca,qca9531";
> + model = "GL.iNet GL-AR750";
> +
> + keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <_disable_pins>;
> +
> + reset {
> + label = "reset";
> + linux,code = ;
> + gpios = < 3 GPIO_ACTIVE_LOW>;
> + };
> +
> + mode {
> + label = "mode";
> + linux,code = ;
> + gpios = < 0 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + power {
> + label = "gl-ar750:white:power";
> + gpios = < 12 GPIO_ACTIVE_LOW>;
> + default-state = "on";
> + };
> +
> + wlan2g {
> + label = "gl-ar750:white:wlan2g";
> + gpios = < 14 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "phy1tpt";
> + };
> +
> + wlan5g {
> + label = "gl-ar750:white:wlan5g";
> + gpios = < 13 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "phy0tpt";
> + };
> +
> + };
> +
> + i2c {
> + compatible = "i2c-gpio";
> +
> + sda-gpios = < 17 GPIO_ACTIVE_LOW>;
> + scl-gpios = < 16 GPIO_ACTIVE_LOW>;
> + };
> +
> +
> +};
> +
> + {
> + status = "okay";
> +
> + wifi@0,0 {
> + compatible = "qcom,ath10k";
> + reg = <0 0 0 0 0>;
> + device_type = "pci";
> + };
> +};
> +
> + {
> + status = "okay";
> +};
> +
> + {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + hub_port: port@1 {
> + reg = <1>;
> + #trigger-source-cells = <0>;
> + };
This hub_port node is only used for a usb-port LED trigger. It can be
dropped if you don't have a USB LED.
> +};
> +
> +_phy {
> + status = "okay";
> +};
> +
> + {
> + status = "okay";
> + num-cs = <0>;
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <2500>;
> +
> + partitions {
> + compatible =
