Re: [OpenWrt-Devel] [OpenWrt] #7628: dibbler-server init script broken

2010-07-17 Thread Gioacchino Mazzurco 
Please fix this is very simple, and the fix is already submitted

2010/7/16 OpenWrt openwrt-devel@lists.openwrt.org

 #7628: dibbler-server init script broken

 ---+
  Reporter:  gmazzurc...@…  |   Owner:  developers
 Type:  defect |  Status:  new
  Priority:  normal |   Milestone:
 Component:  packages   | Version:  Trunk
  Keywords: |

 ---+
  dibbler server init script miss start argument on odibbler-server invoking

  #!/bin/sh /etc/rc.common

  START=90

  STOP=90

  start() {
 [ -d /var/lib/dibbler ] || mkdir -p /var/lib/dibbler

 dibbler-server
  }

  stop() {
 killall -9 dibbler-server
  }


  should be

  #!/bin/sh /etc/rc.common

  START=90

  STOP=90

  start() {
 [ -d /var/lib/dibbler ] || mkdir -p /var/lib/dibbler

 dibbler-server start
  }

  stop() {
 dibbler-server stop
  }

 --
 Ticket URL: https://dev.openwrt.org/ticket/7628
 OpenWrt http://openwrt.org
 Opensource Wireless Router Technology

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [OpenWrt] #7628: dibbler-server init script broken

2010-07-17 Thread Nico 
On 07/17/2010 01:15 PM, Gioacchino Mazzurco wrote:
 Please fix this is very simple, and the fix is already submitted

 2010/7/16 OpenWrt openwrt-devel@lists.openwrt.org
 mailto:openwrt-devel@lists.openwrt.org

 #7628: dibbler-server init script broken
 
 ---+
  Reporter:  gmazzurc...@…  |   Owner:  developers
 Type:  defect |  Status:  new
  Priority:  normal |   Milestone:
 Component:  packages   | Version:  Trunk
  Keywords: |
 
 ---+
  dibbler server init script miss start argument on odibbler-server
 invoking

  #!/bin/sh /etc/rc.common

  START=90

  STOP=90

  start() {
 [ -d /var/lib/dibbler ] || mkdir -p /var/lib/dibbler

 dibbler-server
  }

  stop() {
 killall -9 dibbler-server
  }


  should be

  #!/bin/sh /etc/rc.common

  START=90

  STOP=90

  start() {
 [ -d /var/lib/dibbler ] || mkdir -p /var/lib/dibbler

 dibbler-server start
  }

  stop() {
 dibbler-server stop
  }


Applied in https://dev.openwrt.org/changeset/22245

Thanks,
--
-{Nico}

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [OpenWrt] #7628: dibbler-server init script broken

2010-07-17 Thread Gioacchino Mazzurco 
very thanks!

2010/7/17 Nico n...@openwrt.org

 On 07/17/2010 01:15 PM, Gioacchino Mazzurco wrote:
  Please fix this is very simple, and the fix is already submitted
 
  2010/7/16 OpenWrt openwrt-devel@lists.openwrt.org
  mailto:openwrt-devel@lists.openwrt.org
 
  #7628: dibbler-server init script broken
 
 ---+
   Reporter:  gmazzurc...@…  |   Owner:  developers
  Type:  defect |  Status:  new
   Priority:  normal |   Milestone:
  Component:  packages   | Version:  Trunk
   Keywords: |
 
 ---+
   dibbler server init script miss start argument on odibbler-server
  invoking
 
   #!/bin/sh /etc/rc.common
 
   START=90
 
   STOP=90
 
   start() {
  [ -d /var/lib/dibbler ] || mkdir -p /var/lib/dibbler
 
  dibbler-server
   }
 
   stop() {
  killall -9 dibbler-server
   }
 
 
   should be
 
   #!/bin/sh /etc/rc.common
 
   START=90
 
   STOP=90
 
   start() {
  [ -d /var/lib/dibbler ] || mkdir -p /var/lib/dibbler
 
  dibbler-server start
   }
 
   stop() {
  dibbler-server stop
   }
 

 Applied in https://dev.openwrt.org/changeset/22245

 Thanks,
 --
 -{Nico}

 ___
 openwrt-devel mailing list
 openwrt-devel@lists.openwrt.org
 https://lists.openwrt.org/mailman/listinfo/openwrt-devel

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel