Re: [OpenWrt-Devel] [PATCH] config/Config-images.in: Fix wrong handling of ROOTFS_INCLUDE default options

[Jan Čermák]

Hello,

currently I think the best option for us is an ext4fs image with /boot in the
same partition, no squashfs+jfss2 or separated /boot partition. I saw that a few
targets are making ext4fs image, but is any of them following the current best
practices?

Cheers,
Jan

On 11.11.2015 17:31, Felix Fietkau wrote:
> On 2015-11-11 16:04, Jan Čermák wrote:
>> Hello Felix,
>>
>> On 11.11.2015 15:00, Felix Fietkau wrote:
>>> This option is apparently supported for ext4 and ubifs only. Also, the
>>> code enabled by these options is one big design flaw, and I'd like to
>>> get rid of it as soon as possible by converting all devices that need it
>>> over to the new image building code.
>>
>> because I was planning to use these options for a new target, can you give 
>> me a
>> hint what's now the correct way to create an image of ext4 FS with kernel
>> included within it?
> Do you need to keep the kernel in the same filesystem as the rest of the
> system, or can you make a small kernel partition and use the normal
> squashfs+jffs2 overlay, or does it use something else?
> 
> - Felix
> 
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] config/Config-images.in: Fix wrong handling of ROOTFS_INCLUDE default options

[Felix Fietkau]

On 2015-11-19 09:48, Jan Čermák wrote:
> Hello,
> 
> currently I think the best option for us is an ext4fs image with /boot in the
> same partition, no squashfs+jfss2 or separated /boot partition. I saw that a 
> few
> targets are making ext4fs image, but is any of them following the current best
> practices?
Even on x86 we have a separate partition for /boot. I consider it best
practice to separate the filesystem of the kernel part from the actual
root filesystem of OpenWrt, so users have the option of resetting their
system state to default without reflashing.
Using squashfs+jffs2 even on a block device also has the advantage of
being significantly more robust than ext4 wrt. power loss during
filesystem writes.

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] config/Config-images.in: Fix wrong handling of ROOTFS_INCLUDE default options

[Jan Čermák]

Hello Felix,

On 11.11.2015 15:00, Felix Fietkau wrote:
> This option is apparently supported for ext4 and ubifs only. Also, the
> code enabled by these options is one big design flaw, and I'd like to
> get rid of it as soon as possible by converting all devices that need it
> over to the new image building code.

because I was planning to use these options for a new target, can you give me a
hint what's now the correct way to create an image of ext4 FS with kernel
included within it?

Thanks
Jan
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] config/Config-images.in: Fix wrong handling of ROOTFS_INCLUDE default options

[Felix Fietkau]

On 2015-11-11 16:04, Jan Čermák wrote:
> Hello Felix,
> 
> On 11.11.2015 15:00, Felix Fietkau wrote:
>> This option is apparently supported for ext4 and ubifs only. Also, the
>> code enabled by these options is one big design flaw, and I'd like to
>> get rid of it as soon as possible by converting all devices that need it
>> over to the new image building code.
> 
> because I was planning to use these options for a new target, can you give me 
> a
> hint what's now the correct way to create an image of ext4 FS with kernel
> included within it?
Do you need to keep the kernel in the same filesystem as the rest of the
system, or can you make a small kernel partition and use the normal
squashfs+jffs2 overlay, or does it use something else?

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] config/Config-images.in: Fix wrong handling of ROOTFS_INCLUDE default options

[Petr Štetiar]

Felix Fietkau  [2015-11-11 14:48:33]:

> This is not wrong. TARGET_ROOTFS_INCLUDE_UIMAGE depends on
> TARGET_ROOTFS_INCLUDE_KERNEL, as it should.

Maybe it's not correct fix, but in current state it's somehow broken. If I
revert this patch, I can't include anything (kernels, DTBs) until I select
ext4 filesystem. Once I deselect the ext4 it lefts my config in following
state:

# CONFIG_TARGET_ROOTFS_INCLUDE_KERNEL is not set
CONFIG_TARGET_ROOTFS_INCLUDE_UIMAGE=y
CONFIG_TARGET_ROOTFS_INCLUDE_ZIMAGE=y
CONFIG_TARGET_ROOTFS_INCLUDE_FIT=y
# CONFIG_TARGET_ROOTFS_INCLUDE_DTB is not set

and I'm not able to remove the included images from menuconfig anymore.

Thanks.

-- ynezz
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] config/Config-images.in: Fix wrong handling of ROOTFS_INCLUDE default options

[Petr Štetiar]

Signed-off-by: Petr Štetiar 
---
 config/Config-images.in |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/config/Config-images.in b/config/Config-images.in
index a60dd50..cdaf5e9 100644
--- a/config/Config-images.in
+++ b/config/Config-images.in
@@ -281,24 +281,24 @@ menu "Target Images"
  below /boot.
 
config TARGET_ROOTFS_INCLUDE_UIMAGE
-   bool "include uImage" if TARGET_ROOTFS_INCLUDE_KERNEL
-   default y
+   bool "include uImage"
+   default y if TARGET_ROOTFS_INCLUDE_KERNEL
help
  This option might not apply to all targets. Make sure
  to check target/linux//image/Makefile to
  see if this option will have any effect.
 
config TARGET_ROOTFS_INCLUDE_ZIMAGE
-   bool "include zImage" if TARGET_ROOTFS_INCLUDE_KERNEL
-   default y
+   bool "include zImage"
+   default y if TARGET_ROOTFS_INCLUDE_KERNEL
help
  This option might not apply to all targets. Make sure
  to check target/linux//image/Makefile to
  see if this option will have any effect.
 
config TARGET_ROOTFS_INCLUDE_FIT
-   bool "include FIT" if TARGET_ROOTFS_INCLUDE_KERNEL
-   default y
+   bool "include FIT"
+   default y if TARGET_ROOTFS_INCLUDE_KERNEL
help
  This option might not apply to all targets. Make sure
  to check target/linux//image/Makefile to
-- 
1.7.9.5
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] config/Config-images.in: Fix wrong handling of ROOTFS_INCLUDE default options

[Felix Fietkau]

On 2015-11-11 14:56, Petr Štetiar wrote:
> Felix Fietkau  [2015-11-11 14:48:33]:
> 
>> This is not wrong. TARGET_ROOTFS_INCLUDE_UIMAGE depends on
>> TARGET_ROOTFS_INCLUDE_KERNEL, as it should.
> 
> Maybe it's not correct fix, but in current state it's somehow broken. If I
> revert this patch, I can't include anything (kernels, DTBs) until I select
> ext4 filesystem. Once I deselect the ext4 it lefts my config in following
> state:
> 
>   # CONFIG_TARGET_ROOTFS_INCLUDE_KERNEL is not set
>   CONFIG_TARGET_ROOTFS_INCLUDE_UIMAGE=y
>   CONFIG_TARGET_ROOTFS_INCLUDE_ZIMAGE=y
>   CONFIG_TARGET_ROOTFS_INCLUDE_FIT=y
>   # CONFIG_TARGET_ROOTFS_INCLUDE_DTB is not set
> 
> and I'm not able to remove the included images from menuconfig anymore.
This option is apparently supported for ext4 and ubifs only. Also, the
code enabled by these options is one big design flaw, and I'd like to
get rid of it as soon as possible by converting all devices that need it
over to the new image building code.

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] config/Config-images.in: Fix wrong handling of ROOTFS_INCLUDE default options

[Felix Fietkau]

On 2015-11-11 14:14, Petr Štetiar wrote:
> Signed-off-by: Petr Štetiar 
> ---
>  config/Config-images.in |   12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/config/Config-images.in b/config/Config-images.in
> index a60dd50..cdaf5e9 100644
> --- a/config/Config-images.in
> +++ b/config/Config-images.in
> @@ -281,24 +281,24 @@ menu "Target Images"
> below /boot.
>  
>   config TARGET_ROOTFS_INCLUDE_UIMAGE
> - bool "include uImage" if TARGET_ROOTFS_INCLUDE_KERNEL
> - default y
> + bool "include uImage"
> + default y if TARGET_ROOTFS_INCLUDE_KERNEL
This is not wrong. TARGET_ROOTFS_INCLUDE_UIMAGE depends on
TARGET_ROOTFS_INCLUDE_KERNEL, as it should.

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel