Re: [OpenWrt-Devel] [PATCH] lantiq - fix p2601hnfx leds

2012-05-23 Thread John Crispin 

 I would suggest a better title and description covering all changes.
 Only mentioning the leds in the title is insufficient.
 
 It's the most important change in this patch and reason for sending it.
 I dont see the need to comment every line in basic patch like this.


The commit message should reflect what is inside the patch. However,
owrt is not as strict yet as upstream is, so the patch is fine and i
will update the commit message when i import the patch.

Thanks,
John
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] lantiq - fix p2601hnfx leds

2012-05-23 Thread Luka Perkov 
On Wed, May 23, 2012 at 10:53:32AM +0200, John Crispin wrote:
 On 23/05/12 10:47, Conor O'Gorman wrote:
  On Wed, 2012-05-23 at 02:34 +0200, Luka Perkov wrote:
  It's the most important change in this patch and reason for sending it.
  I dont see the need to comment every line in basic patch like this.
  
  Yes, you are right, it is a small change. I just think a title such as 
  
  lantiq: p2601hnfx fix leds, partitions, buttons
  
  without even a description, would have been better. I guess the patch
  guideline 'one fix per patch' made me comment, and the better option was
  to mention each trivial fix, rather than suggest 3 trivial patches.

I will be more carefull next time. Thing is that I'm working with
several new boards and I have this in my git more than a week with
commit message fix leds...

 i agree. and the next patch should try and follow those guidelines. The
 thing is i know this patch was the result of 3 very long and hard nights
 for a few people and i can imagine that they were happy to get it out
 the door :-)

This patch is result of 1 very long night :)

Other long  hard nights how John said were spent trying to make wifi
and lan working...

 however i will use the subject proposed above when i push it and add a
 small description text.
 
 I think that would be the ideal route to resolve this and make every one
 happy...

Thank you.

Regards,
Luka
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] lantiq - fix p2601hnfx leds

2012-05-23 Thread Luca Olivetti 
Al 23/05/12 19:23, En/na Luka Perkov ha escrit:

 Other long  hard nights how John said were spent trying to make wifi
 and lan working...

At least your hard night was taken into consideration, mines were sitting in 
patchwork for ~1 year, then wrongly applied and not credited.

Bye
-- 
Luca
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] lantiq - fix p2601hnfx leds

2012-05-22 Thread Conor O'Gorman 
On Wed, 2012-05-23 at 01:10 +0200, Luka Perkov wrote:
 Leds gpio values have changed since initial patch was contributed. I
 have double checked and this are correct values.
 
 This also enables uboot_env partition.

And moves the linux partition, and removes the config partition, and the
buttons settings have small adjustments. 

I would suggest a better title and description covering all changes.
Only mentioning the leds in the title is insufficient.

Conor

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel