Re: [OpenWrt-Devel] [PATCH] mac80211: pass hostapd control socket to mesh-mode supplicant

[Daniel Hernandez]

So some quick feedback on the snapshot from yesterday . It seems to work  I 
uninstall wpad-mini and in the new version I installed. wpad-mesh-openssl



I noticed this Stack Dump via Serial port however its brief and seems to still 
work.



[cid:image001.png@01D3FCCB.CECB58B0]



-Original Message-
From: Sven Eckelmann [mailto:sven.eckelm...@openmesh.com]
Sent: Monday, June 4, 2018 8:19 AM
To: Daniel Hernandez 
Cc: openwrt-devel@lists.openwrt.org; Daniel Golle ; 
lede-...@lists.infradead.org
Subject: Re: [OpenWrt-Devel] [PATCH] mac80211: pass hostapd control socket to 
mesh-mode supplicant



On Montag, 4. Juni 2018 13:17:10 CEST Daniel Hernandez wrote:

> Hello

>

> Any clue if these fixes are going to make it into Openwrt / LEDE  18.06 . So 
> I can begin testing.



They are part of openwrt-18.06-snapshot.



Kind regards,

Sven
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] mac80211: pass hostapd control socket to mesh-mode supplicant

[Sven Eckelmann]

On Montag, 4. Juni 2018 13:17:10 CEST Daniel Hernandez wrote:
> Hello 
> 
> Any clue if these fixes are going to make it into Openwrt / LEDE  18.06 . So 
> I can begin testing. 

They are part of openwrt-18.06-snapshot.

Kind regards,
Sven

signature.asc
Description: This is a digitally signed message part.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] mac80211: pass hostapd control socket to mesh-mode supplicant

[Daniel Hernandez]

Hello 

Any clue if these fixes are going to make it into Openwrt / LEDE  18.06 . So I 
can begin testing. 

Thanks,
Danny

-Original Message-
From: Sven Eckelmann [mailto:sven.eckelm...@openmesh.com] 
Sent: Friday, April 13, 2018 4:34 AM
To: openwrt-devel@lists.openwrt.org
Cc: Daniel Golle ; lede-...@lists.infradead.org; Daniel 
Hernandez 
Subject: Re: [OpenWrt-Devel] [PATCH] mac80211: pass hostapd control socket to 
mesh-mode supplicant

On Freitag, 13. April 2018 01:41:31 CEST Daniel Golle wrote:
> Unlike when operating in Ad-Hoc mode, we apparently need to pass the 
> hostapd control socket interface to wpa_supplicant when using 802.11s 
> mesh mode.
> 
> There also seems to still be something wrong with the logic setting 
> channel and (v)htmode parameters when using AP + mesh...

I haven't tested the current state but this was basically breaking encrypted 
mesh + AP (AP never came up). Problem was the code (OpenWrt specific) in 
wpa_supplicant which called STOP_AP via this socket.

Kind regards,
Sven

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] mac80211: pass hostapd control socket to mesh-mode supplicant

[daniel]

This patch breaks encrypted mesh mode.

I agree, there is still something wrong with the logic when using encrypted 
mesh.
Also the setting of the mesh parameters fails, because nl80211_mesh_join must
happen before nl80211_update_mesh_config. This results in these errors:
---
netifd: radio1 (6314): command failed: Link has been severed (-67)
---
Originating from net/wireless/nl80211.c:nl80211_update_mesh_config():6133
through calling in 'iw set mesh_params' at /lib/netifd/wireless/mac80211.sh:678

When using mesh without encryption this is not an issue, because
'iw mesh_join' is called before 'iw set mesh_params'
in '/lib/netifd/wireless/mac80211.sh:678

With encryption the setting of the parameters need to happen after
wpa_supplicant triggered nl80211_mesh_join.

But I don't know how to solve this properly yet either...

On 04/13/2018 01:41 AM, Daniel Golle wrote:
> Unlike when operating in Ad-Hoc mode, we apparently need to pass the
> hostapd control socket interface to wpa_supplicant when using 802.11s
> mesh mode.
> 
> There also seems to still be something wrong with the logic setting
> channel and (v)htmode parameters when using AP + mesh...
> 
> Signed-off-by: Daniel Golle 
> ---
>  package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh 
> b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
> index bf9d52ae42..3a1d475a5c 100644
> --- a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
> +++ b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
> @@ -633,7 +633,7 @@ mac80211_setup_vif() {
>   if [ -n "$key" ]; then
>   wireless_vif_parse_encryption
>   freq="$(get_freq "$phy" "$channel")"
> - mac80211_setup_supplicant_noctl || failed=1
> + mac80211_setup_supplicant || failed=1
>   else
>   json_get_vars mesh_id mcast_rate
>  
> 

-- 
Regards

Daniel Danzberger
embeDD GmbH, Alter Postplatz 2, CH-6370 Stans
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] mac80211: pass hostapd control socket to mesh-mode supplicant

[Sven Eckelmann]

On Freitag, 13. April 2018 01:41:31 CEST Daniel Golle wrote:
> Unlike when operating in Ad-Hoc mode, we apparently need to pass the
> hostapd control socket interface to wpa_supplicant when using 802.11s
> mesh mode.
> 
> There also seems to still be something wrong with the logic setting
> channel and (v)htmode parameters when using AP + mesh...

I haven't tested the current state but this was basically breaking encrypted 
mesh + AP (AP never came up). Problem was the code (OpenWrt specific) in 
wpa_supplicant which called STOP_AP via this socket.

Kind regards,
Sven

signature.asc
Description: This is a digitally signed message part.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] mac80211: pass hostapd control socket to mesh-mode supplicant

[Daniel Golle]

Unlike when operating in Ad-Hoc mode, we apparently need to pass the
hostapd control socket interface to wpa_supplicant when using 802.11s
mesh mode.

There also seems to still be something wrong with the logic setting
channel and (v)htmode parameters when using AP + mesh...

Signed-off-by: Daniel Golle 
---
 package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh 
b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
index bf9d52ae42..3a1d475a5c 100644
--- a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
+++ b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
@@ -633,7 +633,7 @@ mac80211_setup_vif() {
if [ -n "$key" ]; then
wireless_vif_parse_encryption
freq="$(get_freq "$phy" "$channel")"
-   mac80211_setup_supplicant_noctl || failed=1
+   mac80211_setup_supplicant || failed=1
else
json_get_vars mesh_id mcast_rate
 
-- 
2.17.0
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel