Re: [OpenWrt-Devel] [PATCH] ramips mt7620: ArcherC20i USB support and more
Hi,
the prefix is wrong please change it to "ramips:" there is also trailing
stuff in the mail and see below
On 08/07/2015 20:57, Gunnar Thorburn wrote:
> For TP-Link Archer C20i, USB port does not work with CC/trunk.
> This patch adds two nodes (ehci, ohci) to the Device Tree, enabling USB.
>
> Signed-off-by: Gunnar Thorburn
>
> $ diff -up target/linux/ramips/dts/ArcherC20i.dts{.orig,}
> --- target/linux/ramips/dts/ArcherC20i.dts.orig 2015-07-05
> 15:27:04.763421748 +0200
> +++ target/linux/ramips/dts/ArcherC20i.dts2015-07-07 22:17:28.851225781
> +0200
this patch is created against the wrong base folder. use git to generate
proper patches please.
John
> @@ -77,6 +77,14 @@
> ralink,port-map = "w";
> };
>
> + ehci@101c {
> + status = "okay";
> + };
> +
> + ohci@101c1000 {
> + status = "okay";
> + };
> +
> gsw@1011 {
> ralink,port4 = "ephy";
> };
>
>
>
>
> 07.07.2015 11:32 wrote Jonas Gorski:
>> Hi,
>>
> [...]
>>
>> Please fix and resend.
>>
>>
>> Jonas
>
> The other changes (related to gpio, buttons, leds) I will perhaps submit in
> the future when I have tested and understood better.
>
> Gunnar
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips mt7620: ArcherC20i USB support and more
For TP-Link Archer C20i, USB port does not work with CC/trunk.
This patch adds two nodes (ehci, ohci) to the Device Tree, enabling USB.
Signed-off-by: Gunnar Thorburn
$ diff -up target/linux/ramips/dts/ArcherC20i.dts{.orig,}
--- target/linux/ramips/dts/ArcherC20i.dts.orig 2015-07-05 15:27:04.763421748
+0200
+++ target/linux/ramips/dts/ArcherC20i.dts 2015-07-07 22:17:28.851225781
+0200
@@ -77,6 +77,14 @@
ralink,port-map = "w";
};
+ ehci@101c {
+ status = "okay";
+ };
+
+ ohci@101c1000 {
+ status = "okay";
+ };
+
gsw@1011 {
ralink,port4 = "ephy";
};
07.07.2015 11:32 wrote Jonas Gorski:
> Hi,
>
[...]
>
> Please fix and resend.
>
>
> Jonas
The other changes (related to gpio, buttons, leds) I will perhaps submit in the
future when I have tested and understood better.
Gunnar
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips mt7620: ArcherC20i USB support and more
Hi,
On Mon, Jul 6, 2015 at 11:56 PM, Gunnar Thorburn wrote:
> Hi,
>
> The patch (actually the entire file) was contributed on the OpenWrt forum:
> https://forum.openwrt.org/viewtopic.php?pid=281794#p281794
> My contribution is that I have tested it and that I am trying to submit it
> here.
>
> I can confirm that:
> 1) My ArcherC20i works fine with the patch applied
> 2) USB works (which it does not do in CC without the patch)
>
> If the changes not related to USB (ehci/ohci) are questionable, I would be
> happy to resubmit a patch for just USB. I am sorry about the spaces and
> tabs. The clean patch below looks much nicer.
I'm mostly looking for a description what this patch does. You already
mentioned enabling USB in the subject, but you should also mention the
buttons/leds. Please write a commit log as you would write a commit,
without any "hello" and 'byes". And finally you dropped your
sign-off-by.
>
> Gunnar T.
>
>
> $ diff -up target/linux/ramips/dts/ArcherC20i.dts{.orig,}
> --- target/linux/ramips/dts/ArcherC20i.dts.orig 2015-07-05
> 15:27:04.763421748 +0200
> +++ target/linux/ramips/dts/ArcherC20i.dts 2015-07-06
> 23:11:04.533094775 +0200
> @@ -15,6 +15,10 @@
> status = "okay";
> };
>
Your email-client ate the spaces at the start of empty context lines,
this patch is broken.
> + gpio3: gpio@688 {
> + status = "okay";
> + };
> +
Wrong indentation.
> spi@b00 {
> status = "okay";
>
> @@ -77,8 +81,12 @@
> ralink,port-map = "w";
> };
>
> - gsw@1011 {
> - ralink,port4 = "ephy";
Why are you removing this part?
> + ehci@101c {
> + status = "okay";
> + };
> +
> + ohci@101c1000 {
> + status = "okay";
> };
>
> wmac@1018 {
> @@ -100,6 +108,18 @@
>
> gpio-leds {
> compatible = "gpio-leds";
Empty line here please.
> + lan {
> + label = "tp-link:blue:lan";
> + gpios = <&gpio0 1 1>;
> + };
Wrong indentation. Also empty line here please.
> + usb {
> + label = "tp-link:blue:usb";
> + gpios = <&gpio0 11 1>;
> + };
Empty line here please.
> + wlan {
> + label = "tp-link:blue:wlan";
> + gpios = <&gpio3 0 1>;
> + };
Wrong indentation.
> };
>
> gpio-keys-polled {
> @@ -107,5 +127,15 @@
> #address-cells = <1>;
> #size-cells = <0>;
> poll-interval = <20>;
Empty line here please.
> + reset_wps {
> + label = "reset_wps";
> + gpios = <&gpio0 13 1>;
> + linux,code = <0x198>;
> + };
Empty line here please.
> + rfkill {
> + label = "rfkill";
> + gpios = <&gpio0 2 1>;
> + linux,code = <0xf7>;
> + };
> };
> };
>
Please fix and resend.
Jonas
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips mt7620: ArcherC20i USB support and more
Hi,
The patch (actually the entire file) was contributed on the OpenWrt
forum:
https://forum.openwrt.org/viewtopic.php?pid=281794#p281794
My contribution is that I have tested it and that I am trying to submit
it here.
I can confirm that:
1) My ArcherC20i works fine with the patch applied
2) USB works (which it does not do in CC without the patch)
If the changes not related to USB (ehci/ohci) are questionable, I would
be happy to resubmit a patch for just USB. I am sorry about the spaces
and tabs. The clean patch below looks much nicer.
Gunnar T.
$ diff -up target/linux/ramips/dts/ArcherC20i.dts{.orig,}
--- target/linux/ramips/dts/ArcherC20i.dts.orig 2015-07-05
15:27:04.763421748 +0200
+++ target/linux/ramips/dts/ArcherC20i.dts 2015-07-06 23:11:04.533094775
+0200
@@ -15,6 +15,10 @@
status = "okay";
};
+ gpio3: gpio@688 {
+ status = "okay";
+ };
+
spi@b00 {
status = "okay";
@@ -77,8 +81,12 @@
ralink,port-map = "w";
};
- gsw@1011 {
- ralink,port4 = "ephy";
+ ehci@101c {
+ status = "okay";
+ };
+
+ ohci@101c1000 {
+ status = "okay";
};
wmac@1018 {
@@ -100,6 +108,18 @@
gpio-leds {
compatible = "gpio-leds";
+ lan {
+ label = "tp-link:blue:lan";
+ gpios = <&gpio0 1 1>;
+ };
+ usb {
+ label = "tp-link:blue:usb";
+ gpios = <&gpio0 11 1>;
+ };
+ wlan {
+ label = "tp-link:blue:wlan";
+ gpios = <&gpio3 0 1>;
+ };
};
gpio-keys-polled {
@@ -107,5 +127,15 @@
#address-cells = <1>;
#size-cells = <0>;
poll-interval = <20>;
+ reset_wps {
+ label = "reset_wps";
+ gpios = <&gpio0 13 1>;
+ linux,code = <0x198>;
+ };
+ rfkill {
+ label = "rfkill";
+ gpios = <&gpio0 2 1>;
+ linux,code = <0xf7>;
+ };
};
};
06.07.2015 22:54 skrev Jonas Gorski:
Hi,
Why did you replace all tabs with spaces? This makes the patch hard to
review. Please fix and resend.
Jonas
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips mt7620: ArcherC20i USB support and more
Hi,
On Mon, Jul 6, 2015 at 10:36 PM, Gunnar Thorburn wrote:
> Hi,
>
> Trunk and CC image for ArcherC20i do not support USB/leds/buttons.
> This patch is for an updated/improved .dts-file.
Please describe what you changed (added/removed/changed nodes/properties).
> See also: https://forum.openwrt.org/viewtopic.php?pid=281794#p281794
>
> Signed-off-by: Gunnar Thorburn
>
> $ diff -up target/linux/ramips/dts/ArcherC20i.dts{.orig,}
> --- target/linux/ramips/dts/ArcherC20i.dts.orig 2015-07-05
> 15:27:04.763421748 +0200
> +++ target/linux/ramips/dts/ArcherC20i.dts 2015-07-05
> 15:53:24.738509389 +0200
> @@ -3,109 +3,139 @@
> /include/ "mt7620a.dtsi"
>
> / {
> - compatible = "ralink,mt7620a-soc";
> - model = "TP-Link Archer C20i";
> +compatible = "ralink,mt7620a-soc";
> +model = "TP-Link Archer C20i";
Why did you replace all tabs with spaces? This makes the patch hard to
review. Please fix and resend.
Jonas
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] ramips mt7620: ArcherC20i USB support and more
Hi,
Trunk and CC image for ArcherC20i do not support USB/leds/buttons.
This patch is for an updated/improved .dts-file.
See also: https://forum.openwrt.org/viewtopic.php?pid=281794#p281794
Signed-off-by: Gunnar Thorburn
$ diff -up target/linux/ramips/dts/ArcherC20i.dts{.orig,}
--- target/linux/ramips/dts/ArcherC20i.dts.orig 2015-07-05
15:27:04.763421748 +0200
+++ target/linux/ramips/dts/ArcherC20i.dts 2015-07-05 15:53:24.738509389
+0200
@@ -3,109 +3,139 @@
/include/ "mt7620a.dtsi"
/ {
- compatible = "ralink,mt7620a-soc";
- model = "TP-Link Archer C20i";
+compatible = "ralink,mt7620a-soc";
+model = "TP-Link Archer C20i";
- chosen {
- bootargs = "console=ttyS0,115200";
- };
-
- palmbus@1000 {
- gpio2: gpio@660 {
- status = "okay";
- };
-
- spi@b00 {
- status = "okay";
-
- m25p80@0 {
- #address-cells = <1>;
- #size-cells = <1>;
- compatible = "en25q64";
- reg = <0 0>;
- linux,modalias = "m25p80", "mx25l6405d";
- spi-max-frequency = <1000>;
-
- partition@0 {
- label = "u-boot";
- reg = <0x0 0x2>;
- read-only;
- };
-
- partition@2 {
- label = "firmware";
- reg = <0x2 0x7a>;
- };
-
- partition@7c {
- label = "config";
- reg = <0x7c 0x1>;
- };
-
- rom: partition@7d {
- label = "rom";
- reg = <0x7d 0x1>;
- };
-
- partition@7e {
- label = "romfile";
- reg = <0x7e 0x1>;
- };
-
- radio: partition@7f {
- label = "radio";
- reg = <0x7f 0x1>;
- };
- };
- };
- };
-
- pinctrl {
- state_default: pinctrl0 {
- gpio {
- ralink,group = "i2c", "uartf", "rgmii1", "rgmii2",
"wled", "nd_sd";
- ralink,function = "gpio";
- };
- };
- };
-
- ethernet@1010 {
- pinctrl-names = "default";
- pinctrl-0 = <&ephy_pins>;
-
- mtd-mac-address = <&rom 0xf100>;
- ralink,port-map = "w";
- };
-
- gsw@1011 {
- ralink,port4 = "ephy";
- };
-
- wmac@1018 {
- ralink,mtd-eeprom = <&radio 0>;
- };
-
- pcie@1014 {
- status = "okay";
-
- pcie-bridge {
- mt76@0,0 {
- reg = <0x 0 0 0 0>;
- device_type = "pci";
- mediatek,mtd-eeprom = <&radio 32768>;
- mediatek,2ghz = <0>;
- };
- };
- };
-
- gpio-leds {
- compatible = "gpio-leds";
- };
-
- gpio-keys-polled {
- compatible = "gpio-keys-polled";
- #address-cells = <1>;
- #size-cells = <0>;
- poll-interval = <20>;
- };
+chosen {
+bootargs = "console=ttyS0,115200";
+};
+
+palmbus@1000 {
+gpio2: gpio@660 {
+status = "okay";
+};
+
+gpio3: gpio@688 {
+status = "okay";
+};
+
+spi@b00 {
+status = "okay";
+
+m25p80@0 {
+#address-cells = <1>;
+#size-cells = <1>;
+compatible = "en25q64";
+reg = <0 0>;
+linux,modalias = "m25p80", "mx25l6405d";
+spi-max-frequency = <1000>;
+
+partition@0 {
+label = "u-boot";
+reg = <0x0 0x2>;
+read-only;
+};
+
+partition@2 {
+label = "firmware";
+reg = <0x2 0x7a>;
+};
+
+partition
