Re: [OpenWrt-Devel] [PATCH 3/3] sunxi: add support for Linux 3.19

2015-02-11 Thread John Crispin


On 11/02/2015 00:13, Daniel Golle wrote:
 Is there anything wrong with that? Or did anyone feel offended by
 that?

no just pointing out that this might lead to the work not being used,
which ended up being the case.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 3/3] sunxi: add support for Linux 3.19

2015-02-11 Thread Zoltan HERPAI

On Wed, 11 Feb 2015, Luka Perkov wrote:


zoltan maintains the sunxi target. he might already have done work on
this and might have some updates or whatever that he plans to
incorporate. bumping a kernel maintained actively always has the risk
of duplicating work and / or doing superfluous work


Well, yes, that's why I put Zoltan on CC for that patch (you can't
see that as the list server apparently removes CC's if the receiver
is among the list subscribers).

And sure, he might already have it ready himself or do things as he
likes to, e.g. more testing on all boards before pushing the commit.
I did this bump to 3.19 this morning because I was impatient to see if
framebuffer works as it was promissed for 3.19 on sun7i. And it does.
I was happy to see that and felt that it may make sense to publish my
results.

Note that my motivation when porting the patches was my own curiosity
and it was fun doing it -- no matter, if any picks them up or not.
Just in case Zoltan starts working on 3.19 tomorrow, he'll already have
a reference point to start with.
If he already got it ready and just wants to do more testing before
pushing the commit -- fine, this might have been a waste of time when
looking at it from an economic point of view. Just that my motiviation
was self-education rather than just using my time as efficient as I can.

Is there anything wrong with that?
Or did anyone feel offended by that?


Not at all. Please continue with good work. I only wish I've seen your
patch sooner ;)


Don't start a fight over my head without me. :)

Daniel, thanks for the patches for bringing sunxi up to 3.19. I already 
had done some work, but this patchset helps, so I'll work it in and add 
you as SoB when committing.


One small note, it might be worth to send generic and 
target_foo-related in separate series to the list, so they could be 
picked up and committed separately, avoiding unnecessary confusion. 
(That's just my $.02 though.)


Thanks,
-w-
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 3/3] sunxi: add support for Linux 3.19

2015-02-11 Thread Luka Perkov
Hi Daniel,

On Wed, Feb 11, 2015 at 12:13:13AM +0100, Daniel Golle wrote:
 On Tue, Feb 10, 2015 at 10:46:53PM +0100, John Crispin wrote:
  zoltan maintains the sunxi target. he might already have done work on
  this and might have some updates or whatever that he plans to
  incorporate. bumping a kernel maintained actively always has the risk
  of duplicating work and / or doing superfluous work
 
 Well, yes, that's why I put Zoltan on CC for that patch (you can't
 see that as the list server apparently removes CC's if the receiver
 is among the list subscribers).
 
 And sure, he might already have it ready himself or do things as he
 likes to, e.g. more testing on all boards before pushing the commit.
 I did this bump to 3.19 this morning because I was impatient to see if
 framebuffer works as it was promissed for 3.19 on sun7i. And it does.
 I was happy to see that and felt that it may make sense to publish my
 results.
 
 Note that my motivation when porting the patches was my own curiosity
 and it was fun doing it -- no matter, if any picks them up or not.
 Just in case Zoltan starts working on 3.19 tomorrow, he'll already have
 a reference point to start with.
 If he already got it ready and just wants to do more testing before
 pushing the commit -- fine, this might have been a waste of time when
 looking at it from an economic point of view. Just that my motiviation
 was self-education rather than just using my time as efficient as I can.
 
 Is there anything wrong with that?
 Or did anyone feel offended by that?

Not at all. Please continue with good work. I only wish I've seen your
patch sooner ;)

Luka
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 3/3] sunxi: add support for Linux 3.19

2015-02-10 Thread Rafał Miłecki
On 10 February 2015 at 15:09, Daniel Golle dan...@makrotopia.org wrote:
 simple-framebuffer now works on the A20.

I'm really not sure about other developers opinion (will be happy to
hear it), but I guess you could try to generate a patch using git and
git format-patch -C

That would allow ppl/developers to review changes you had to made.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 3/3] sunxi: add support for Linux 3.19

2015-02-10 Thread John Crispin


On 10/02/2015 22:42, Rafał Miłecki wrote:
 On 10 February 2015 at 15:09, Daniel Golle dan...@makrotopia.org
 wrote:
 simple-framebuffer now works on the A20.
 
 I'm really not sure about other developers opinion (will be happy
 to hear it), but I guess you could try to generate a patch using
 git and git format-patch -C
 
 That would allow ppl/developers to review changes you had to made.


zoltan maintains the sunxi target. he might already have done work on
this and might have some updates or whatever that he plans to
incorporate. bumping a kernel maintained actively always has the risk
of duplicating work and / or doing superfluous work



 ___ openwrt-devel
 mailing list openwrt-devel@lists.openwrt.org 
 https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
 
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 3/3] sunxi: add support for Linux 3.19

2015-02-10 Thread Daniel Golle
On Tue, Feb 10, 2015 at 10:46:53PM +0100, John Crispin wrote:
 zoltan maintains the sunxi target. he might already have done work on
 this and might have some updates or whatever that he plans to
 incorporate. bumping a kernel maintained actively always has the risk
 of duplicating work and / or doing superfluous work

Well, yes, that's why I put Zoltan on CC for that patch (you can't
see that as the list server apparently removes CC's if the receiver
is among the list subscribers).

And sure, he might already have it ready himself or do things as he
likes to, e.g. more testing on all boards before pushing the commit.
I did this bump to 3.19 this morning because I was impatient to see if
framebuffer works as it was promissed for 3.19 on sun7i. And it does.
I was happy to see that and felt that it may make sense to publish my
results.

Note that my motivation when porting the patches was my own curiosity
and it was fun doing it -- no matter, if any picks them up or not.
Just in case Zoltan starts working on 3.19 tomorrow, he'll already have
a reference point to start with.
If he already got it ready and just wants to do more testing before
pushing the commit -- fine, this might have been a waste of time when
looking at it from an economic point of view. Just that my motiviation
was self-education rather than just using my time as efficient as I can.

Is there anything wrong with that?
Or did anyone feel offended by that?


Cheers


Daniel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel