Re: [OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

[Lars]

That wasn't less discouraging -- you shouldn't pathologize a behaviour
if you simply want to express that they're being dicks.

Piotr, thanks for your work, keep it up!

On 18.08.2015 06:14, Jonathan Bennett wrote:
 Those sort of emails are always just a bit discouraging. Keep in mind
 that they tend to come from people that are slightly autistic or have
 Aspergers.


0x7E86809F.asc
Description: application/pgp-keys
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

[Piotr Dymacz]

Hello,

2015-08-18 6:04 GMT+02:00 郭传鈜 gch981...@gmail.com:
 Hi!
 I just wonder why you chose to use the board name in LED
 names?

Please, take a look at first version of my series and discussion about
device:color:led-name convention: [1].
I thought that OpenWrt uses different convention:
manufacturer:color:led-name, but if you look deeper, we have both
approaches in code.

As an example, take a look at current version of diag.sh script in
ar71xx target [2].
There is exactly the same mix as it was in ramips target before my
cleans - some of boards follow upstream convention and rest don't.

 Sometimes we can use the same dts file for different boards.For
 example, in ar71xx wr841nd-v3 wr941nd-v2 and wr941nd-v3 shares
 mach-tl-wr941nd-v2.c(I haven't found such examples in ramips target.)I
 think the LED name will be a bit strange in this situation:-(

Yes, that's good point and I was thinking about the same problem.

IMHO, using same LED names for different boards is a mistake (assuming
that we switch to upstream convention).
Take TL-MR3420 v2 as an example ([3]) - for me it's not a TL-WR841N v8
clone. They are similar from hardware POV (same platform, almost the
same specification), but manufacturer gave them different model names,
not without a reason.

That means all boards should have own names for LEDs. Question is how
to do it without duplicating and increasing code size.
What's more, what should we do with boards like TL-WR841N/ND vx -
should they share same code and use something like
tl-wr841nx-vx:color:led-name convention or separate that too
(tl-wr841n-v8:..., tl-wr841nd-v8..., tl-wr841nd-v7:..:, etc.)?
And what to do with clones like Mercury or Fast?

Maybe we should have separate mach-* files for all supported boards,
but then... what about DRY (don’t repeat yourself)?

Cheers,
Piotr

[1] http://patchwork.ozlabs.org/patch/500071/
[2] 
https://dev.openwrt.org/browser/trunk/target/linux/ar71xx/base-files/etc/diag.sh
[3] 
https://dev.openwrt.org/browser/trunk/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wr841n-v8.c#L254

 2015-08-17 19:24 GMT+08:00 Piotr Dymacz pep...@gmail.com:
 2015-08-17 8:28 GMT+02:00 John Crispin blo...@openwrt.org:
 Hi,

 just merged the whole lot. thanks a lot. what do you want to do next
 lantiq or ar71xx ? :) personally i would prefer ar71xx ;)
 [...]

 Hello John,

 It seems that there are some people who don't like the changes (see
 below), but they don't have enough courage to use their real name and
 post their comments on the list.

 I will back with answers for your and Michael Heimpold (I'm sorry, I
 didn't spot your e-mail before!) questions in few days. Now I'm really
 busy with other things.

 Cheers,
 Piotr Dymacz

 ---

 2015-08-17 13:05 GMT+02:00 West Fuck deutch...@anonmail.de:
 https://dev.openwrt.org/changeset/46617

 of all the bugs on related system you have choosen to change board and led
 names? why do you stick your nose into something that is not relevant? is it
 because your'e stupid fucking excuse for human being? you couldn't even make
 your uboot work without errors on some boards so why don't you stick to your
 own crap instead of acting like your're doing something
 ___
 openwrt-devel mailing list
 openwrt-devel@lists.openwrt.org
 https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

[Piotr Dymacz]

2015-08-17 8:28 GMT+02:00 John Crispin blo...@openwrt.org:
 Hi,

 just merged the whole lot. thanks a lot. what do you want to do next
 lantiq or ar71xx ? :) personally i would prefer ar71xx ;)
 [...]

Hello John,

It seems that there are some people who don't like the changes (see
below), but they don't have enough courage to use their real name and
post their comments on the list.

I will back with answers for your and Michael Heimpold (I'm sorry, I
didn't spot your e-mail before!) questions in few days. Now I'm really
busy with other things.

Cheers,
Piotr Dymacz

---

2015-08-17 13:05 GMT+02:00 West Fuck deutch...@anonmail.de:
 https://dev.openwrt.org/changeset/46617

 of all the bugs on related system you have choosen to change board and led
 names? why do you stick your nose into something that is not relevant? is it
 because your'e stupid fucking excuse for human being? you couldn't even make
 your uboot work without errors on some boards so why don't you stick to your
 own crap instead of acting like your're doing something
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

[Sławomir Demeszko]

W dniu 17.08.2015 o 13:24, Piotr Dymacz pisze:
 It seems that there are some people who don't like the changes

Hi.

Don't bother that kind of people. There will be always someone who like mess. Cleanup is 
always good, especially for other people, who need to work with that code later. OpenWRT 
developers introduced some rules for patches due the same reason. Thanks for your work.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

[郭传鈜]

Hi!
I just wonder why you chose to use the board name in LED
names?Sometimes we can use the same dts file for different boards.For
example, in ar71xx wr841nd-v3 wr941nd-v2 and wr941nd-v3 shares
mach-tl-wr941nd-v2.c(I haven't found such examples in ramips target.)I
think the LED name will be a bit strange in this situation:-(

2015-08-17 19:24 GMT+08:00 Piotr Dymacz pep...@gmail.com:
 2015-08-17 8:28 GMT+02:00 John Crispin blo...@openwrt.org:
 Hi,

 just merged the whole lot. thanks a lot. what do you want to do next
 lantiq or ar71xx ? :) personally i would prefer ar71xx ;)
 [...]

 Hello John,

 It seems that there are some people who don't like the changes (see
 below), but they don't have enough courage to use their real name and
 post their comments on the list.

 I will back with answers for your and Michael Heimpold (I'm sorry, I
 didn't spot your e-mail before!) questions in few days. Now I'm really
 busy with other things.

 Cheers,
 Piotr Dymacz

 ---

 2015-08-17 13:05 GMT+02:00 West Fuck deutch...@anonmail.de:
 https://dev.openwrt.org/changeset/46617

 of all the bugs on related system you have choosen to change board and led
 names? why do you stick your nose into something that is not relevant? is it
 because your'e stupid fucking excuse for human being? you couldn't even make
 your uboot work without errors on some boards so why don't you stick to your
 own crap instead of acting like your're doing something
 ___
 openwrt-devel mailing list
 openwrt-devel@lists.openwrt.org
 https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

[Jonathan Bennett]

Those sort of emails are always just a bit discouraging. Keep in mind that
they tend to come from people that are slightly autistic or have Aspergers.

From the rest of us, though, thank you for your hard work.

--Jonathan Bennett

On Mon, Aug 17, 2015 at 6:24 AM Piotr Dymacz pep...@gmail.com wrote:

 2015-08-17 8:28 GMT+02:00 John Crispin blo...@openwrt.org:
  Hi,
 
  just merged the whole lot. thanks a lot. what do you want to do next
  lantiq or ar71xx ? :) personally i would prefer ar71xx ;)
  [...]

 Hello John,

 It seems that there are some people who don't like the changes (see
 below), but they don't have enough courage to use their real name and
 post their comments on the list.

 I will back with answers for your and Michael Heimpold (I'm sorry, I
 didn't spot your e-mail before!) questions in few days. Now I'm really
 busy with other things.

 Cheers,
 Piotr Dymacz

 ---

 2015-08-17 13:05 GMT+02:00 West Fuck deutch...@anonmail.de:
  https://dev.openwrt.org/changeset/46617
 
  of all the bugs on related system you have choosen to change board and
 led
  names? why do you stick your nose into something that is not relevant?
 is it
  because your'e stupid fucking excuse for human being? you couldn't even
 make
  your uboot work without errors on some boards so why don't you stick to
 your
  own crap instead of acting like your're doing something
 ___
 openwrt-devel mailing list
 openwrt-devel@lists.openwrt.org
 https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

[Piotr Dymacz]

The following changes fix different mistakes in ramips target and try to make 
the code more clean and consistent.

The patches affect:
 * dts{,i} files
 * base-files/* scripts
 * image Makefile
 * subtargets *.mk profile files

Changes in v2 of the series:
 * rebased to r46566
 * use the upstream convention for LED naming
 * more fixes in dts{,i} files
 * patches are now ordered more logically
 * patches are now better described
 * additional fixes related with devices names
 * big patches related with particular devices are not combined together, for 
easy review

Piotr Dymacz (25):
  ramips: fix indentation and other mistakes in .dts{,i} files
  ramips: fix Zbtlink ZBT-WR8305RT board name
  ramips: fix Asus WL-330N{,3G} boards names
  ramips: fix Asus RP-N53 and Lenovo Y1{,S} image names
  ramips: fix Xiaomi MiWiFi Mini board, image and profile names
  ramips: fix UPVEL model names
  ramips: fix Asus RT-N56U dts filename
  ramips: fix Belkin F7C027 image name
  ramips: fix Argus ATP-52B board and image names
  ramips: fix Sitecom WL-341v3 board and image names
  ramips: fix Olimex models, images and profiles names
  ramips: fix Aigale Ai-BR100 dts and profile names
  ramips: fix Tenda W150M model name
  ramips: fix Edimax BR-6425 board name
  ramips: fix Omnima models, images and profiles names
  ramips: fix Buffalo WMR-300 dts, board, image and profile names
  ramips: fix 7Links PX-4885 dts{,i}, board, image and profile names
  ramips: remove old code for Edimax BR-6524N
  ramips: fix various mistakes in subtargets *.mk profiles
  ramips: remove leading spaces, sort boards and optimize
base-files/lib/ramips.sh
  ramips: be consistent with case statement in
base-files/lib/upgrade/platform.sh
  ramips: fix indentation, case statements structure and optimize
base-files/etc/board.d/02_network
  ramips: remove unnecessary LED declaration for WT1520 in diag.sh
  ramips: use consistent naming scheme for LEDs
  ramips: base-files: optimize etc/diag.sh and etc/board.d/01_leds
scripts

 target/linux/ramips/base-files/etc/board.d/01_leds | 480 ++---
 .../linux/ramips/base-files/etc/board.d/02_network | 391 -
 target/linux/ramips/base-files/etc/diag.sh | 338 ++-
 target/linux/ramips/base-files/lib/ramips.sh   | 436 +--
 .../ramips/base-files/lib/upgrade/platform.sh  | 234 +-
 target/linux/ramips/dts/3G-6200N.dts   |  12 +-
 target/linux/ramips/dts/3G-6200NL.dts  |   5 +-
 target/linux/ramips/dts/3G150B.dts |  10 +-
 target/linux/ramips/dts/3G300M.dts |  21 +-
 target/linux/ramips/dts/A5-V11.dts |   6 +
 target/linux/ramips/dts/AI-BR100.dts   | 109 +
 target/linux/ramips/dts/AIBR100.dts| 106 -
 target/linux/ramips/dts/AIR3GII.dts|   8 +-
 target/linux/ramips/dts/ALL0239-3G.dts |  16 +-
 target/linux/ramips/dts/ALL0256N-4M.dts|   5 +
 target/linux/ramips/dts/ALL0256N-8M.dts|   5 +
 target/linux/ramips/dts/ALL5002.dts|   8 +-
 target/linux/ramips/dts/ALL5003.dts|   8 +-
 target/linux/ramips/dts/AR670W.dts |   4 +-
 target/linux/ramips/dts/AR725W.dts |   4 +-
 target/linux/ramips/dts/ARGUS_ATP52B.dts   |  93 
 target/linux/ramips/dts/ASL26555-16M.dts   |  17 +
 target/linux/ramips/dts/ASL26555-8M.dts|  16 +
 target/linux/ramips/dts/ATP-52B.dts|  96 +
 target/linux/ramips/dts/AWAPN2403.dts  |   7 +-
 target/linux/ramips/dts/AWM002-EVB-4M.dts  |   5 +
 target/linux/ramips/dts/AWM002-EVB-8M.dts  |   5 +
 target/linux/ramips/dts/AWM002.dtsi|   7 +-
 target/linux/ramips/dts/AWM003-EVB.dts |  11 +-
 target/linux/ramips/dts/ArcherC20i.dts |   1 -
 target/linux/ramips/dts/BC2.dts|   3 +-
 target/linux/ramips/dts/BR-6425.dts|   9 +-
 target/linux/ramips/dts/BR-6475ND.dts  |  15 +-
 target/linux/ramips/dts/BROADWAY.dts   |   8 +-
 target/linux/ramips/dts/CARAMBOLA.dts  |   2 -
 target/linux/ramips/dts/CF-WR800N.dts  |  31 +-
 target/linux/ramips/dts/CY-SWR1100.dts |  17 +-
 target/linux/ramips/dts/D105.dts   |   4 +-
 target/linux/ramips/dts/DAP-1350.dts   |  14 +-
 target/linux/ramips/dts/DCS-930.dts|  11 +-
 target/linux/ramips/dts/DCS-930L-B1.dts|  11 +-
 target/linux/ramips/dts/DIR-300-B1.dts |  18 +-
 target/linux/ramips/dts/DIR-300-B7.dts |  74 ++--
 target/linux/ramips/dts/DIR-320-B1.dts |  32 +-
 target/linux/ramips/dts/DIR-600-B1.dts |  18 +-
 target/linux/ramips/dts/DIR-600-B2.dts |  18 +-
 target/linux/ramips/dts/DIR-610-A1.dts |  29 +-
 

Re: [OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

[Michael Heimpold]

Hi Piotr,

great work!

While looking at your DT cleanups, I wonder whether it would be possible to
go one step further and adopt the BuildDTB stuff which Jonas did for brcm63xx 
target:
then it would be possible to use preprocessor includes in the DTS files and use 
defines like KEY_* and so on.

And it would be great, if you could provide a git url to pull your series from 
:-)

Regards, mhei

Am Mittwoch, 5. August 2015, 20:30:01 schrieb Piotr Dymacz:
 The following changes fix different mistakes in ramips target and try to make 
 the code more clean and consistent.
 
 The patches affect:
  * dts{,i} files
  * base-files/* scripts
  * image Makefile
  * subtargets *.mk profile files
 
 Changes in v2 of the series:
  * rebased to r46566
  * use the upstream convention for LED naming
  * more fixes in dts{,i} files
  * patches are now ordered more logically
  * patches are now better described
  * additional fixes related with devices names
  * big patches related with particular devices are not combined together, for 
 easy review
 
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel