Re: [OpenWrt-Devel] [PATCH v2 1/1] lm-sensors: split out sensors-detect from rest of package
On Fri, May 06, 2011 at 04:00:19PM -0600, Philip Prindeville wrote: On 5/6/11 12:06 PM, Luka Perkov wrote: On Thu, May 05, 2011 at 05:28:43PM -0600, Philip Prindeville wrote: Since sensors-detect isn't always needed where sensors is used, and has unexpressed dependency on perl, it might make more sense to have this be separated out... Redux with better perl dependencies. Applied in 26838 with minor changes. Tips for next time: * you forgot to bump PKG_RELEASE because PKG_VERSION stayed the same * reply to your own mails when resubmitting the patch * for small patches like this one you did not have to make 'announcement' * send patch inline More info here: https://dev.openwrt.org/wiki/SubmittingPatches Thank you, Luka Unfortunately, I'm using Thunderbird which is known to mangle leading whitespace on patches... so attachments are required. Which announcement were you referring to? I was referring to this mail: https://lists.openwrt.org/pipermail/openwrt-devel/2011-May/010760.html But I but did not read it carefully... It's not 'announcement' :) Luka ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH v2 1/1] lm-sensors: split out sensors-detect from rest of package
On Thu, May 05, 2011 at 05:28:43PM -0600, Philip Prindeville wrote: Since sensors-detect isn't always needed where sensors is used, and has unexpressed dependency on perl, it might make more sense to have this be separated out... Redux with better perl dependencies. Applied in 26838 with minor changes. Tips for next time: * you forgot to bump PKG_RELEASE because PKG_VERSION stayed the same * reply to your own mails when resubmitting the patch * for small patches like this one you did not have to make 'announcement' * send patch inline More info here: https://dev.openwrt.org/wiki/SubmittingPatches Thank you, Luka ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH v2 1/1] lm-sensors: split out sensors-detect from rest of package
Since sensors-detect isn't always needed where sensors is used, and has unexpressed dependency on perl, it might make more sense to have this be separated out... Redux with better perl dependencies. Index: feeds/packages/utils/lm-sensors/Makefile === --- feeds/packages/utils/lm-sensors/Makefile(revision 26815) +++ feeds/packages/utils/lm-sensors/Makefile(working copy) @@ -34,6 +34,15 @@ DEPENDS+=+libsensors endef +define Package/lm-sensors-detect + $(call Package/lm-sensors/Default) + SECTION:=utils + CATEGORY:=Utilities + TITLE:=lm-sensors-detect + DEPENDS+=+lm-sensors +perl +perlbase-essential +perlbase-fcntl \ + +perlbase-file +perlbase-xsloader +endef + define Package/libsensors $(call Package/lm-sensors/Default) SECTION:=libs @@ -45,6 +54,10 @@ Utility to read hardware sensor data endef +define Package/lm-sensors-detect/description + Script to autodetect sensor hardware +endef + define Package/libsensors/description lm-sensors libraries endef @@ -79,17 +92,22 @@ define Package/lm-sensors/install $(INSTALL_DIR) $(1)/usr/sbin $(INSTALL_BIN) $(PKG_BUILD_DIR)/prog/sensors/sensors $(1)/usr/sbin - $(INSTALL_BIN) $(PKG_BUILD_DIR)/prog/detect/sensors-detect $(1)/usr/sbin ifeq ($(ARCH),i386) $(INSTALL_DIR) $(1)/etc $(INSTALL_CONF) ./files/sensors.conf $(1)/etc/sensors.conf endif endef +define Package/lm-sensors-detect/install + $(INSTALL_DIR) $(1)/usr/sbin + $(INSTALL_BIN) $(PKG_BUILD_DIR)/prog/detect/sensors-detect $(1)/usr/sbin +endef + define Package/libsensors/install $(INSTALL_DIR) $(1)/usr/lib $(INSTALL_DATA) $(PKG_BUILD_DIR)/lib/libsensors.so* $(1)/usr/lib endef $(eval $(call BuildPackage,lm-sensors)) +$(eval $(call BuildPackage,lm-sensors-detect)) $(eval $(call BuildPackage,libsensors)) ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
