Re: [OpenWrt-Devel] Archer C7, leds and led trigger for ath10k
On 17/01/2015 19:19, Gianluca Anzolin wrote: Il 17/01/2015 13:53, John Crispin ha scritto: On 17/01/2015 08:42, Gianluca Anzolin wrote: Il 17/01/2015 07:41, John Crispin ha scritto: There is also a bugreport in the bug tracking system pointing at this issue: https://dev.openwrt.org/ticket/18188 I looked at the ath9k implementation and I've come up with the attached patch. Do you think a patch like this is acceptable? it is not do you care to elaborate? what's wrong with it? Gianluca _ imho fixing target/linux/ar71xx/base-files/etc/uci-defaults/01_leds is enough nd not driver patch is required I don't get it, how do you create a throughput trigger by changing a script? ok, i misread your patch. the first half says the leds are swapped so i pointed you at the code that sets up the leds. i will talk to felix about the patch Gianluca ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Archer C7, leds and led trigger for ath10k
On 17/01/2015 08:42, Gianluca Anzolin wrote: Il 17/01/2015 07:41, John Crispin ha scritto: There is also a bugreport in the bug tracking system pointing at this issue: https://dev.openwrt.org/ticket/18188 I looked at the ath9k implementation and I've come up with the attached patch. Do you think a patch like this is acceptable? it is not do you care to elaborate? what's wrong with it? Gianluca _ imho fixing target/linux/ar71xx/base-files/etc/uci-defaults/01_leds is enough nd not driver patch is required __ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Archer C7, leds and led trigger for ath10k
On 16/01/2015 19:57, Gianluca Anzolin wrote: Hi, I noticed that on Archer C7 the 2.4Ghz and 5Ghz leds are swapped: this is the relevant section of /etc/config/system config led 'led_wlan2g' option name 'WLAN2G' option sysfs 'tp-link:blue:wlan2g' option trigger 'phy0tpt' config led 'led_wlan5g' option name 'WLAN5G' option sysfs 'tp-link:blue:wlan5g' option trigger 'phy1tpt' However on Archer C7 the 5G interface is on phy0 and 2.4G is on phy1. I've yet to find where (and how) this section is autogenerated but I noticed that the phy0pt trigger doesn't even exist on my system. look at target/linux/ar71xx/base-files/etc/uci-defaults/01_leds There is also a bugreport in the bug tracking system pointing at this issue: https://dev.openwrt.org/ticket/18188 I looked at the ath9k implementation and I've come up with the attached patch. Do you think a patch like this is acceptable? it is not Thank you, Gianluca ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
