Re: [OpenWrt-Devel] DTS Style: Referring to "Upstream" Nodes

2019-04-10 Thread Petr Štetiar
Jeff Kletsky  [2019-04-09 07:31:46]:

Hi,

> In general, within an OpenWrt DTS that `#include "some_linux_supplied.dtsi"`
> is it preferred to refer to a node defined in upstream code by label, or by
> path?

well, it has nothing to do with OpenWrt, this looks more like a general DTS
question and could be answered by either consulting the DTS specs or just by
grepping the Linux kernel/OpenWrt DTSes and look for acceptable examples.

> For example, with `blsp1_spi2: spi@78b6000` in the upstream-controlled DTS,
> prefer
> 
>     _spi2
> 
> or (taking into account scope or path, as needed)
> 
>     spi@78b6000

I would say, that whatever works for you and makes the dtc compiler happy,
i.e.  doesn't spill out any warnings.

-- ynezz

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] DTS Style: Referring to "Upstream" Nodes

2019-04-09 Thread Jeff Kletsky

In general, within an OpenWrt DTS that `#include "some_linux_supplied.dtsi"`
is it preferred to refer to a node defined in upstream code by label, or 
by path?


For example, with `blsp1_spi2: spi@78b6000` in the upstream-controlled 
DTS, prefer


    _spi2

or (taking into account scope or path, as needed)

    spi@78b6000


Thanks,


Jeff









___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel