Re: [OpenWrt-Devel] Question about pulling out the latest revision of sources for openwrt tagged sources

2013-05-17 Thread Felix Fietkau
On 2013-05-16 8:13 PM, Jiri Slachta wrote:
 Hello everyone,
 
 I would love to start an open discussion.
 
 There is a little issue with checking out the latest revision of
 sources for package asteriskXX-chan-sccp-b. Those sources are OpenWrt
 tagged, so it should consist of stable sources to be compiled. Even
 if those sources are release-candidate, they are more stable and
 functional than every previous stable release that was released to
 this date. Once the stable release will be rolled out, the package
 variables will be switched to tarball.
 
 Package freeswitch does the same, except the one thing - it pulls the
 latest HEAD revision if it's told to pull it out (CONFIG_FS_...),
 otherwise it pulls out the default revision. I would love to do the
 opposite - to always pull the latest revision. (see
 http://git.nanl.de/?p=openwrt/telephony.git;a=blob;f=freeswitch/Makefile
 )
 
 Is it acceptable to always check out the latest revision, or should
 we stick with specific revision? What do you think about that?
A package should always build a specific revision. The reason for this
is simple: sometimes people want to build older versions to check for
regressions, or build a particular older version of OpenWrt, including
the versions of packages that were used at that time.
This becomes impossible or impractical if packages suddenly start
becoming moving targets and older versions of packages start randomly
breaking because the upstream SVN changed.

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] Question about pulling out the latest revision of sources for openwrt tagged sources

2013-05-16 Thread Jiri Slachta
Hello everyone,

I would love to start an open discussion.

There is a little issue with checking out the latest revision of sources for 
package asteriskXX-chan-sccp-b. Those sources are OpenWrt tagged, so it should 
consist of stable sources to be compiled. Even if those sources are 
release-candidate, they are more stable and functional than every previous 
stable release that was released to this date. Once the stable release will be 
rolled out, the package variables will be switched to tarball.

Package freeswitch does the same, except the one thing - it pulls the latest 
HEAD revision if it's told to pull it out (CONFIG_FS_...), otherwise it pulls 
out the default revision. I would love to do the opposite - to always pull the 
latest revision. (see 
http://git.nanl.de/?p=openwrt/telephony.git;a=blob;f=freeswitch/Makefile )

Is it acceptable to always check out the latest revision, or should we stick 
with specific revision? What do you think about that?

PKG_REV=$(shell svn info 
'https://svn.code.sf.net/p/chan-sccp-b/code/tags/openwrt' | sed -En 
's/^Revision: (.+)/\1/p' | head -n1)
PKG_VERSION:=4.1r$(PKG_REV)

Thank you for your ideas!

Jiri
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel