Re: [PATCH] bcm53xx: disable NVMEM driver

2023-08-03 Thread Arınç ÜNAL

On 1.08.2023 15:28, Arınç ÜNAL wrote:

On 1.08.2023 15:16, Rafał Miłecki wrote:

On 2023-08-01 12:42, Arınç ÜNAL wrote:

The NVMEM_BRCM_NVRAM driver won't work properly with NVRAM in NAND. It
causes the devices with NVRAM in NAND, such as ASUS RT-AC88U, to 
bootloop.

Until the driver is fixed, disable it.


Driver works and it useful for non-NAND devices. By disabling it you
regress those devices. Surely this can be handled better.


How about making a subtarget for NAND devices? The kernel config will be 
separate so we can disable NVMEM for that subtarget.


Do you approve this? I don't intend to send another patch for you to 
shoot down.


Arınç

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH] bcm53xx: disable NVMEM driver

2023-08-01 Thread Arınç ÜNAL

On 1.08.2023 15:16, Rafał Miłecki wrote:

On 2023-08-01 12:42, Arınç ÜNAL wrote:

The NVMEM_BRCM_NVRAM driver won't work properly with NVRAM in NAND. It
causes the devices with NVRAM in NAND, such as ASUS RT-AC88U, to 
bootloop.

Until the driver is fixed, disable it.


Driver works and it useful for non-NAND devices. By disabling it you
regress those devices. Surely this can be handled better.


How about making a subtarget for NAND devices? The kernel config will be 
separate so we can disable NVMEM for that subtarget.


You mentioned contacting Broadcom regarding this issue around 6 months 
ago. Any news on that?





Disable NVMEM too as the bgmac_bcma driver will hang trying to 
retrieve the

MAC address without NVMEM_BRCM_NVRAM enabled.


This would be nice to fix instead hiding the bug.


I've got no interest to learn the NVMEM subsystem to take a crack at 
fixing it at the moment. For now, the best I can do is send a separate 
mail to openwrt-devel as a mean to report this bug.


Arınç

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH] bcm53xx: disable NVMEM driver

2023-08-01 Thread Rafał Miłecki

On 2023-08-01 12:42, Arınç ÜNAL wrote:

The NVMEM_BRCM_NVRAM driver won't work properly with NVRAM in NAND. It
causes the devices with NVRAM in NAND, such as ASUS RT-AC88U, to 
bootloop.

Until the driver is fixed, disable it.


Driver works and it useful for non-NAND devices. By disabling it you
regress those devices. Surely this can be handled better.


Disable NVMEM too as the bgmac_bcma driver will hang trying to retrieve 
the

MAC address without NVMEM_BRCM_NVRAM enabled.


This would be nice to fix instead hiding the bug.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH] bcm53xx: disable NVMEM driver

2023-08-01 Thread Arınç ÜNAL

I've attached the kernel log with NVMEM enabled and disabled for reference.

Arınç

On 1.08.2023 13:42, Arınç ÜNAL wrote:

The NVMEM_BRCM_NVRAM driver won't work properly with NVRAM in NAND. It
causes the devices with NVRAM in NAND, such as ASUS RT-AC88U, to bootloop.
Until the driver is fixed, disable it.

Disable NVMEM too as the bgmac_bcma driver will hang trying to retrieve the
MAC address without NVMEM_BRCM_NVRAM enabled.

Link: 
https://forum.openwrt.org/t/asus-rt-ac88u-hw-a6-broken-in-22-03-3/147882/40
Signed-off-by: Arınç ÜNAL 
---
  target/linux/bcm53xx/config-5.15 | 3 ---
  target/linux/bcm53xx/config-6.1  | 3 ---
  2 files changed, 6 deletions(-)

diff --git a/target/linux/bcm53xx/config-5.15 b/target/linux/bcm53xx/config-5.15
index 9cd1f079d1..6b7fa3c4ad 100644
--- a/target/linux/bcm53xx/config-5.15
+++ b/target/linux/bcm53xx/config-5.15
@@ -223,9 +223,6 @@ CONFIG_NET_FLOW_LIMIT=y
  CONFIG_NET_SELFTESTS=y
  CONFIG_NET_SWITCHDEV=y
  CONFIG_NR_CPUS=2
-CONFIG_NVMEM=y
-CONFIG_NVMEM_BRCM_NVRAM=y
-CONFIG_NVMEM_SYSFS=y
  CONFIG_OF=y
  CONFIG_OF_ADDRESS=y
  CONFIG_OF_EARLY_FLATTREE=y
diff --git a/target/linux/bcm53xx/config-6.1 b/target/linux/bcm53xx/config-6.1
index d96beb687d..c9d9dbd652 100644
--- a/target/linux/bcm53xx/config-6.1
+++ b/target/linux/bcm53xx/config-6.1
@@ -224,9 +224,6 @@ CONFIG_NET_FLOW_LIMIT=y
  CONFIG_NET_SELFTESTS=y
  CONFIG_NET_SWITCHDEV=y
  CONFIG_NR_CPUS=2
-CONFIG_NVMEM=y
-CONFIG_NVMEM_BRCM_NVRAM=y
-CONFIG_NVMEM_SYSFS=y
  CONFIG_OF=y
  CONFIG_OF_ADDRESS=y
  CONFIG_OF_EARLY_FLATTREE=y[0.00] Booting Linux on physical CPU 0x0
[0.00] Linux version 5.10.176 (arinc9@arinc9-PC) 
(arm-openwrt-linux-muslgnueabi-gcc (OpenWrt GCC 11.2.0 r20028-43d71ad93e) 
11.2.0, GNU ld (GNU Binutils) 2.37) #0 SMP Thu Apr 27 20:28:15 2023
[0.00] CPU: ARMv7 Processor [413fc090] revision 0 (ARMv7), cr=10c5387d
[0.00] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing 
instruction cache
[0.00] OF: fdt: Machine model: Asus RT-AC88U
[0.00] earlycon: ns16550 at MMIO 0x18000300 (options '115200n8')
[0.00] printk: bootconsole [ns16550] enabled
[0.00] Memory policy: Data cache writealloc
[0.00] Hit pending asynchronous external abort (FSR=0x1c06) during 
first unmask, this is most likely caused by a firmware/bootloader bug.
[0.00] Zone ranges:
[0.00]   Normal   [mem 0x-0x07ff]
[0.00]   HighMem  [mem 0x0800-0x9fff]
[0.00] Movable zone start for each node
[0.00] Early memory node ranges
[0.00]   node   0: [mem 0x-0x07ff]
[0.00]   node   0: [mem 0x8800-0x9fff]
[0.00] Initmem setup node 0 [mem 0x-0x9fff]
[0.00] On node 0 totalpages: 131072
[0.00]   Normal zone: 288 pages used for memmap
[0.00]   Normal zone: 0 pages reserved
[0.00]   Normal zone: 32768 pages, LIFO batch:7
[0.00]   HighMem zone: 98304 pages, LIFO batch:31
[0.00] percpu: Embedded 14 pages/cpu s27340 r8192 d21812 u57344
[0.00] pcpu-alloc: s27340 r8192 d21812 u57344 alloc=14*4096
[0.00] pcpu-alloc: [0] 0 [0] 1 
[0.00] Built 1 zonelists, mobility grouping on.  Total pages: 130784
[0.00] Kernel command line: earlycon
[0.00] Dentry cache hash table entries: 16384 (order: 4, 65536 bytes, 
linear)
[0.00] Inode-cache hash table entries: 8192 (order: 3, 32768 bytes, 
linear)
[0.00] mem auto-init: stack:off, heap alloc:off, heap free:off
[0.00] Memory: 509300K/524288K available (6000K kernel code, 562K 
rwdata, 1364K rodata, 1024K init, 286K bss, 14988K reserved, 0K cma-reserved, 
393216K highmem)
[0.00] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=2, Nodes=1
[0.00] rcu: Hierarchical RCU implementation.
[0.00]  Tracing variant of Tasks RCU enabled.
[0.00] rcu: RCU calculated value of scheduler-enlistment delay is 10 
jiffies.
[0.00] NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16
[0.00] L2C: DT/platform modifies aux control register: 0x0a13 -> 
0x3a53
[0.00] L2C-310 enabling early BRESP for Cortex-A9
[0.00] L2C-310 full line of zeros enabled for Cortex-A9
[0.00] L2C-310 ID prefetch enabled, offset 1 lines
[0.00] L2C-310 dynamic clock gating enabled, standby mode enabled
[0.00] L2C-310 cache controller enabled, 16 ways, 256 kB
[0.00] L2C-310: CACHE_ID 0x41c8, AUX_CTRL 0x7e530001
[0.09] sched_clock: 64 bits at 700MHz, resolution 1ns, wraps every 
4398046511103ns
[0.008072] clocksource: arm_global_timer: mask: 0x 
max_cycles: 0xa17102bcf3, max_idle_ns: 440795224838 ns
[0.019203] Switching to timer-based delay loop, resolution 1ns
[0.025361] Calibrating delay loop (skipped), value calculated using timer 
frequency.. 1400.00 BogoMIPS 

[PATCH] bcm53xx: disable NVMEM driver

2023-08-01 Thread Arınç ÜNAL
The NVMEM_BRCM_NVRAM driver won't work properly with NVRAM in NAND. It
causes the devices with NVRAM in NAND, such as ASUS RT-AC88U, to bootloop.
Until the driver is fixed, disable it.

Disable NVMEM too as the bgmac_bcma driver will hang trying to retrieve the
MAC address without NVMEM_BRCM_NVRAM enabled.

Link: 
https://forum.openwrt.org/t/asus-rt-ac88u-hw-a6-broken-in-22-03-3/147882/40
Signed-off-by: Arınç ÜNAL 
---
 target/linux/bcm53xx/config-5.15 | 3 ---
 target/linux/bcm53xx/config-6.1  | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/target/linux/bcm53xx/config-5.15 b/target/linux/bcm53xx/config-5.15
index 9cd1f079d1..6b7fa3c4ad 100644
--- a/target/linux/bcm53xx/config-5.15
+++ b/target/linux/bcm53xx/config-5.15
@@ -223,9 +223,6 @@ CONFIG_NET_FLOW_LIMIT=y
 CONFIG_NET_SELFTESTS=y
 CONFIG_NET_SWITCHDEV=y
 CONFIG_NR_CPUS=2
-CONFIG_NVMEM=y
-CONFIG_NVMEM_BRCM_NVRAM=y
-CONFIG_NVMEM_SYSFS=y
 CONFIG_OF=y
 CONFIG_OF_ADDRESS=y
 CONFIG_OF_EARLY_FLATTREE=y
diff --git a/target/linux/bcm53xx/config-6.1 b/target/linux/bcm53xx/config-6.1
index d96beb687d..c9d9dbd652 100644
--- a/target/linux/bcm53xx/config-6.1
+++ b/target/linux/bcm53xx/config-6.1
@@ -224,9 +224,6 @@ CONFIG_NET_FLOW_LIMIT=y
 CONFIG_NET_SELFTESTS=y
 CONFIG_NET_SWITCHDEV=y
 CONFIG_NR_CPUS=2
-CONFIG_NVMEM=y
-CONFIG_NVMEM_BRCM_NVRAM=y
-CONFIG_NVMEM_SYSFS=y
 CONFIG_OF=y
 CONFIG_OF_ADDRESS=y
 CONFIG_OF_EARLY_FLATTREE=y
-- 
2.39.2


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel