Re: [PATCH] kernel: set CONFIG_RCU_FANOUT=64 for 64bit targets

2021-08-01 Thread Rui Salvaterra 
Hi, Stijn,

On Sat, 31 Jul 2021 at 11:01, Stijn Tintel  wrote:
>
> Alternatively we could disable CONFIG_RCU_EXPERT entirely. Not sure why
> it was enabled in the first place. If anyone knows, please do share.

Yes, please! Personal note, CONFIG_RCU_EXPERT is one of those things I
don't even touch. The (performance) breakage potential is big and I
really trust the defaults are sane. Just disable it.

Thanks,
Rui

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] kernel: set CONFIG_RCU_FANOUT=64 for 64bit targets

2021-07-31 Thread Stijn Tintel 

On 30/07/2021 20:56, Stijn Tintel wrote:

The generic config has CONFIG_RCU_EXPERT=y, which exposes
CONFIG_RCU_FANOUT. This is set to 32 in the generic config, but the
default for 64bit kernels is 64. This causes a warning during boot:

[0.00] rcu: CONFIG_RCU_FANOUT set to non-default value of 32.

Set CONFIG_RCU_FANOUT=64 in kernel configs of 64bit targets, unless the
target config has disabled CONFIG_RCU_EXPERT.


Alternatively we could disable CONFIG_RCU_EXPERT entirely. Not sure why 
it was enabled in the first place. If anyone knows, please do share.


Stijn


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[PATCH] kernel: set CONFIG_RCU_FANOUT=64 for 64bit targets

2021-07-30 Thread Stijn Tintel 
The generic config has CONFIG_RCU_EXPERT=y, which exposes
CONFIG_RCU_FANOUT. This is set to 32 in the generic config, but the
default for 64bit kernels is 64. This causes a warning during boot:

[0.00] rcu: CONFIG_RCU_FANOUT set to non-default value of 32.

Set CONFIG_RCU_FANOUT=64 in kernel configs of 64bit targets, unless the
target config has disabled CONFIG_RCU_EXPERT.

Signed-off-by: Stijn Tintel 
---
 target/linux/armvirt/64/config-5.10  | 1 +
 target/linux/armvirt/64/config-5.4   | 1 +
 target/linux/bcm27xx/bcm2710/config-5.4  | 1 +
 target/linux/bcm27xx/bcm2711/config-5.4  | 1 +
 target/linux/bcm4908/config-5.4  | 1 +
 target/linux/malta/be64/config-default   | 1 +
 target/linux/malta/le64/config-default   | 1 +
 target/linux/mediatek/mt7622/config-5.10 | 1 +
 target/linux/mvebu/cortexa53/config-5.10 | 1 +
 target/linux/mvebu/cortexa53/config-5.4  | 1 +
 target/linux/mvebu/cortexa72/config-5.10 | 1 +
 target/linux/mvebu/cortexa72/config-5.4  | 1 +
 target/linux/octeon/config-5.10  | 1 +
 target/linux/octeon/config-5.4   | 1 +
 target/linux/octeontx/config-5.4 | 1 +
 target/linux/sunxi/cortexa53/config-5.4  | 1 +
 target/linux/uml/config/x86_64   | 1 +
 target/linux/x86/64/config-5.10  | 1 +
 target/linux/x86/64/config-5.4   | 1 +
 19 files changed, 19 insertions(+)

diff --git a/target/linux/armvirt/64/config-5.10 
b/target/linux/armvirt/64/config-5.10
index 51f3c3c952..7cd542fc81 100644
--- a/target/linux/armvirt/64/config-5.10
+++ b/target/linux/armvirt/64/config-5.10
@@ -130,6 +130,7 @@ CONFIG_POWER_RESET_VEXPRESS=y
 CONFIG_POWER_SUPPLY=y
 CONFIG_QUEUED_RWLOCKS=y
 CONFIG_QUEUED_SPINLOCKS=y
+CONFIG_RCU_FANOUT=64
 CONFIG_REGMAP=y
 CONFIG_REGMAP_MMIO=y
 CONFIG_RODATA_FULL_DEFAULT_ENABLED=y
diff --git a/target/linux/armvirt/64/config-5.4 
b/target/linux/armvirt/64/config-5.4
index 2317dcd39d..464c7bfaa3 100644
--- a/target/linux/armvirt/64/config-5.4
+++ b/target/linux/armvirt/64/config-5.4
@@ -134,6 +134,7 @@ CONFIG_POWER_RESET_VEXPRESS=y
 CONFIG_POWER_SUPPLY=y
 CONFIG_QUEUED_RWLOCKS=y
 CONFIG_QUEUED_SPINLOCKS=y
+CONFIG_RCU_FANOUT=64
 CONFIG_REGMAP=y
 CONFIG_REGMAP_MMIO=y
 CONFIG_RODATA_FULL_DEFAULT_ENABLED=y
diff --git a/target/linux/bcm27xx/bcm2710/config-5.4 
b/target/linux/bcm27xx/bcm2710/config-5.4
index 27884a0567..b0718a5f8d 100644
--- a/target/linux/bcm27xx/bcm2710/config-5.4
+++ b/target/linux/bcm27xx/bcm2710/config-5.4
@@ -364,6 +364,7 @@ CONFIG_RASPBERRYPI_POWER=y
 CONFIG_RATIONAL=y
 # CONFIG_RAVE_SP_CORE is not set
 CONFIG_RAW_DRIVER=y
+CONFIG_RCU_FANOUT=64
 CONFIG_RCU_NEED_SEGCBLIST=y
 CONFIG_RCU_STALL_COMMON=y
 CONFIG_REFCOUNT_FULL=y
diff --git a/target/linux/bcm27xx/bcm2711/config-5.4 
b/target/linux/bcm27xx/bcm2711/config-5.4
index c82ae44942..40af97965f 100644
--- a/target/linux/bcm27xx/bcm2711/config-5.4
+++ b/target/linux/bcm27xx/bcm2711/config-5.4
@@ -376,6 +376,7 @@ CONFIG_RASPBERRYPI_POWER=y
 CONFIG_RATIONAL=y
 # CONFIG_RAVE_SP_CORE is not set
 CONFIG_RAW_DRIVER=y
+CONFIG_RCU_FANOUT=64
 CONFIG_RCU_NEED_SEGCBLIST=y
 CONFIG_RCU_STALL_COMMON=y
 CONFIG_REFCOUNT_FULL=y
diff --git a/target/linux/bcm4908/config-5.4 b/target/linux/bcm4908/config-5.4
index 6f43a822c8..9076ae8cc2 100644
--- a/target/linux/bcm4908/config-5.4
+++ b/target/linux/bcm4908/config-5.4
@@ -183,6 +183,7 @@ CONFIG_POWER_SUPPLY=y
 CONFIG_QUEUED_RWLOCKS=y
 CONFIG_QUEUED_SPINLOCKS=y
 CONFIG_RATIONAL=y
+CONFIG_RCU_FANOUT=64
 CONFIG_RCU_NEED_SEGCBLIST=y
 CONFIG_RCU_STALL_COMMON=y
 CONFIG_REFCOUNT_FULL=y
diff --git a/target/linux/malta/be64/config-default 
b/target/linux/malta/be64/config-default
index ef044bb8ca..7d22120c14 100644
--- a/target/linux/malta/be64/config-default
+++ b/target/linux/malta/be64/config-default
@@ -7,3 +7,4 @@ CONFIG_CPU_MIPS64_R2=y
 # CONFIG_MIPS32_N32 is not set
 # CONFIG_MIPS32_O32 is not set
 # CONFIG_MIPS_VA_BITS_48 is not set
+CONFIG_RCU_FANOUT=64
diff --git a/target/linux/malta/le64/config-default 
b/target/linux/malta/le64/config-default
index 69e5387a1f..72ed33365f 100644
--- a/target/linux/malta/le64/config-default
+++ b/target/linux/malta/le64/config-default
@@ -6,3 +6,4 @@ CONFIG_CPU_MIPS64_R2=y
 # CONFIG_MIPS32_N32 is not set
 # CONFIG_MIPS32_O32 is not set
 # CONFIG_MIPS_VA_BITS_48 is not set
+CONFIG_RCU_FANOUT=64
diff --git a/target/linux/mediatek/mt7622/config-5.10 
b/target/linux/mediatek/mt7622/config-5.10
index caf0293f41..9d039212b0 100644
--- a/target/linux/mediatek/mt7622/config-5.10
+++ b/target/linux/mediatek/mt7622/config-5.10
@@ -368,6 +368,7 @@ CONFIG_QUEUED_SPINLOCKS=y
 CONFIG_RAS=y
 CONFIG_RATIONAL=y
 # CONFIG_RAVE_SP_CORE is not set
+CONFIG_RCU_FANOUT=64
 CONFIG_RCU_NEED_SEGCBLIST=y
 CONFIG_RCU_STALL_COMMON=y
 CONFIG_REALTEK_PHY=y
diff --git a/target/linux/mvebu/cortexa53/config-5.10 
b/target/linux/mvebu/cortexa53/config-5.10
index 24f26474bc..6b343d4658 100644
--- a/target/linux/mvebu/cortexa53/config-5.10
+++ b/target/linux/mvebu/cortexa53/config-5.10
@@ -66,6 +66,7 @@