Re: [PATCH v2] options.c: add DSCP code LE Least Effort

2022-01-08 Thread Rui Salvaterra
Hi, Kevin,

On Sat, 8 Jan 2022 at 23:45, Kevin Darbyshire-Bryant via openwrt-devel
 wrote:
>
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
>
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.
>
>
> -- Forwarded message --
> From: Kevin Darbyshire-Bryant 
> To: openwrt-devel@lists.openwrt.org
> Cc: Kevin Darbyshire-Bryant 
> Bcc:
> Date: Sat,  8 Jan 2022 23:42:27 +0000
> Subject: [PATCH v2] options.c: add DSCP code LE Least Effort
> RFC-8622 implements a low priority DSCP marking called 'Least Effort' or
> 'LE'  Instead of prioritising traffic in varying degrees, this defines a
> scum class of packet that really is the lowest of the low and you may
> consider forwarding if you really have nothing better to do.
>
> This patch adds LE class support to firewall3.
>
> Signed-off-by: Kevin Darbyshire-Bryant 
> ---
>  options.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/options.c b/options.c
> index 6131786..2f419a3 100644
> --- a/options.c
> +++ b/options.c
> @@ -146,6 +146,7 @@ static const struct { const char *name; uint8_t dscp; } 
> dscp_classes[] = {
> { "CS6",  0x30 },
> { "CS7",  0x38 },
> { "BE",   0x00 },
> +   { "LE",   0x01 },
> { "AF11", 0x0a },
> { "AF12", 0x0c },
> { "AF13", 0x0e },
> --
> 2.32.0 (Apple Git-132)
>

Seems sensible to me. Nice description, and bonus points for the RFC
reference. :)

Reviewed-by: Rui Salvaterra 

Thanks,
Rui

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[PATCH v2] options.c: add DSCP code LE Least Effort

2022-01-08 Thread Kevin Darbyshire-Bryant via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
RFC-8622 implements a low priority DSCP marking called 'Least Effort' or
'LE'  Instead of prioritising traffic in varying degrees, this defines a
scum class of packet that really is the lowest of the low and you may
consider forwarding if you really have nothing better to do.

This patch adds LE class support to firewall3.

Signed-off-by: Kevin Darbyshire-Bryant 
---
 options.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/options.c b/options.c
index 6131786..2f419a3 100644
--- a/options.c
+++ b/options.c
@@ -146,6 +146,7 @@ static const struct { const char *name; uint8_t dscp; } 
dscp_classes[] = {
{ "CS6",  0x30 },
{ "CS7",  0x38 },
{ "BE",   0x00 },
+   { "LE",   0x01 },
{ "AF11", 0x0a },
{ "AF12", 0x0c },
{ "AF13", 0x0e },
-- 
2.32.0 (Apple Git-132)


--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel