RE: [PATCH] rockchip: use stable MAC-address for NanoPi R2S

2021-01-17 Thread Karl Palsson

"Adrian Schmutzler"  wrote:
> > +   local mac_base=$(macaddr_canonicalize "$(echo "${sd_hash}" | dd
> > bs=1 count=12 2>/dev/null)")
> 
> bs=12 count=1 ?


Why? unless you're passing other flags to try and magically avoid
the block layer, you're only operating on a 1k block read out
anyway. This sort of suggestion is pointless noise that just
makes things harder to read.

Sincerely,
Karl Palsson

OpenPGP-digital-signature.html
Description: OpenPGP Digital Signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


RE: [PATCH] rockchip: use stable MAC-address for NanoPi R2S

2021-01-16 Thread Adrian Schmutzler
> + local mac_base=$(macaddr_canonicalize "$(echo "${sd_hash}" | dd
> bs=1 count=12 2>/dev/null)")

bs=12 count=1 ?

Best

Adrian 


openpgp-digital-signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel