Re: [OpenWrt-Devel] [PATCH] ramips: fix device-trees for AsiaRF awm002/3 evb
On 17/09/2014 09:24, Russell Senior wrote: It also enables GPIO control of the second GPIO controller, in rt5350.dtsi, but does not use it. that is why it is not enabled by default :) please resend without the change to rt5350.dtsi John ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips: fix device-trees for AsiaRF awm002/3 evb
On 17/09/2014 09:24, Russell Senior wrote:
diff --git a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
index c997e35..891dd96 100644
--- a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
+++ b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
@@ -97,6 +97,7 @@ static struct bh_map button_map[] = {
BH_MAP(KEY_RFKILL, rfkill),
BH_MAP(KEY_WPS_BUTTON, wps),
BH_MAP(KEY_WIMAX, wwan),
+ BH_MAP(BTN_MODE,mode),
};
This needs to be sent in a separate patch as it touches a different
module. missed that ion my first review
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips: fix device-trees for AsiaRF awm002/3 evb
On 17/09/2014 09:39, John Crispin wrote:
On 17/09/2014 09:24, Russell Senior wrote:
diff --git a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
index c997e35..891dd96 100644
--- a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
+++ b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
@@ -97,6 +97,7 @@ static struct bh_map button_map[] = {
BH_MAP(KEY_RFKILL, rfkill),
BH_MAP(KEY_WPS_BUTTON, wps),
BH_MAP(KEY_WIMAX, wwan),
+BH_MAP(BTN_MODE,mode),
};
This needs to be sent in a separate patch as it touches a different
module. missed that ion my first review
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips: fix device-trees for AsiaRF awm002/3 evb
John == John Crispin blo...@openwrt.org writes: John On 17/09/2014 09:24, Russell Senior wrote: It also enables GPIO control of the second GPIO controller, in rt5350.dtsi, but does not use it. John that is why it is not enabled by default :) It could be used, which I did while testing. I don't understand the logic of disabling the second gpio controller for everyone that includes rt5350.dtsi. I don't understand the harm. Can you elaborate please? -- Russell Senior, President russ...@personaltelco.net ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips: fix device-trees for AsiaRF awm002/3 evb
narf ... fat fingered it ... sorry you need to send a v3
/me gets coffee
On 17/09/2014 09:42, John Crispin wrote:
On 17/09/2014 09:39, John Crispin wrote:
On 17/09/2014 09:24, Russell Senior wrote:
diff --git
a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
index c997e35..891dd96 100644 ---
a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
+++
b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
@@ -97,6 +97,7 @@ static struct bh_map button_map[] = {
BH_MAP(KEY_RFKILL, rfkill), BH_MAP(KEY_WPS_BUTTON, wps),
BH_MAP(KEY_WIMAX, wwan), + BH_MAP(BTN_MODE,mode), };
This needs to be sent in a separate patch as it touches a
different module. missed that ion my first review
___ openwrt-devel
mailing list openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___ openwrt-devel
mailing list openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips: fix device-trees for AsiaRF awm002/3 evb
On 17/09/2014 09:42, Russell Senior wrote: John == John Crispin blo...@openwrt.org writes: John On 17/09/2014 09:24, Russell Senior wrote: It also enables GPIO control of the second GPIO controller, in rt5350.dtsi, but does not use it. John that is why it is not enabled by default :) It could be used, which I did while testing. I don't understand the logic of disabling the second gpio controller for everyone that includes rt5350.dtsi. I don't understand the harm. Can you elaborate please? if a router uses the 2nd gpio core it can enable it inside its own dts file. if the gpio core is not used then it does not need to be enabled. its like loading a wifi driver for a wifi card that does not get used. it will just eat up memory and power. we could argue whether it makes sense or not i guess, maybe a matter of personal taste .. for the sake of consistency i would like to keep it this way. John ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
