Re: [PATCH] mvebu/cortexa53: add targz rootfs feature

2020-12-14 Thread Paul Spooren




On Mo, Dez 14, 2020 at 21:22, Daniel Golle  
wrote:

On Mon, Dec 14, 2020 at 10:10:32PM +0100, Josef Schlehofer wrote:


 On 14. 12. 20 21:59, Paul Spooren wrote:
 > The rootfs is required to create rootfs Docker containers. With 
this
 > feature enable a new runtime test can happen for the 
aarch64_cortex-a53

 > architecture.
 >
 > CC: Josef Schlehofer 
 > Signed-off-by: Paul Spooren 
 Acked-by: Josef Schlehofer 


Erm, NACK. Why add this to a random target? Wouldn't it be smarter to
use the rootfs of armvirt/32 instead?


Good point, I prefer the change of armvirt/64[1] instead of adding 
mvebu.


[1]: 
https://patchwork.ozlabs.org/project/openwrt/patch/20201213140237.3137718-1-pepe.schleho...@gmail.com/





 > ---
 >  target/linux/mvebu/cortexa53/target.mk | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)
 >
 > diff --git a/target/linux/mvebu/cortexa53/target.mk 
b/target/linux/mvebu/cortexa53/target.mk

 > index fe89d08ffa..10080c0b8f 100644
 > --- a/target/linux/mvebu/cortexa53/target.mk
 > +++ b/target/linux/mvebu/cortexa53/target.mk
 > @@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk
 >  ARCH:=aarch64
 >  BOARDNAME:=Marvell Armada 3700LP (ARM64)
 >  CPU_TYPE:=cortex-a53
 > -FEATURES+=ext4
 > +FEATURES+=ext4 targz
 >  DEFAULT_PACKAGES+=e2fsprogs ethtool mkf2fs partx-utils
 >
 >  KERNELNAME:=Image dtbs






 ___
 openwrt-devel mailing list
 openwrt-devel@lists.openwrt.org
 https://lists.openwrt.org/mailman/listinfo/openwrt-devel






___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH] mvebu/cortexa53: add targz rootfs feature

2020-12-14 Thread Daniel Golle
On Mon, Dec 14, 2020 at 10:10:32PM +0100, Josef Schlehofer wrote:
> 
> On 14. 12. 20 21:59, Paul Spooren wrote:
> > The rootfs is required to create rootfs Docker containers. With this
> > feature enable a new runtime test can happen for the aarch64_cortex-a53
> > architecture.
> >
> > CC: Josef Schlehofer 
> > Signed-off-by: Paul Spooren 
> Acked-by: Josef Schlehofer 

Erm, NACK. Why add this to a random target? Wouldn't it be smarter to
use the rootfs of armvirt/32 instead?

> > ---
> >  target/linux/mvebu/cortexa53/target.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/target/linux/mvebu/cortexa53/target.mk 
> > b/target/linux/mvebu/cortexa53/target.mk
> > index fe89d08ffa..10080c0b8f 100644
> > --- a/target/linux/mvebu/cortexa53/target.mk
> > +++ b/target/linux/mvebu/cortexa53/target.mk
> > @@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk
> >  ARCH:=aarch64
> >  BOARDNAME:=Marvell Armada 3700LP (ARM64)
> >  CPU_TYPE:=cortex-a53
> > -FEATURES+=ext4
> > +FEATURES+=ext4 targz
> >  DEFAULT_PACKAGES+=e2fsprogs ethtool mkf2fs partx-utils
> >  
> >  KERNELNAME:=Image dtbs
> 



> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH] mvebu/cortexa53: add targz rootfs feature

2020-12-14 Thread Josef Schlehofer

On 14. 12. 20 21:59, Paul Spooren wrote:
> The rootfs is required to create rootfs Docker containers. With this
> feature enable a new runtime test can happen for the aarch64_cortex-a53
> architecture.
>
> CC: Josef Schlehofer 
> Signed-off-by: Paul Spooren 
Acked-by: Josef Schlehofer 
> ---
>  target/linux/mvebu/cortexa53/target.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/linux/mvebu/cortexa53/target.mk 
> b/target/linux/mvebu/cortexa53/target.mk
> index fe89d08ffa..10080c0b8f 100644
> --- a/target/linux/mvebu/cortexa53/target.mk
> +++ b/target/linux/mvebu/cortexa53/target.mk
> @@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk
>  ARCH:=aarch64
>  BOARDNAME:=Marvell Armada 3700LP (ARM64)
>  CPU_TYPE:=cortex-a53
> -FEATURES+=ext4
> +FEATURES+=ext4 targz
>  DEFAULT_PACKAGES+=e2fsprogs ethtool mkf2fs partx-utils
>  
>  KERNELNAME:=Image dtbs



smime.p7s
Description: S/MIME Cryptographic Signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel