Re: [PATCH v2] uqmi: wms - added storage to read text messages
On Wed, Apr 13, 2022 at 10:35 AM Henrik Ginstmark wrote: > Den tis 15 mars 2022 kl 21:14 skrev Sergey Ryazanov : >> On Tue, Mar 15, 2022 at 10:36 PM Henrik Ginstmark >> wrote: >>> Today it's hard coded to read text messages from SIM card. >>> Not all devices store received text messages in SIM, they store >>> in me, QMI_WMS_STORAGE_TYPE_NV. >>> I have added --storage as an argumet available to >>> --list-messages >>> --get-message >>> --delete-message >>> --get-raw-message >>> >>> If --storage is omitted default storage is sim, as before. >>> >>> Signed-off-by: Henrik Ginstmark >> >> Looks good! >> >> Reviewed-by: Sergey Ryazanov > > Hi > What will be the next step? Any testing needed? Patch is good, next step should be applying, but possibly core devs just overlook it. Daniel, do you have any objections with applying this change? -- Sergey ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v2] uqmi: wms - added storage to read text messages
Den tis 15 mars 2022 kl 21:14 skrev Sergey Ryazanov : > > On Tue, Mar 15, 2022 at 10:36 PM Henrik Ginstmark wrote: > > Today it's hard coded to read text messages from SIM card. > > Not all devices store received text messages in SIM, they store > > in me, QMI_WMS_STORAGE_TYPE_NV. > > I have added --storage as an argumet available to > > --list-messages > > --get-message > > --delete-message > > --get-raw-message > > > > If --storage is omitted default storage is sim, as before. > > > > Signed-off-by: Henrik Ginstmark > > Looks good! > > Reviewed-by: Sergey Ryazanov Hi What will be the next step? Any testing needed? BR Henrik ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v2] uqmi: wms - added storage to read text messages
On Tue, Mar 15, 2022 at 10:36 PM Henrik Ginstmark wrote: > Today it's hard coded to read text messages from SIM card. > Not all devices store received text messages in SIM, they store > in me, QMI_WMS_STORAGE_TYPE_NV. > I have added --storage as an argumet available to > --list-messages > --get-message > --delete-message > --get-raw-message > > If --storage is omitted default storage is sim, as before. > > Signed-off-by: Henrik Ginstmark Looks good! Reviewed-by: Sergey Ryazanov ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
