Re: [orientdb] OSQLFunctionMax.java or OSQLFunctionMin.java

2016-12-19 Thread Luigi Dell'Aquila
Hi,

It's very similar, but not actually the same ;-)

One has

else if (context.compareTo(value) < 0)

The other one has

else if (context.compareTo(value) > 0)

(see the greater-than vs. less-than)
The //BIGGER comment in one case is wrong of course.

I'm looking at the source code  in 2.2.x branch, please let me know if I'm
missing something on another specific branch

Thanks

Luigi


2016-12-18 14:46 GMT+01:00 :

> Hi,
> I attached image for code.
> I have a question about mergeDistributedResult() method in
> OSQLFunctionMax.java or OSQLFunctionMin.java.
>  if (context == null)
> // FIRST TIME
> *context = value;*
>  else if (context.compareTo(value) < 0)
> // BIGGER
> *context = value;*
> Why these two cases had same code?
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "OrientDB" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to orient-database+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"OrientDB" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to orient-database+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[orientdb] OSQLFunctionMax.java or OSQLFunctionMin.java

2016-12-18 Thread jeongeun . lee5
Hi,
I attached image for code.
I have a question about mergeDistributedResult() method in 
OSQLFunctionMax.java or OSQLFunctionMin.java.
 if (context == null) 
// FIRST TIME 
*context = value;* 
 else if (context.compareTo(value) < 0) 
// BIGGER 
*context = value;* 
Why these two cases had same code?

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"OrientDB" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to orient-database+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.