Re: [osg-users] [build] OpenThreads/Version and osg/Version

2014-11-29 Thread Christian Ruzicka 
Hi,

Thanks Roberts! This makes the handling of our internal OSG repository easier.

Cheers,
Christian

--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=61919#61919





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

[osg-users] [build] OpenThreads/Version and osg/Version

2014-11-28 Thread Christian Ruzicka 
Hi,

I have a question regarding OpenThreads/Version and osg/Version files: Instead 
of being generated by cmake into the ${PROJECT_BINARY_DIR} they are generated 
into the source directory (${CMAKE_CURRENT_SOURCE_DIR}). Doesn't this break out 
of source build? In addition those generated files are checked into the version 
control system.

Compare Config and GL header being generated into the build directory and the 
version file into the source directory (main CMakeList.txt file):

SET(OPENSCENEGRAPH_CONFIG_HEADER ${PROJECT_BINARY_DIR}/include/osg/Config)
CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/src/osg/Config.in
${OPENSCENEGRAPH_CONFIG_HEADER})
SET(OPENSCENEGRAPH_OPENGL_HEADER ${PROJECT_BINARY_DIR}/include/osg/GL)
CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/src/osg/GL.in
${OPENSCENEGRAPH_OPENGL_HEADER})
# INSTALL_FILES(/include/osg/ FILES ${OPENSCENEGRAPH_CONFIG_HEADER})

# Set Vertsion header file
SET(OPENSCENEGRAPH_VERSION_HEADER 
${CMAKE_CURRENT_SOURCE_DIR}/include/osg/Version)
CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/src/osg/Version.in
${OPENSCENEGRAPH_VERSION_HEADER})

Is there a special reason or was it done by mistake?

Thank you!

Cheers,
Christian

--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=61908#61908





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] [build] OpenThreads/Version and osg/Version

2014-11-28 Thread Robert Osfield 
HI Christian,

I'm not the original author of this particular part of the CMake scripts so
can't give an immediate answer.  Provisionally I would say that there is no
reason why the Version header that is automatically generated so not be
treated like the GL and Config headers.  I will amend it to be consistent
and see if the in source and out of source builds work fine.

Robert.

On 28 November 2014 at 14:16, Christian Ruzicka c.ruzi...@gmx.de wrote:

 Hi,

 I have a question regarding OpenThreads/Version and osg/Version files:
 Instead of being generated by cmake into the ${PROJECT_BINARY_DIR} they are
 generated into the source directory (${CMAKE_CURRENT_SOURCE_DIR}). Doesn't
 this break out of source build? In addition those generated files are
 checked into the version control system.

 Compare Config and GL header being generated into the build directory and
 the version file into the source directory (main CMakeList.txt file):

 SET(OPENSCENEGRAPH_CONFIG_HEADER
 ${PROJECT_BINARY_DIR}/include/osg/Config)
 CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/src/osg/Config.in
 ${OPENSCENEGRAPH_CONFIG_HEADER})
 SET(OPENSCENEGRAPH_OPENGL_HEADER ${PROJECT_BINARY_DIR}/include/osg/GL)
 CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/src/osg/GL.in
 ${OPENSCENEGRAPH_OPENGL_HEADER})
 # INSTALL_FILES(/include/osg/ FILES ${OPENSCENEGRAPH_CONFIG_HEADER})

 
 # Set Vertsion header file
 SET(OPENSCENEGRAPH_VERSION_HEADER
 ${CMAKE_CURRENT_SOURCE_DIR}/include/osg/Version)
 CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/src/osg/Version.in
 ${OPENSCENEGRAPH_VERSION_HEADER})

 Is there a special reason or was it done by mistake?

 Thank you!

 Cheers,
 Christian

 --
 Read this topic online here:
 http://forum.openscenegraph.org/viewtopic.php?p=61908#61908





 ___
 osg-users mailing list
 osg-users@lists.openscenegraph.org
 http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] [build] OpenThreads/Version and osg/Version

2014-11-28 Thread Robert Osfield 
On 28 November 2014 at 15:01, Robert Osfield robert.osfi...@gmail.com
wrote:

 HI Christian,

 I'm not the original author of this particular part of the CMake scripts
 so can't give an immediate answer.  Provisionally I would say that there is
 no reason why the Version header that is automatically generated so not be
 treated like the GL and Config headers.  I will amend it to be consistent
 and see if the in source and out of source builds work fine.


This works fine so I've gone ahead and merged these changes with svn/trunk.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org