Re: [osg-users] Is there a reason a why different scene statistics are collected in Renderer::cull and Renderer::cull_draw paths

2011-07-26 Thread Roger James

robertosfield wrote:
 I fixed the bug by consolodating the collection of the SceneView
 related stats into a single function and have the cull() and
 cull_draw() methods call this.  I have checked this fix into svn/trunk
 and the OSG-3.0 branch.
 
 Could you please test it out?
 
 Thanks,
 Robert.
 
Robert
Thanks for the quick response. I will test the trunk build overnight tonight.

Roger

--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=41628#41628





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


[osg-users] Is there a reason a why different scene statistics are collected in Renderer::cull and Renderer::cull_draw paths

2011-07-25 Thread Roger James
Hi,

I have noticed that different scene statistics are collected in threading 
models where Renderer::cull_draw is called rather than Renderer::cull. In 
particular the number of fast drawables and none of the primitive set 
statistics are collected in cull_draw mode. Is there any reason for this. I 
just spent a while wondering where all my fast path drawables had disappeared 
to!

Cheers,
Roger

--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=41611#41611





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Is there a reason a why different scene statistics are collected in Renderer::cull and Renderer::cull_draw paths

2011-07-25 Thread Robert Osfield
Hi Roger,

On Mon, Jul 25, 2011 at 4:59 PM, Roger James
ro...@beardandsandals.co.uk wrote:
 I have noticed that different scene statistics are collected in threading 
 models where Renderer::cull_draw is called rather than Renderer::cull. In 
 particular the number of fast drawables and none of the primitive set 
 statistics are collected in cull_draw mode. Is there any reason for this. I 
 just spent a while wondering where all my fast path drawables had disappeared 
 to!

It's a bug!! :-)

I hadn't spotted this before, this must have been missed by the author
of the this particular bit of code, and not spotted by me on review
when merging it.

I will go have a look at the code behind the stats and see if I can
spot the bug.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Is there a reason a why different scene statistics are collected in Renderer::cull and Renderer::cull_draw paths

2011-07-25 Thread Robert Osfield
Hi Roger,

On Mon, Jul 25, 2011 at 5:39 PM, Robert Osfield
robert.osfi...@gmail.com wrote:
 I will go have a look at the code behind the stats and see if I can
 spot the bug.

I fixed the bug by consolodating the collection of the SceneView
related stats into a single function and have the cull() and
cull_draw() methods call this.  I have checked this fix into svn/trunk
and the OSG-3.0 branch.

Could you please test it out?

Thanks,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org