[osg-users] MSVC9 CMake bug in src/CMakeLists.txt ?

2008-07-21 Thread Philip Lowman
I was looking for something else and came across this in src/CMakeLists.txt
and it looked a little odd.  I thought I would ask the question if this was
meant to apply to VS9 as well?  If so, MSVC_VERSION should probably be used
here.

IF(MSVC80)
  OPTION(OSG_MSVC_GENERATE_PLUGINS_AND_WRAPPERS_MANIFESTS Generate or not
manifests files under VS8 for dynamically loaded dlls ON)
ENDIF(MSVC80)

-- 
Philip Lowman
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] MSVC9 CMake bug in src/CMakeLists.txt ?

2008-07-21 Thread Serge Lages
Hi Philip,

I added this option some time ago, and VS9 wasn't still available. So feel
free to update it and add VS9. As a side note, is it possible to make a
condition like all VS versions superiors to 8 ?

On Mon, Jul 21, 2008 at 1:31 PM, Philip Lowman [EMAIL PROTECTED] wrote:

 I was looking for something else and came across this in src/CMakeLists.txt
 and it looked a little odd.  I thought I would ask the question if this was
 meant to apply to VS9 as well?  If so, MSVC_VERSION should probably be used
 here.

 IF(MSVC80)
   OPTION(OSG_MSVC_GENERATE_PLUGINS_AND_WRAPPERS_MANIFESTS Generate or not
 manifests files under VS8 for dynamically loaded dlls ON)
 ENDIF(MSVC80)

 --
 Philip Lowman

 ___
 osg-users mailing list
 osg-users@lists.openscenegraph.org
 http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org




-- 
Serge Lages
http://www.tharsis-software.com
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] MSVC9 CMake bug in src/CMakeLists.txt ?

2008-07-21 Thread Serge Lages
Erf I did not read your mail carefully, using MSVC_VERSION seems to be the
right thing to do yes.

On Mon, Jul 21, 2008 at 1:45 PM, Serge Lages [EMAIL PROTECTED] wrote:

 Hi Philip,

 I added this option some time ago, and VS9 wasn't still available. So feel
 free to update it and add VS9. As a side note, is it possible to make a
 condition like all VS versions superiors to 8 ?

 On Mon, Jul 21, 2008 at 1:31 PM, Philip Lowman [EMAIL PROTECTED] wrote:

 I was looking for something else and came across this in
 src/CMakeLists.txt and it looked a little odd.  I thought I would ask the
 question if this was meant to apply to VS9 as well?  If so, MSVC_VERSION
 should probably be used here.

 IF(MSVC80)
   OPTION(OSG_MSVC_GENERATE_PLUGINS_AND_WRAPPERS_MANIFESTS Generate or not
 manifests files under VS8 for dynamically loaded dlls ON)
 ENDIF(MSVC80)

 --
 Philip Lowman

 ___
 osg-users mailing list
 osg-users@lists.openscenegraph.org
 http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org




 --
 Serge Lages
 http://www.tharsis-software.com




-- 
Serge Lages
http://www.tharsis-software.com
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] MSVC9 CMake bug in src/CMakeLists.txt ?

2008-07-21 Thread Philip Lowman
On Mon, Jul 21, 2008 at 7:45 AM, Serge Lages [EMAIL PROTECTED] wrote:

 Hi Philip,

 I added this option some time ago, and VS9 wasn't still available. So feel
 free to update it and add VS9. As a side note, is it possible to make a
 condition like all VS versions superiors to 8 ?

 On Mon, Jul 21, 2008 at 1:31 PM, Philip Lowman [EMAIL PROTECTED] wrote:

 I was looking for something else and came across this in
 src/CMakeLists.txt and it looked a little odd.  I thought I would ask the
 question if this was meant to apply to VS9 as well?  If so, MSVC_VERSION
 should probably be used here.

 IF(MSVC80)
   OPTION(OSG_MSVC_GENERATE_PLUGINS_AND_WRAPPERS_MANIFESTS Generate or not
 manifests files under VS8 for dynamically loaded dlls ON)
 ENDIF(MSVC80)


I think this might work although I can't test (either if this conditional
will work or if manifest generation on MSVC9 will work properly)

IF(MSVC_VERSION EQUAL 1400 OR
MSVC_VERSION GREATER 1400)
   # do stuff

http://predef.sourceforge.net/precomp.html#sec32

-- 
Philip Lowman
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org