Re: [osg-users] Odd debug statement in Program.cpp
Hi Doug, On Fri, May 8, 2009 at 4:39 PM, Doug McCorkle wrote: > Ahh. So in 2.6.1 and 2.8.1 there may still be issues when copying an > osg::Program? You should consider the copy constructor no go in all OSG versions prior to the 2.9.x series. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Odd debug statement in Program.cpp
Hello Robert, On May 8, 2009, at 3:44 AM, Robert Osfield wrote: Hi Doug, I'm not the author of this code so can't comment on it's original motivation, but mostly like it was about the copy constructor not being completely filled out/questions over management of OpenGL objects during copy. OK. What I can say is that in svn/trunk and 2.9.x the copy constructor has been completed and the message removed as the copy constructor should now be valid. Ahh. So in 2.6.1 and 2.8.1 there may still be issues when copying an osg::Program? Doug ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Odd debug statement in Program.cpp
Hi Doug, I'm not the author of this code so can't comment on it's original motivation, but mostly like it was about the copy constructor not being completely filled out/questions over management of OpenGL objects during copy. What I can say is that in svn/trunk and 2.9.x the copy constructor has been completed and the message removed as the copy constructor should now be valid. Robert. On Thu, May 7, 2009 at 8:15 PM, Doug McCorkle wrote: > Hello Robert, > > Is there a reason the copy constructor in Program.cpp would be a bad thing > to be called during copy operations? I do not quite understand the purposes > of this debug statement: > > Program::Program(const Program& rhs, const osg::CopyOp& copyop): > osg::StateAttribute(rhs, copyop) > { > osg::notify(osg::FATAL) << "how got here?" << std::endl; > _geometryVerticesOut = rhs._geometryVerticesOut; > _geometryInputType = rhs._geometryInputType; > _geometryOutputType = rhs._geometryOutputType; > } > > It is in the src/osg/Program.cpp file. I do not understand what would be > wrong with this copy constructor. > > Doug > > ___ > osg-users mailing list > osg-users@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] Odd debug statement in Program.cpp
Hello Robert, Is there a reason the copy constructor in Program.cpp would be a bad thing to be called during copy operations? I do not quite understand the purposes of this debug statement: Program::Program(const Program& rhs, const osg::CopyOp& copyop): osg::StateAttribute(rhs, copyop) { osg::notify(osg::FATAL) << "how got here?" << std::endl; _geometryVerticesOut = rhs._geometryVerticesOut; _geometryInputType = rhs._geometryInputType; _geometryOutputType = rhs._geometryOutputType; } It is in the src/osg/Program.cpp file. I do not understand what would be wrong with this copy constructor. Doug ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org