[osg-users] problem with include/osgViewer/config for windows users (svn commit 13403)

2013-05-16 Thread Laurens Voerman

Hi Robert,

with svn commit a problem for windows users emerged, the file
include/osgViewer/Config
prohibits the creation of the directory
include/osgViewer/config/
on non case sensitive filesystems.

(Turtoise)svn update fails with a permissions error.

I would suggest renaming the directory (to winconfig or screenconfig 
perhaps?).


Regards,
Laurens Voerman.

___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] problem with include/osgViewer/config for windows users (svn commit 13403)

2013-05-16 Thread Robert Osfield
Hi Laurens,

On 16 May 2013 09:20, Laurens Voerman l.voer...@rug.nl wrote:

 Hi Robert,

 with svn commit a problem for windows users emerged, the file
 include/osgViewer/Config
 prohibits the creation of the directory
 include/osgViewer/config/
 on non case sensitive filesystems.

 (Turtoise)svn update fails with a permissions error.

 I would suggest renaming the directory (to winconfig or screenconfig
 perhaps?).


Oh dear, sorry about this.  Next considered that there might be an easy
with a case.

I've been thinking about moving the Config base class as a nested class
within osgViewer::View, so this would remove the header so would resolve
the issue. I've also been wondering if the directory name should be
include/osgViewer/configurations/

Thoughts?
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] problem with include/osgViewer/config for windows users (svn commit 13403)

2013-05-16 Thread Laurens Voerman

Hi Robert,
no strong opinions on my side, I did not even fully read the new config 
options and classes yet.



Also I don't know how TurtoiseSvn or other windows svn clients handle 
the update command, so I cannot predict if adding these changes will 
allow other windows users to pass the update from below 13403 to the 
commited version with no conflicting file/directory mix.


Regards, Laurens

On 5/16/2013 10:47 AM, Robert Osfield wrote:

Hi Laurens,

On 16 May 2013 09:20, Laurens Voerman l.voer...@rug.nl 
mailto:l.voer...@rug.nl wrote:


Hi Robert,

with svn commit a problem for windows users emerged, the file
include/osgViewer/Config
prohibits the creation of the directory
include/osgViewer/config/
on non case sensitive filesystems.

(Turtoise)svn update fails with a permissions error.

I would suggest renaming the directory (to winconfig or
screenconfig perhaps?).


Oh dear, sorry about this.  Next considered that there might be an 
easy with a case.


I've been thinking about moving the Config base class as a nested 
class within osgViewer::View, so this would remove the header so would 
resolve the issue. I've also been wondering if the directory name 
should be include/osgViewer/configurations/


Thoughts?
Robert.





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] problem with include/osgViewer/config for windows users (svn commit 13403)

2013-05-16 Thread Robert Osfield
Hi Laurens,

On 16 May 2013 10:07, Laurens Voerman l.voer...@rug.nl wrote:

  no strong opinions on my side, I did not even fully read the new config
 options and classes yet.


I have renamed the base class ViewConfig and placed into into the View
header.  This opens the door to have a ViewerConfig etc. base classes and
avoids the svn/Windows issues that you've seen.  I'm currently doing
testing and once things are working will check it in.  I'll ping the list
once I've done the check in.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] problem with include/osgViewer/config for windows users (svn commit 13403)

2013-05-16 Thread Robert Osfield
Hi All,

I have now checked in the change of osgViewer::Config to ViewConfig,
placing the class declaration into include/osgViewer/View, and deleting the
Config header.

Let me know if there are any build problems so I can address this right
away.

Cheers,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] problem with include/osgViewer/config for windows users (svn commit 13403)

2013-05-16 Thread Laurens Voerman

Hi Robert,

Svn update successful, (after deleting config directory by hand and 
TurtoiseSvn clean up )

Cmake configure seemed to work fine, now compiling.

osg97-osgViewer.dll compiled just fine.

Regards, laurens.

On 5/16/2013 12:12 PM, Robert Osfield wrote:

Hi All,

I have now checked in the change of osgViewer::Config to ViewConfig, 
placing the class declaration into include/osgViewer/View, and 
deleting the Config header.


Let me know if there are any build problems so I can address this 
right away.


Cheers,
Robert.


___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] problem with include/osgViewer/config for windows users (svn commit 13403)

2013-05-16 Thread Robert Osfield
On 16 May 2013 12:58, Laurens Voerman l.voer...@rug.nl wrote:

  Hi Robert,

 Svn update successful, (after deleting config directory by hand and
 TurtoiseSvn clean up )
 Cmake configure seemed to work fine, now compiling.

 osg97-osgViewer.dll compiled just fine.


Thanks for the feedback. Fingers crossed the rest of the build will go fine.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org