[osg-users] svn 8134 osgprerender --image
Hi, with the latest SVN and osgprerender --image, I'm getting a lot of: Warning: detected OpenGL error 'invalid enumerant' after RenderBin::draw(,) lines written to the screen. Does anyone else see this? Without --image there are no errors. On another machine I have rev 8084 and have recompiled that version and do not see the error then. regards jp -- This message is subject to the CSIR's copyright terms and conditions, e-mail legal notice, and implemented Open Document Format (ODF) standard. The full disclaimer details can be found at http://www.csir.co.za/disclaimer.html. This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. MailScanner thanks Transtec Computers for their support. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
Hi J.P, On Fri, Apr 18, 2008 at 10:53 AM, J.P. Delport [EMAIL PROTECTED] wrote: version 8084 (that works) already has MRT included, that's why I had it on another machine. It seems like it was the moving of the MRT to FBO that might be the problem. Thanks for the clarification, gives us a little more to go on. Another possible clue: osgprerender cow.osg --image --fbo Produces the OpenGL error, while: osgprerender cow.osg --image --window osgprerender cow.osg --image --fb osgprerender cow.osg --image --pbuffer Don't produce and error, so its certainly the FBO code itself that is at fault. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
Hi J.P, Thanks for the heads up, I just tried it on my machine (Kubuntu 7.10, 7800GT) and get the same error. My guess is that the changes to support Multiple Render Targets has broken something in RenderStage w.r.t reading imagery. Arrrgghghg two steps forward, one step back Robert. On Fri, Apr 18, 2008 at 10:20 AM, J.P. Delport [EMAIL PROTECTED] wrote: Hi, with the latest SVN and osgprerender --image, I'm getting a lot of: Warning: detected OpenGL error 'invalid enumerant' after RenderBin::draw(,) lines written to the screen. Does anyone else see this? Without --image there are no errors. On another machine I have rev 8084 and have recompiled that version and do not see the error then. regards jp -- This message is subject to the CSIR's copyright terms and conditions, e-mail legal notice, and implemented Open Document Format (ODF) standard. The full disclaimer details can be found at http://www.csir.co.za/disclaimer.html. This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. MailScanner thanks Transtec Computers for their support. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
Hi Robert, Robert Osfield wrote: Hi J.P, On Fri, Apr 18, 2008 at 10:53 AM, J.P. Delport [EMAIL PROTECTED] wrote: version 8084 (that works) already has MRT included, that's why I had it on another machine. It seems like it was the moving of the MRT to FBO that might be the problem. Thanks for the clarification, gives us a little more to go on. Another possible clue: osgprerender cow.osg --image --fbo Produces the OpenGL error, while: osgprerender cow.osg --image --window osgprerender cow.osg --image --fb osgprerender cow.osg --image --pbuffer Don't produce and error, so its certainly the FBO code itself that is at fault. Yes, I think I know what is wrong. Remember how you modified the enum Camera::BufferComponent so that COLOR_BUFFER and COLOR_BUFFER0 were not the same? When glDrawBuffers was in RenderStage, it knew to only enable MRT when COLOR_BUFFER0 or later was attached. However, the fbo-setAttachment call is the same for COLOR_BUFFER and COLOR_BUFFER0. So now FBO internally incorrectly calls glDrawBuffers when COLOR_BUFFER (vs COLOR_BUFFER0) is attached and this causes the error. I'm not sure how to fix this without changing fbo-setAttachment. Still looking... jp Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org -- This message is subject to the CSIR's copyright terms and conditions, e-mail legal notice, and implemented Open Document Format (ODF) standard. The full disclaimer details can be found at http://www.csir.co.za/disclaimer.html. This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. MailScanner thanks Transtec Computers for their support. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
Hi J.P, On Fri, Apr 18, 2008 at 11:20 AM, J.P. Delport [EMAIL PROTECTED] wrote: Yes, I think I know what is wrong. Remember how you modified the enum Camera::BufferComponent so that COLOR_BUFFER and COLOR_BUFFER0 were not the same? When glDrawBuffers was in RenderStage, it knew to only enable MRT when COLOR_BUFFER0 or later was attached. However, the fbo-setAttachment call is the same for COLOR_BUFFER and COLOR_BUFFER0. So now FBO internally incorrectly calls glDrawBuffers when COLOR_BUFFER (vs COLOR_BUFFER0) is attached and this causes the error. Reviewing the code in RenderStage I can see that the use of OpenGL enum GL_COLOR_ATTACHMENT0_EXT for both osg::Camera::COLOR_BUFFER and osg::Camera::COLOR_BUFFERi is the source of the problem i.e. FBO starts assuming its using MRT even when its not actually been requested. Here lies the problem with implicitly turning on/off MRT. I'm not sure how to fix this without changing fbo-setAttachment. Still looking... Change FBO so that it used osg::Camear::BufferComponent rather than GLenum would be one way, as this would allow use to differentiate properly. Changing setAttatchment(GLenum,..) to setAttatchment(osg::Camera::BufferComponent, ..) would however break backwards compatibility. Perhaps we could have both? I'll investigate this avenue. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
Hi J.P et. al, On Fri, Apr 18, 2008 at 12:22 PM, Robert Osfield [EMAIL PROTECTED] wrote: Change FBO so that it used osg::Camear::BufferComponent rather than GLenum would be one way, as this would allow use to differentiate properly. Changing setAttatchment(GLenum,..) to setAttatchment(osg::Camera::BufferComponent, ..) would however break backwards compatibility. Perhaps we could have both? I'll investigate this avenue. I have gone with adding a methods: setAttachment(BufferComponent,...) getAttachment(BufferComponent) hasAttachment(BufferComponent) Where BufferComponent is simply typedef osg::Camera::BufferComponent BufferComponent; Internally I've changed FBO so that it now uses BufferComponent in its internal map rather than GLenum, this allow its to differentiate between FBO MRT and FBO non MRT paths, something that can't be done with GLenum alone. I have left the original setAttachment(GLenum) methods in place for backwards compatibility, but... it isn't as robust as using BufferComponent due to the issue of distinguishing between MRT and non MRT paths. Consider these versions deprecated. With these changes the MRT and the non MRT FBO examples work for me. Could users do an svn update and these out the new codes? Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
Hi All, With these changes the MRT and the non MRT FBO examples work for me. Could users do an svn update and these out the new codes? I have just done more testing, and found that while the follow works: osgprerender cow.osg --image --fbo Without the --image it fails - I just get a back window. osgprerender cow.osg --fbo As yet I don't know why, other RTT effect like osgspotlight and osgshadow work. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
The SVN gives this error: [ 1%] Building CXX object src/osg/CMakeFiles/osg.dir/FrameBufferObject.o /home/alberto/OSGSVN2/trunk/src/osg/FrameBufferObject.cpp: In member function ‘void osg::FrameBufferObject::updateDrawBuffers()’: /home/alberto/OSGSVN2/trunk/src/osg/FrameBufferObject.cpp:619: error: ‘COLOR_BUFFER15’ is not a member of ‘osg::Camera’ make[2]: *** [src/osg/CMakeFiles/osg.dir/FrameBufferObject.o] Error 1 make[1]: *** [src/osg/CMakeFiles/osg.dir/all] Error 2 make: *** [all] Error 2 El Viernes 18 Abril 2008ES 15:37:42 Robert Osfield escribió: Hi All, I've tracked down the below problem and checked in a bug fix for it. So please svn udpate and test. Robert. On Fri, Apr 18, 2008 at 2:16 PM, Robert Osfield [EMAIL PROTECTED] wrote: I have just done more testing, and found that while the follow works: osgprerender cow.osg --image --fbo Without the --image it fails - I just get a back window. osgprerender cow.osg --fbo As yet I don't know why, other RTT effect like osgspotlight and osgshadow work. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
Hi Alberto, Sorry, missed this check in (I was managing multiple patches at once.) The include/osg/Camera updates are now checked in. Robert. On Fri, Apr 18, 2008 at 2:44 PM, Alberto Luaces [EMAIL PROTECTED] wrote: The SVN gives this error: [ 1%] Building CXX object src/osg/CMakeFiles/osg.dir/FrameBufferObject.o /home/alberto/OSGSVN2/trunk/src/osg/FrameBufferObject.cpp: In member function 'void osg::FrameBufferObject::updateDrawBuffers()': /home/alberto/OSGSVN2/trunk/src/osg/FrameBufferObject.cpp:619: error: 'COLOR_BUFFER15' is not a member of 'osg::Camera' make[2]: *** [src/osg/CMakeFiles/osg.dir/FrameBufferObject.o] Error 1 make[1]: *** [src/osg/CMakeFiles/osg.dir/all] Error 2 make: *** [all] Error 2 El Viernes 18 Abril 2008ES 15:37:42 Robert Osfield escribió: Hi All, I've tracked down the below problem and checked in a bug fix for it. So please svn udpate and test. Robert. On Fri, Apr 18, 2008 at 2:16 PM, Robert Osfield [EMAIL PROTECTED] wrote: I have just done more testing, and found that while the follow works: osgprerender cow.osg --image --fbo Without the --image it fails - I just get a back window. osgprerender cow.osg --fbo As yet I don't know why, other RTT effect like osgspotlight and osgshadow work. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
Hi All, I've tracked down the below problem and checked in a bug fix for it. So please svn udpate and test. Robert. On Fri, Apr 18, 2008 at 2:16 PM, Robert Osfield [EMAIL PROTECTED] wrote: I have just done more testing, and found that while the follow works: osgprerender cow.osg --image --fbo Without the --image it fails - I just get a back window. osgprerender cow.osg --fbo As yet I don't know why, other RTT effect like osgspotlight and osgshadow work. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] svn 8134 osgprerender --image
Ok, it builds now, osgprerender --image works if what is intended is to invert the colours of a rectangle inside of the cow texture. I really never tried that example with the --image switch, but I think it's doing its work nicely. El Viernes 18 Abril 2008ES 15:55:54 Robert Osfield escribió: Hi Alberto, Sorry, missed this check in (I was managing multiple patches at once.) The include/osg/Camera updates are now checked in. Robert. On Fri, Apr 18, 2008 at 2:44 PM, Alberto Luaces [EMAIL PROTECTED] wrote: The SVN gives this error: [ 1%] Building CXX object src/osg/CMakeFiles/osg.dir/FrameBufferObject.o /home/alberto/OSGSVN2/trunk/src/osg/FrameBufferObject.cpp: In member function 'void osg::FrameBufferObject::updateDrawBuffers()': /home/alberto/OSGSVN2/trunk/src/osg/FrameBufferObject.cpp:619: error: 'COLOR_BUFFER15' is not a member of 'osg::Camera' make[2]: *** [src/osg/CMakeFiles/osg.dir/FrameBufferObject.o] Error 1 make[1]: *** [src/osg/CMakeFiles/osg.dir/all] Error 2 make: *** [all] Error 2 El Viernes 18 Abril 2008ES 15:37:42 Robert Osfield escribió: Hi All, I've tracked down the below problem and checked in a bug fix for it. So please svn udpate and test. Robert. On Fri, Apr 18, 2008 at 2:16 PM, Robert Osfield [EMAIL PROTECTED] wrote: I have just done more testing, and found that while the follow works: osgprerender cow.osg --image --fbo Without the --image it fails - I just get a back window. osgprerender cow.osg --fbo As yet I don't know why, other RTT effect like osgspotlight and osgshadow work. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
