Re: [osmosis-dev] TagTransform plugin updated

2009-12-16 Thread Anton Popov 
Hello Dave,

I've created the only abstract class with the logic of tag transforming 
already committed, after running some tests.

Best regards,
Popov Anton

On Mon, Dec 7, 2009 at 8:10 PM, Dave Stubbs osm.l...@randomjunk.co.ukwrote:

 Hi,

 Good to see someone working on improvements!

 I just took a look at your commit.

 One question: is it intentional to drop delete changes? I think that's
 the current action, though not entirely sure without testing (for
 which I don't have time atm).

 Also it seems that most of the process is a direct cut'n'paste from
 the TransformTask code. I don't think duplicating the logic in this
 way is a good idea -- do you think you could refactor it to have the
 core process logic separate from either task?

 ie: so that TransformChangeTask becomes more like:

 @Override
 public void process(ChangeContainer changeContainer) {
if ( !ChangeAction.Delete.equals(changeContainer.getAction()) ) {
  EntityContainer entity = changeContainer.getEntityContainer();
  EntityContainer output = transformTask.process(entity);
  if ( output != null )
 sink.process(new ChangeContainer(output,
 changeContainer.getAction());
}
 }


 Thanks,

 Dave


 On Mon, Dec 7, 2009 at 11:33 AM, Alexander Chmyr ach...@cloudmade.com
 wrote:
  Hello,
  We have successfully updated TagTransform plugin and added new task:
 
  --tag-transform-change (--ttc).
  It works exactly as --tt task, but get as input change files (osc) and do
  transformation when adding or modifying. No changes when delete action.
 
  Kudos to Anton Popov (apo...@cogniance.com)
 
  Alexander Chmyr
  Software Engineer
  Cogniance, Inc
 
 
 
  ___
  osmosis-dev mailing list
  osmosis-dev@openstreetmap.org
  http://lists.openstreetmap.org/listinfo/osmosis-dev
 
 

 ___
 osmosis-dev mailing list
 osmosis-dev@openstreetmap.org
 http://lists.openstreetmap.org/listinfo/osmosis-dev

___
osmosis-dev mailing list
osmosis-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/osmosis-dev

Re: [osmosis-dev] TagTransform plugin updated

2009-12-08 Thread Anton Popov 
Hello Dave,

I've understood the case and will fix that. I assume to make changes in a
day or two.

On Tue, Dec 8, 2009 at 12:45 PM, Dave Stubbs osm.l...@randomjunk.co.ukwrote:

 On Tue, Dec 8, 2009 at 10:16 AM, Anton Popov apo...@cogniance.com wrote:
  Hello Dave,
 
  We can split the logic for sure. I will refactor these two tasks.
 
  Speaking about delete actions, I can say I've ignored them expressly,
  because there is no big sense to transform(!) tags in entity, that will
 be
  deleted. I'm new to Osmosis and if you will place arguments when my
  assumption can be wrong I can make changes for the code.
 


 Yeah, they don't need transforming, that's fine. The issue is whether
 they are being dropped from the ongoing change stream? The change
 stream comes into the task via the process method, and the ongoing
 stream leaves it via the call to the Sink.process method. So creates
 and modifies will pass through the transform and only get piped to the
 sink if the transform didn't drop it, but the deletes are never sent
 to the sink, no matter what.

 As I said this was just me looking at the code, I'm fairly sure it's
 wrong but haven't had time to test -- just put it through this use
 case: create a changeset that includes a delete, then using a pass
 through transform you should get the same changeset out the other end,
 including the unaltered deletes.

 Dave




-- 
Best regards,
Popov Anton.

Senior Software Engineer,
Cogniance Inc.

Mobile: +380 68 358 52 13
Skype: popov.work
Google account: Popov.UA.work
MSN: popov...@hotmail.com
ICQ: 461751798
___
osmosis-dev mailing list
osmosis-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/osmosis-dev