Dpif-netdev should not implement internal HW offload details. If need to "apply on all ports", it needs to be done in offload layer. However, in arch level, there is a problem with the proposed series. It will create a meter object per port, while in SW it is one object, that can be shared between multiple flows, on different ports.
>-----Original Message----- >From: Simon Horman <simon.hor...@corigine.com> >Sent: Friday, 16 December 2022 17:51 >To: d...@openvswitch.org >Cc: Eelco Chaudron <echau...@redhat.com>; Ilya Maximets ><i.maxim...@ovn.org>; Eli Britstein <el...@nvidia.com>; Chaoyong He ><chaoyong...@corigine.com>; oss-driv...@corigine.com; Peng Zhang ><peng.zh...@corigine.com>; Simon Horman <simon.hor...@corigine.com> >Subject: [PATCH 0/6] Add support for DPDK meter HW offload > >External email: Use caution opening links or attachments > > >Hi, > >this series adds support for DPDK meter HW offload > >* Patch 1/6: Add netdev provider API for HW offload of DPDK meters >* Patch 2/6: Add DPIF API to offload OpenFlow meters to DPDK >* Patch 3/6: Implement netdev provider API for HW offload of DPDK meters >* Patch 4/6: Add more DPDK meter algorithms >* Patch 4/6: Add support for meter action ti DPDK HW offload >* Patch 4/6: Add CI builds with ALLOW_EXPERIMENTAL_API > >Peng Zhang (6): > netdev-offload: Add DPDK meter offload API > dpif-netdev: Offloading meter with DPDK > netdev-offload-dpdk: Implement meter offload API for DPDK > netdev-dpdk: add meter algorithms > netdev-dpdk-offload: Add support for meter action > ci: add the opts about ALLOW_EXPERIMENTAL_API > > .ci/linux-build.sh | 4 + > .github/workflows/build-and-test.yml | 31 ++++ > Documentation/howto/dpdk.rst | 5 +- > lib/dpif-netdev.c | 102 +++++++++++ > lib/netdev-dpdk.c | 243 +++++++++++++++++++++++++++ > lib/netdev-dpdk.h | 41 +++++ > lib/netdev-offload-dpdk.c | 101 +++++++++++ > lib/netdev-offload-provider.h | 30 ++++ > lib/netdev-offload.c | 59 +++++++ > lib/netdev-offload.h | 9 + > 10 files changed, 623 insertions(+), 2 deletions(-) > >-- >2.30.2 _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
