Re: [ovs-dev] [PATCH net-next 1/2] openvswitch: Move stats allocation to core
Hello:
This series was applied to netdev/net-next.git (main)
by Paolo Abeni :
On Fri, 31 May 2024 04:15:49 -0700 you wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core instead
> of this driver.
>
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
>
> [...]
Here is the summary with links:
- [net-next,1/2] openvswitch: Move stats allocation to core
https://git.kernel.org/netdev/net-next/c/8c3fdff2171c
- [net-next,2/2] openvswitch: Remove generic .ndo_get_stats64
https://git.kernel.org/netdev/net-next/c/2b438c5774cc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 net] openvswitch: Set the skbuff pkt_type for proper pmtud support.
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Thu, 16 May 2024 16:09:41 -0400 you wrote: > Open vSwitch is originally intended to switch at layer 2, only dealing with > Ethernet frames. With the introduction of l3 tunnels support, it crossed > into the realm of needing to care a bit about some routing details when > making forwarding decisions. If an oversized packet would need to be > fragmented during this forwarding decision, there is a chance for pmtu > to get involved and generate a routing exception. This is gated by the > skbuff->pkt_type field. > > [...] Here is the summary with links: - [v2,net] openvswitch: Set the skbuff pkt_type for proper pmtud support. https://git.kernel.org/netdev/net/c/30a92c9e3d6b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] net: openvswitch: fix overwriting ct original tuple for ICMPv6
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 9 May 2024 11:38:05 +0200 you wrote: > OVS_PACKET_CMD_EXECUTE has 3 main attributes: > - OVS_PACKET_ATTR_KEY - Packet metadata in a netlink format. > - OVS_PACKET_ATTR_PACKET - Binary packet content. > - OVS_PACKET_ATTR_ACTIONS - Actions to execute on the packet. > > OVS_PACKET_ATTR_KEY is parsed first to populate sw_flow_key structure > with the metadata like conntrack state, input port, recirculation id, > etc. Then the packet itself gets parsed to populate the rest of the > keys from the packet headers. > > [...] Here is the summary with links: - [net] net: openvswitch: fix overwriting ct original tuple for ICMPv6 https://git.kernel.org/netdev/net/c/7c988176b6c1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] selftests/net: fix uninitialized variables
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 6 May 2024 12:02:04 -0700 you wrote: > When building with clang, via: > > make LLVM=1 -C tools/testing/selftest > > ...clang warns about three variables that are not initialized in all > cases: > > [...] Here is the summary with links: - [v2] selftests/net: fix uninitialized variables https://git.kernel.org/netdev/net-next/c/eb709b5f6536 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] net: openvswitch: Fix Use-After-Free in ovs_ct_exit
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 22 Apr 2024 05:37:17 -0400 you wrote: > Since kfree_rcu, which is called in the hlist_for_each_entry_rcu traversal > of ovs_ct_limit_exit, is not part of the RCU read critical section, it > is possible that the RCU grace period will pass during the traversal and > the key will be free. > > To prevent this, it should be changed to hlist_for_each_entry_safe. > > [...] Here is the summary with links: - net: openvswitch: Fix Use-After-Free in ovs_ct_exit https://git.kernel.org/netdev/net/c/5ea7b72d4fac You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] net: openvswitch: Release reference to netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski :
On Tue, 23 Apr 2024 15:37:51 +0800 you wrote:
> dev_get_by_name will provide a reference on the netdev. So ensure that
> the reference of netdev is released after completed.
>
> Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name")
> Signed-off-by: Jun Gu
> ---
> net/openvswitch/vport-netdev.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net-next] net: openvswitch: Release reference to netdev
https://git.kernel.org/netdev/net-next/c/66270920f90f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v4] net: openvswitch: Check vport netdev name
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 19 Apr 2024 14:14:25 +0800 you wrote: > Ensure that the provided netdev name is not one of its aliases to > prevent unnecessary creation and destruction of the vport by > ovs-vswitchd. > > Signed-off-by: Jun Gu > Acked-by: Eelco Chaudron > > [...] Here is the summary with links: - [net-next,v4] net: openvswitch: Check vport netdev name https://git.kernel.org/netdev/net-next/c/2540088b836f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] selftests: openvswitch: Fix escape chars in regexp.
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 16 Apr 2024 11:09:13 +0200 you wrote: > Character sequences starting with `\` are interpreted by python as > escaped Unicode characters. However, they have other meaning in > regular expressions (e.g: "\d"). > > It seems Python >= 3.12 starts emitting a SyntaxWarning when these > escaped sequences are not recognized as valid Unicode characters. > > [...] Here is the summary with links: - [net-next] selftests: openvswitch: Fix escape chars in regexp. https://git.kernel.org/netdev/net-next/c/3fde60afe1f8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] net: openvswitch: fix unwanted error log on timeout policy probing
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 3 Apr 2024 22:38:01 +0200 you wrote: > On startup, ovs-vswitchd probes different datapath features including > support for timeout policies. While probing, it tries to execute > certain operations with OVS_PACKET_ATTR_PROBE or OVS_FLOW_ATTR_PROBE > attributes set. These attributes tell the openvswitch module to not > log any errors when they occur as it is expected that some of the > probes will fail. > > [...] Here is the summary with links: - [net] net: openvswitch: fix unwanted error log on timeout policy probing https://git.kernel.org/netdev/net/c/4539f91f2a80 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v2 0/2] net: openvswitch: limit the recursions from action sets
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 7 Feb 2024 08:24:14 -0500 you wrote: > Open vSwitch module accepts actions as a list from the netlink socket > and then creates a copy which it uses in the action set processing. > During processing of the action list on a packet, the module keeps a > count of the execution depth and exits processing if the action depth > goes too high. > > However, during netlink processing the recursion depth isn't checked > anywhere, and the copy trusts that kernel has large enough stack to > accommodate it. The OVS sample action was the original action which > could perform this kinds of recursion, and it originally checked that > it didn't exceed the sample depth limit. However, when sample became > optimized to provide the clone() semantics, the recursion limit was > dropped. > > [...] Here is the summary with links: - [net,v2,1/2] net: openvswitch: limit the number of recursions from action sets https://git.kernel.org/netdev/net/c/6e2f90d31fe0 - [net,v2,2/2] selftests: openvswitch: Add validation for the recursion test https://git.kernel.org/netdev/net/c/bd128f62c365 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] selftests: openvswitch: Test ICMP related matches work with SNAT
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller :
On Wed, 31 Jan 2024 17:08:22 +1300 you wrote:
> Add a test case for regression in openvswitch nat that was fixed by
> commit e6345d2824a3 ("netfilter: nf_nat: fix action not being set for
> all ct states").
>
> Link: https://lore.kernel.org/netdev/20231221224311.130319-1-b...@faucet.nz/
> Link: https://mail.openvswitch.org/pipermail/ovs-dev/2024-January/410476.html
> Suggested-by: Aaron Conole
> Signed-off-by: Brad Cowie
>
> [...]
Here is the summary with links:
- [net-next] selftests: openvswitch: Test ICMP related matches work with SNAT
https://git.kernel.org/netdev/net-next/c/094bdd48afb8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 1/2] net: openvswitch: Use struct_size()
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Sat, 14 Oct 2023 08:34:52 +0200 you wrote: > Use struct_size() instead of hand writing it. > This is less verbose and more robust. > > Signed-off-by: Christophe JAILLET > --- > v2: No change > > [...] Here is the summary with links: - [v2,1/2] net: openvswitch: Use struct_size() https://git.kernel.org/netdev/net-next/c/df3bf90fef28 - [v2,2/2] net: openvswitch: Annotate struct mask_array with __counted_by https://git.kernel.org/netdev/net-next/c/7713ec844756 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v2 0/4] selftests: openvswitch: Minor fixes for some systems
Hello: This series was applied to netdev/net.git (main) by David S. Miller : On Wed, 11 Oct 2023 15:49:35 -0400 you wrote: > A number of corner cases were caught when trying to run the selftests on > older systems. Missed skip conditions, some error cases, and outdated > python setups would all report failures but the issue would actually be > related to some other condition rather than the selftest suite. > > Address these individual cases. > > [...] Here is the summary with links: - [net,v2,1/4] selftests: openvswitch: Add version check for pyroute2 https://git.kernel.org/netdev/net/c/92e37f20f20a - [net,v2,2/4] selftests: openvswitch: Catch cases where the tests are killed https://git.kernel.org/netdev/net/c/af846afad5ca - [net,v2,3/4] selftests: openvswitch: Skip drop testing on older kernels https://git.kernel.org/netdev/net/c/76035fd12cb9 - [net,v2,4/4] selftests: openvswitch: Fix the ct_tuple for v4 https://git.kernel.org/netdev/net/c/8eff0e062201 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 00/14] Batch 1: Annotate structs with __counted_by
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 22 Sep 2023 10:28:42 -0700 you wrote: > Hi, > > This is the batch 1 of patches touching netdev for preparing for > the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > [...] Here is the summary with links: - [01/14] ipv4: Annotate struct fib_info with __counted_by https://git.kernel.org/netdev/net-next/c/5b98fd5dc1e3 - [02/14] ipv4/igmp: Annotate struct ip_sf_socklist with __counted_by https://git.kernel.org/netdev/net-next/c/210d4e9c732f - [03/14] ipv6: Annotate struct ip6_sf_socklist with __counted_by https://git.kernel.org/netdev/net-next/c/5d22b6528073 - [04/14] net: hns: Annotate struct ppe_common_cb with __counted_by https://git.kernel.org/netdev/net-next/c/5b829c8460ae - [05/14] net: enetc: Annotate struct enetc_int_vector with __counted_by https://git.kernel.org/netdev/net-next/c/dd8e215ea9a8 - [06/14] net: hisilicon: Annotate struct rcb_common_cb with __counted_by https://git.kernel.org/netdev/net-next/c/2290999d278e - [07/14] net: mana: Annotate struct mana_rxq with __counted_by https://git.kernel.org/netdev/net-next/c/a3d7a1209bbb - [08/14] net: ipa: Annotate struct ipa_power with __counted_by https://git.kernel.org/netdev/net-next/c/20551ee45d7d - [09/14] net: mana: Annotate struct hwc_dma_buf with __counted_by https://git.kernel.org/netdev/net-next/c/59656519763d - [10/14] net: openvswitch: Annotate struct dp_meter_instance with __counted_by https://git.kernel.org/netdev/net-next/c/e7b34822fa4d - [11/14] net: enetc: Annotate struct enetc_psfp_gate with __counted_by https://git.kernel.org/netdev/net-next/c/93bc6ab6b19d - [12/14] net: openvswitch: Annotate struct dp_meter with __counted_by https://git.kernel.org/netdev/net-next/c/16ae53d80c00 - [13/14] net: tulip: Annotate struct mediatable with __counted_by https://git.kernel.org/netdev/net-next/c/0d01cfe5aaaf - [14/14] net: sched: Annotate struct tc_pedit with __counted_by (no matching commit) You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v2] openvswitch: reduce stack usage in do_execute_actions
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Thu, 21 Sep 2023 21:42:35 +0200 you wrote: > do_execute_actions() function can be called recursively multiple > times while executing actions that require pipeline forking or > recirculations. It may also be re-entered multiple times if the packet > leaves openvswitch module and re-enters it through a different port. > > Currently, there is a 256-byte array allocated on stack in this > function that is supposed to hold NSH header. Compilers tend to > pre-allocate that space right at the beginning of the function: > > [...] Here is the summary with links: - [net-next,v2] openvswitch: reduce stack usage in do_execute_actions https://git.kernel.org/netdev/net-next/c/06bc3668cc2a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] net: dst: remove unnecessary input parameter in dst_alloc and dst_init
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni :
On Mon, 11 Sep 2023 20:50:45 +0800 you wrote:
> Since commit 1202cdd66531("Remove DECnet support from kernel") has been
> merged, all callers pass in the initial_ref value of 1 when they call
> dst_alloc(). Therefore, remove initial_ref when the dst_alloc() is
> declared and replace initial_ref with 1 in dst_alloc().
> Also when all callers call dst_init(), the value of initial_ref is 1.
> Therefore, remove the input parameter initial_ref of the dst_init() and
> replace initial_ref with the value 1 in dst_init.
>
> [...]
Here is the summary with links:
- [net-next] net: dst: remove unnecessary input parameter in dst_alloc and
dst_init
https://git.kernel.org/netdev/net-next/c/762c8dc7f269
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] net: openvswitch: reject negative ifindex
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski :
On Mon, 14 Aug 2023 13:38:40 -0700 you wrote:
> Recent changes in net-next (commit 759ab1edb56c ("net: store netdevs
> in an xarray")) refactored the handling of pre-assigned ifindexes
> and let syzbot surface a latent problem in ovs. ovs does not validate
> ifindex, making it possible to create netdev ports with negative
> ifindex values. It's easy to repro with YNL:
>
> $ ./cli.py --spec netlink/specs/ovs_datapath.yaml \
> --do new \
>--json '{"upcall-pid": 1, "name":"my-dp"}'
> $ ./cli.py --spec netlink/specs/ovs_vport.yaml \
>--do new \
>--json '{"upcall-pid": "0001", "name": "some-port0",
> "dp-ifindex":3,"ifindex":4294901760,"type":2}'
>
> [...]
Here is the summary with links:
- [net] net: openvswitch: reject negative ifindex
https://git.kernel.org/netdev/net/c/a552bfa16bab
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [net-next v5 0/7] openvswitch: add drop reasons
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Fri, 11 Aug 2023 16:12:47 +0200 you wrote: > There is currently a gap in drop visibility in the openvswitch module. > This series tries to improve this by adding a new drop reason subsystem > for OVS. > > Apart from adding a new drop reasson subsystem and some common drop > reasons, this series takes Eric's preliminary work [1] on adding an > explicit drop action and integrates it into the same subsystem. > > [...] Here is the summary with links: - [net-next,v5,1/7] net: openvswitch: add last-action drop reason https://git.kernel.org/netdev/net-next/c/9d802da40b7c - [net-next,v5,2/7] net: openvswitch: add action error drop reason https://git.kernel.org/netdev/net-next/c/ec7bfb5e5a05 - [net-next,v5,3/7] net: openvswitch: add explicit drop action https://git.kernel.org/netdev/net-next/c/e7bc7db9ba46 - [net-next,v5,4/7] net: openvswitch: add meter drop reason https://git.kernel.org/netdev/net-next/c/f329d1bc1a45 - [net-next,v5,5/7] net: openvswitch: add misc error drop reasons https://git.kernel.org/netdev/net-next/c/43d95b30cf57 - [net-next,v5,6/7] selftests: openvswitch: add drop reason testcase https://git.kernel.org/netdev/net-next/c/aab1272f5dac - [net-next,v5,7/7] selftests: openvswitch: add explicit drop testcase https://git.kernel.org/netdev/net-next/c/4242029164d6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v3 net-next 0/5] selftests: openvswitch: add flow programming cases
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Tue, 1 Aug 2023 17:22:21 -0400 you wrote: > The openvswitch selftests currently contain a few cases for managing the > datapath, which includes creating datapath instances, adding interfaces, > and doing some basic feature / upcall tests. This is useful to validate > the control path. > > Add the ability to program some of the more common flows with actions. This > can be improved overtime to include regression testing, etc. > > [...] Here is the summary with links: - [v3,net-next,1/5] selftests: openvswitch: add an initial flow programming case https://git.kernel.org/netdev/net-next/c/918423fda910 - [v3,net-next,2/5] selftests: openvswitch: support key masks https://git.kernel.org/netdev/net-next/c/9f1179fbbd84 - [v3,net-next,3/5] selftests: openvswitch: add a test for ipv4 forwarding https://git.kernel.org/netdev/net-next/c/05398aa40953 - [v3,net-next,4/5] selftests: openvswitch: add basic ct test case parsing https://git.kernel.org/netdev/net-next/c/2893ba9c1d1a - [v3,net-next,5/5] selftests: openvswitch: add ct-nat test case with ipv4 https://git.kernel.org/netdev/net-next/c/60f10077eec6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next 0/3] net: handle the exp removal problem with ovs upcall properly
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Sun, 16 Jul 2023 17:09:16 -0400 you wrote: > With the OVS upcall, the original ct in the skb will be dropped, and when > the skb comes back from userspace it has to create a new ct again through > nf_conntrack_in() in either OVS __ovs_ct_lookup() or TC tcf_ct_act(). > > However, the new ct will not be able to have the exp as the original ct > has taken it away from the hash table in nf_ct_find_expectation(). This > will cause some flow never to be matched, like: > > [...] Here is the summary with links: - [net-next,1/3] netfilter: allow exp not to be removed in nf_ct_find_expectation https://git.kernel.org/netdev/net-next/c/4914109a8e1e - [net-next,2/3] net: sched: set IPS_CONFIRMED in tmpl status only when commit is set in act_ct https://git.kernel.org/netdev/net-next/c/76622ced50a1 - [net-next,3/3] openvswitch: set IPS_CONFIRMED in tmpl status only when commit is set in conntrack https://git.kernel.org/netdev/net-next/c/8c8b73320805 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] net: openvswitch: add support for l4 symmetric hashing
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Fri, 9 Jun 2023 09:59:55 -0400 you wrote: > Since its introduction, the ovs module execute_hash action allowed > hash algorithms other than the skb->l4_hash to be used. However, > additional hash algorithms were not implemented. This means flows > requiring different hash distributions weren't able to use the > kernel datapath. > > Now, introduce support for symmetric hashing algorithm as an > alternative hash supported by the ovs module using the flow > dissector. > > [...] Here is the summary with links: - [net-next] net: openvswitch: add support for l4 symmetric hashing https://git.kernel.org/netdev/net-next/c/e069ba07e6c7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Tue, 6 Jun 2023 13:56:35 +0200 you wrote: > Currently, the per cpu upcall counters are allocated after the vport is > created and inserted into the system. This could lead to the datapath > accessing the counters before they are allocated resulting in a kernel > Oops. > > Here is an example: > > [...] Here is the summary with links: - [net,v2] net: openvswitch: fix upcall counter access before allocation https://git.kernel.org/netdev/net/c/de9df6c6b27e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] net: openvswitch: Use struct_size()
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sat, 6 May 2023 18:04:16 +0200 you wrote: > Use struct_size() instead of hand writing it. > This is less verbose and more informative. > > Signed-off-by: Christophe JAILLET > --- > It will also help scripts when __counted_by macro will be added. > See [1]. > > [...] Here is the summary with links: - [net-next] net: openvswitch: Use struct_size() https://git.kernel.org/netdev/net-next/c/b50a8b0d57ab You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next 0/3] selftests: openvswitch: add support for testing upcall interface
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Fri, 14 Apr 2023 09:17:47 -0400 you wrote: > The existing selftest suite for openvswitch will work for regression > testing the datapath feature bits, but won't test things like adding > interfaces, or the upcall interface. Here, we add some additional > test facilities. > > First, extend the ovs-dpctl.py python module to support the OVS_FLOW > and OVS_PACKET netlink families, with some associated messages. These > can be extended over time, but the initial support is for more well > known cases (output, userspace, and CT). > > [...] Here is the summary with links: - [net-next,1/3] selftests: openvswitch: add interface support https://git.kernel.org/netdev/net-next/c/74cc26f416b9 - [net-next,2/3] selftests: openvswitch: add flow dump support https://git.kernel.org/netdev/net-next/c/e52b07aa1a54 - [net-next,3/3] selftests: openvswitch: add support for upcall testing https://git.kernel.org/netdev/net-next/c/9feac87b673c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] selftests: openvswitch: adjust datapath NL message declaration
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski :
On Wed, 12 Apr 2023 07:58:28 -0400 you wrote:
> The netlink message for creating a new datapath takes an array
> of ports for the PID creation. This shouldn't cause much issue
> but correct it for future cases where we need to do decode of
> datapath information that could include the per-cpu PID map.
>
> Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")
> Signed-off-by: Aaron Conole
>
> [...]
Here is the summary with links:
- [net] selftests: openvswitch: adjust datapath NL message declaration
https://git.kernel.org/netdev/net/c/306dc2136199
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v3] net: openvswitch: fix race on port output
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 5 Apr 2023 07:53:41 + you wrote: > assume the following setup on a single machine: > 1. An openvswitch instance with one bridge and default flows > 2. two network namespaces "server" and "client" > 3. two ovs interfaces "server" and "client" on the bridge > 4. for each ovs interface a veth pair with a matching name and 32 rx and >tx queues > 5. move the ends of the veth pairs to the respective network namespaces > 6. assign ip addresses to each of the veth ends in the namespaces (needs >to be the same subnet) > 7. start some http server on the server network namespace > 8. test if a client in the client namespace can reach the http server > > [...] Here is the summary with links: - [net,v3] net: openvswitch: fix race on port output https://git.kernel.org/netdev/net/c/066b86787fa3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v3] net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller :
On Fri, 10 Feb 2023 10:05:51 +0800 you wrote:
> old_meter needs to be free after it is detached regardless of whether
> the new meter is successfully attached.
>
> Fixes: c7c4c44c9a95 ("net: openvswitch: expand the meters supported number")
> Signed-off-by: Hangyu Hua
> ---
>
> [...]
Here is the summary with links:
- [v3] net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()
https://git.kernel.org/netdev/net/c/2fa28f5c6fcb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCHv2 net-next 0/5] net: move more duplicate code of ovs and tc conntrack into nf_conntrack_ovs
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski : On Tue, 7 Feb 2023 17:52:05 -0500 you wrote: > We've moved some duplicate code into nf_nat_ovs in: > > "net: eliminate the duplicate code in the ct nat functions of ovs and tc" > > This patchset addresses more code duplication in the conntrack of ovs > and tc then creates nf_conntrack_ovs for them, and four functions will > be extracted and moved into it: > > [...] Here is the summary with links: - [PATCHv2,net-next,1/5] net: create nf_conntrack_ovs for ovs and tc use https://git.kernel.org/netdev/net-next/c/c0c3ab63de60 - [PATCHv2,net-next,2/5] net: extract nf_ct_skb_network_trim function to nf_conntrack_ovs https://git.kernel.org/netdev/net-next/c/67fc5d7ffbd4 - [PATCHv2,net-next,3/5] openvswitch: move key and ovs_cb update out of handle_fragments https://git.kernel.org/netdev/net-next/c/1b83bf4489cb - [PATCHv2,net-next,4/5] net: sched: move frag check and tc_skb_cb update out of handle_fragments https://git.kernel.org/netdev/net-next/c/558d95e7e11c - [PATCHv2,net-next,5/5] net: extract nf_ct_handle_fragments to nf_conntrack_ovs https://git.kernel.org/netdev/net-next/c/0785407e78d4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v3 1/3] string_helpers: Move string_is_valid() to the header
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 8 Feb 2023 15:31:51 +0200 you wrote: > Move string_is_valid() to the header for wider use. > > While at it, rename to string_is_terminated() to be > precise about its semantics. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Simon Horman > > [...] Here is the summary with links: - [net-next,v3,1/3] string_helpers: Move string_is_valid() to the header https://git.kernel.org/netdev/net-next/c/f1db99c07b4f - [net-next,v3,2/3] genetlink: Use string_is_terminated() helper https://git.kernel.org/netdev/net-next/c/d4545bf9c33b - [net-next,v3,3/3] openvswitch: Use string_is_terminated() helper https://git.kernel.org/netdev/net-next/c/5c72b4c644eb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v8 1/1] net: openvswitch: reduce cpu_used_mask memory
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Sun, 5 Feb 2023 09:35:37 +0800 you wrote: > Use actual CPU number instead of hardcoded value to decide the size > of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason. > > 'struct cpumask cpu_used_mask' is embedded in struct sw_flow. > Its size is hardcoded to CONFIG_NR_CPUS bits, which can be > 8192 by default, it costs memory and slows down ovs_flow_alloc. > > [...] Here is the summary with links: - [net-next,v8,1/1] net: openvswitch: reduce cpu_used_mask memory https://git.kernel.org/netdev/net-next/c/15ea59a0e9bf You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] net: openvswitch: fix flow memory leak in ovs_flow_cmd_new
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 2 Feb 2023 00:02:18 +0300 you wrote: > Syzkaller reports a memory leak of new_flow in ovs_flow_cmd_new() as it is > not freed when an allocation of a key fails. > > BUG: memory leak > unreferenced object 0x888116668000 (size 632): > comm "syz-executor231", pid 1090, jiffies 4294844701 (age 18.871s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > backtrace: > [] kmem_cache_zalloc include/linux/slab.h:654 [inline] > [ ] ovs_flow_alloc+0x19/0x180 > net/openvswitch/flow_table.c:77 > [ ] ovs_flow_cmd_new+0x1de/0xd40 > net/openvswitch/datapath.c:957 > [<10a539a8>] genl_family_rcv_msg_doit+0x22d/0x330 > net/netlink/genetlink.c:739 > [ ] genl_family_rcv_msg net/netlink/genetlink.c:783 > [inline] > [ ] genl_rcv_msg+0x328/0x590 net/netlink/genetlink.c:800 > [<0286dd87>] netlink_rcv_skb+0x153/0x430 > net/netlink/af_netlink.c:2515 > [<61fed410>] genl_rcv+0x24/0x40 net/netlink/genetlink.c:811 > [<9dc0f111>] netlink_unicast_kernel net/netlink/af_netlink.c:1313 > [inline] > [<9dc0f111>] netlink_unicast+0x545/0x7f0 > net/netlink/af_netlink.c:1339 > [<4a5ee816>] netlink_sendmsg+0x8e7/0xde0 > net/netlink/af_netlink.c:1934 > [<482b476f>] sock_sendmsg_nosec net/socket.c:651 [inline] > [<482b476f>] sock_sendmsg+0x152/0x190 net/socket.c:671 > [<698574ba>] sys_sendmsg+0x70a/0x870 net/socket.c:2356 > [ ] ___sys_sendmsg+0xf3/0x170 net/socket.c:2410 > [<83ba9120>] __sys_sendmsg+0xe5/0x1b0 net/socket.c:2439 > [ ] do_syscall_64+0x30/0x40 arch/x86/entry/common.c:46 > [<4abfdcf4>] entry_SYSCALL_64_after_hwframe+0x61/0xc6 > > [...] Here is the summary with links: - [v2] net: openvswitch: fix flow memory leak in ovs_flow_cmd_new https://git.kernel.org/netdev/net/c/0c598aed445e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] net: openvswitch: release vport resources on failure
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski :
On Tue, 20 Dec 2022 16:27:17 -0500 you wrote:
> A recent commit introducing upcall packet accounting failed to properly
> release the vport object when the per-cpu stats struct couldn't be
> allocated. This can cause dangling pointers to dp objects long after
> they've been released.
>
> Cc: Eelco Chaudron
> Cc: wangchuanlei
> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets")
> Reported-by: syzbot+8f4e2dcfcb3209ac3...@syzkaller.appspotmail.com
> Signed-off-by: Aaron Conole
>
> [...]
Here is the summary with links:
- [net] net: openvswitch: release vport resources on failure
https://git.kernel.org/netdev/net/c/95637d91fefd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v3] openvswitch: Fix flow lookup to use unmasked key
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Thu, 15 Dec 2022 15:46:33 +0100 you wrote: > The commit mentioned below causes the ovs_flow_tbl_lookup() function > to be called with the masked key. However, it's supposed to be called > with the unmasked key. This due to the fact that the datapath supports > installing wider flows, and OVS relies on this behavior. For example > if ipv4(src=1.1.1.1/192.0.0.0, dst=1.1.1.2/192.0.0.0) exists, a wider > flow (smaller mask) of ipv4(src=192.1.1.1/128.0.0.0,dst=192.1.1.2/ > 128.0.0.0) is allowed to be added. > > [...] Here is the summary with links: - [net,v3] openvswitch: Fix flow lookup to use unmasked key https://git.kernel.org/netdev/net/c/68bb10101e6b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCHv4 net-next 0/5] net: eliminate the duplicate code in the ct nat functions of ovs and tc
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller : On Thu, 8 Dec 2022 11:56:07 -0500 you wrote: > The changes in the patchset: > > "net: add helper support in tc act_ct for ovs offloading" > > had moved some common ct code used by both OVS and TC into netfilter. > > There are still some big functions pretty similar defined and used in > each of OVS and TC. It is not good to maintain such big function in 2 > places. This patchset is to extract the functions for NAT processing > from OVS and TC to netfilter. > > [...] Here is the summary with links: - [PATCHv4,net-next,1/5] openvswitch: delete the unncessary skb_pull_rcsum call in ovs_ct_nat_execute https://git.kernel.org/netdev/net-next/c/bf14f4923d51 - [PATCHv4,net-next,2/5] openvswitch: return NF_ACCEPT when OVS_CT_NAT is not set in info nat https://git.kernel.org/netdev/net-next/c/779592892133 - [PATCHv4,net-next,3/5] openvswitch: return NF_DROP when fails to add nat ext in ovs_ct_nat https://git.kernel.org/netdev/net-next/c/2b85144ab36e - [PATCHv4,net-next,4/5] net: sched: update the nat flag for icmp error packets in ct_nat_execute https://git.kernel.org/netdev/net-next/c/0564c3e51bc7 - [PATCHv4,net-next,5/5] net: move the nat function to nf_nat_ovs for ovs and tc https://git.kernel.org/netdev/net-next/c/ebddb1404900 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] [PATCH v9 net-next] net: openvswitch: Add support to count upcall packets
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Tue, 6 Dec 2022 20:38:57 -0500 you wrote: > Add support to count upall packets, when kmod of openvswitch > upcall to count the number of packets for upcall succeed and > failed, which is a better way to see how many packets upcalled > on every interfaces. > > Signed-off-by: wangchuanlei > > [...] Here is the summary with links: - [v9,net-next] net: openvswitch: Add support to count upcall packets https://git.kernel.org/netdev/net-next/c/1933ea365aa7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCHv4 net-next 0/4] net: add helper support in tc act_ct for ovs offloading
Hello: This series was applied to netdev/net-next.git (master) by Paolo Abeni : On Sun, 6 Nov 2022 15:34:13 -0500 you wrote: > Ilya reported an issue that FTP traffic would be broken when the OVS flow > with ct(commit,alg=ftp) installed in the OVS kernel module, and it was > caused by that TC didn't support the ftp helper offloaded from OVS. > > This patchset is to add the helper support in act_ct for OVS offloading > in kernel net/sched. > > [...] Here is the summary with links: - [PATCHv4,net-next,1/4] net: move the ct helper function to nf_conntrack_helper for ovs and tc https://git.kernel.org/netdev/net-next/c/ca71277f36e0 - [PATCHv4,net-next,2/4] net: move add ct helper function to nf_conntrack_helper for ovs and tc https://git.kernel.org/netdev/net-next/c/f96cba2eb923 - [PATCHv4,net-next,3/4] net: sched: call tcf_ct_params_free to free params in tcf_ct_init https://git.kernel.org/netdev/net-next/c/1913894100ca - [PATCHv4,net-next,4/4] net: sched: add helper support in act_ct https://git.kernel.org/netdev/net-next/c/a21b06e73191 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] openvswitch: add missing resv_start_op initialization for dp_vport_genl_family
Hello: This patch was applied to bpf/bpf.git (master) by Jakub Kicinski : On Mon, 31 Oct 2022 16:12:10 +0800 you wrote: > I got a warning using the latest mainline codes to start vms as following: > > === > WARNING: CPU: 1 PID: 1 at net/netlink/genetlink.c:383 > genl_register_family+0x6c/0x76c > CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc2-00886-g882ad2a2a8ff #43 > ... > Call trace: > genl_register_family+0x6c/0x76c > dp_init+0xa8/0x124 > do_one_initcall+0x84/0x450 > > [...] Here is the summary with links: - [net] openvswitch: add missing resv_start_op initialization for dp_vport_genl_family https://git.kernel.org/bpf/bpf/c/e4ba4554209f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] net: openvswitch: add missing .resv_start_op
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski :
On Thu, 27 Oct 2022 20:25:01 -0700 you wrote:
> I missed one of the families in OvS when annotating .resv_start_op.
> This triggers the warning added in commit ce48ebdd5651 ("genetlink:
> limit the use of validation workarounds to old ops").
>
> Reported-by: syzbot+40eb8c0447c0e47a7...@syzkaller.appspotmail.com
> Fixes: 9c5d03d36251 ("genetlink: start to validate reserved header bytes")
> Signed-off-by: Jakub Kicinski
>
> [...]
Here is the summary with links:
- [net] net: openvswitch: add missing .resv_start_op
https://git.kernel.org/netdev/net/c/e4ba4554209f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 net 0/2] openvswitch: syzbot splat fix and introduce selftest
Hello: This series was applied to netdev/net.git (master) by Paolo Abeni : On Tue, 25 Oct 2022 06:50:16 -0400 you wrote: > Syzbot recently caught a splat when dropping features from > openvswitch datapaths that are in-use. The WARN() call is > definitely too large a hammer for the situation, so change > to pr_warn. > > Second patch in the series introduces a new selftest suite which > can help show that an issue is fixed. This change might be > more suited to net-next tree, so it has been separated out > as an additional patch and can be either applied to either tree > based on preference. > > [...] Here is the summary with links: - [v2,net,1/2] openvswitch: switch from WARN to pr_warn https://git.kernel.org/netdev/net/c/fd954cc1919e - [v2,net,2/2] selftests: add openvswitch selftest suite https://git.kernel.org/netdev/net/c/25f16c873fb1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] openvswitch: Use kmalloc_size_roundup() to match ksize() usage
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Tue, 18 Oct 2022 02:06:33 -0700 you wrote: > Round up allocations with kmalloc_size_roundup() so that openvswitch's > use of ksize() is always accurate and no special handling of the memory > is needed by KASAN, UBSAN_BOUNDS, nor FORTIFY_SOURCE. > > Cc: Pravin B Shelar > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: net...@vger.kernel.org > Cc: d...@openvswitch.org > Signed-off-by: Kees Cook > > [...] Here is the summary with links: - openvswitch: Use kmalloc_size_roundup() to match ksize() usage https://git.kernel.org/netdev/net-next/c/ab3f7828c979 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 6 Oct 2022 15:45:02 -0400 you wrote: > A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' > applies on a confirmed connection: > > WARNING: CPU: 0 PID: 1251 at net/netfilter/nf_conntrack_extend.c:98 > RIP: 0010:nf_ct_ext_add+0x12d/0x150 [nf_conntrack] > Call Trace: > >nf_ct_helper_ext_add+0x12/0x60 [nf_conntrack] >__nf_ct_try_assign_helper+0xc4/0x160 [nf_conntrack] >__ovs_ct_lookup+0x72e/0x780 [openvswitch] >ovs_ct_execute+0x1d8/0x920 [openvswitch] >do_execute_actions+0x4e6/0xb60 [openvswitch] >ovs_execute_actions+0x60/0x140 [openvswitch] >ovs_packet_cmd_execute+0x2ad/0x310 [openvswitch] >genl_family_rcv_msg_doit.isra.15+0x113/0x150 >genl_rcv_msg+0xef/0x1f0 > > [...] Here is the summary with links: - [net] openvswitch: add nf_ct_is_confirmed check before assigning the helper https://git.kernel.org/netdev/net/c/3c1860543fcc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v3 net-next 0/2] net: openvswitch: metering and conntrack in userns
Hello: This series was applied to netdev/net-next.git (master) by Paolo Abeni : On Fri, 23 Sep 2022 15:38:18 +0200 you wrote: > Currently using openvswitch in a non-initial user namespace, e.g., an > unprivileged container, is possible but without metering and conntrack > support. This is due to the restriction of the corresponding Netlink > interfaces to the global CAP_NET_ADMIN. > > This simple patches switch from GENL_ADMIN_PERM to GENL_UNS_ADMIN_PERM > in several cases to allow this also for the unprivileged container > use case. > > [...] Here is the summary with links: - [v3,net-next,1/2] net: openvswitch: allow metering in non-initial user namespace https://git.kernel.org/netdev/net-next/c/803937184717 - [v3,net-next,2/2] net: openvswitch: allow conntrack in non-initial user namespace https://git.kernel.org/netdev/net-next/c/59cd7377660a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] openvswitch: Change the return type for vport_ops.send function hook to int
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Tue, 13 Sep 2022 16:07:38 -0700 you wrote: > All usages of the vport_ops struct have the .send field set to > dev_queue_xmit or internal_dev_recv. Since most usages are set to > dev_queue_xmit, the function hook should match the signature of > dev_queue_xmit. > > The only call to vport_ops->send() is in net/openvswitch/vport.c and it > throws away the return value. > > [...] Here is the summary with links: - openvswitch: Change the return type for vport_ops.send function hook to int https://git.kernel.org/netdev/net-next/c/8bb7c4f8c927 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] net: openvswitch: fix repeated words in comments
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 7 Sep 2022 12:03:46 +0800 you wrote: > Delete the redundant word 'is'. > > Signed-off-by: Jilin Yuan > --- > net/openvswitch/flow_netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - net: openvswitch: fix repeated words in comments https://git.kernel.org/netdev/net-next/c/169ccf0e4082 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] genetlink: start to validate reserved header bytes
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 24 Aug 2022 17:18:30 -0700 you wrote: > We had historically not checked that genlmsghdr.reserved > is 0 on input which prevents us from using those precious > bytes in the future. > > One use case would be to extend the cmd field, which is > currently just 8 bits wide and 256 is not a lot of commands > for some core families. > > [...] Here is the summary with links: - [net-next] genetlink: start to validate reserved header bytes https://git.kernel.org/netdev/net-next/c/9c5d03d36251 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v3 0/2] openvswitch: allow specifying ifindex of new interfaces
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski : On Thu, 25 Aug 2022 05:04:48 +0300 you wrote: > Hi! > > CRIU currently do not support checkpoint/restore of OVS configurations, but > there was several requests for it. For example, > https://github.com/lxc/lxc/issues/2909 > > The main problem is ifindexes of newly created interfaces. We realy need to > preserve them after restore. Current openvswitch API does not allow to > specify ifindex. Most of the time we can just create an interface via > generic netlink requests and plug it into ovs but datapaths (generally any > OVS_VPORT_TYPE_INTERNAL) can only be created via openvswitch requests which > do not support selecting ifindex. > > [...] Here is the summary with links: - [net-next,v3,1/2] openvswitch: allow specifying ifindex of new interfaces https://git.kernel.org/netdev/net-next/c/54c4ef34c4b6 - [net-next,v3,2/2] openvswitch: add OVS_DP_ATTR_PER_CPU_PIDS to get requests https://git.kernel.org/netdev/net-next/c/347541e299d5 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v2] openvswitch: fix memory leak at failed datapath creation
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 25 Aug 2022 05:03:26 +0300 you wrote: > ovs_dp_cmd_new()->ovs_dp_change()->ovs_dp_set_upcall_portids() > allocates array via kmalloc. > If for some reason new_vport() fails during ovs_dp_cmd_new() > dp->upcall_portids must be freed. > Add missing kfree. > > Kmemleak example: > unreferenced object 0x88800c382500 (size 64): > comm "dump_state", pid 323, jiffies 4294955418 (age 104.347s) > hex dump (first 32 bytes): > 5e c2 79 e4 1f 7a 38 c7 09 21 38 0c 80 88 ff ff ^.y..z8..!8. > 03 00 00 00 0a 00 00 00 14 00 00 00 28 00 00 00 (... > backtrace: > [<71bebc9f>] ovs_dp_set_upcall_portids+0x38/0xa0 > [<0187d8bd>] ovs_dp_change+0x63/0xe0 > [<2397e446>] ovs_dp_cmd_new+0x1f0/0x380 > [] genl_family_rcv_msg_doit+0xea/0x150 > [<8f583bc4>] genl_rcv_msg+0xdc/0x1e0 > [ ] netlink_rcv_skb+0x50/0x100 > [<4959cece>] genl_rcv+0x24/0x40 > [<4699ac7f>] netlink_unicast+0x23e/0x360 > [ ] netlink_sendmsg+0x24e/0x4b0 > [<6f4aa380>] sock_sendmsg+0x62/0x70 > [ ] sys_sendmsg+0x230/0x270 > [<12dacf7d>] ___sys_sendmsg+0x88/0xd0 > [<11776020>] __sys_sendmsg+0x59/0xa0 > [<2e8f2dc1>] do_syscall_64+0x3b/0x90 > [<3243e7cb>] entry_SYSCALL_64_after_hwframe+0x63/0xcd > > [...] Here is the summary with links: - [net,v2] openvswitch: fix memory leak at failed datapath creation https://git.kernel.org/netdev/net/c/a87406f4adee You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] openvswitch: move from strlcpy with unused retval to strscpy
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Thu, 18 Aug 2022 23:02:25 +0200 you wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: > https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ > Signed-off-by: Wolfram Sang > > [...] Here is the summary with links: - openvswitch: move from strlcpy with unused retval to strscpy https://git.kernel.org/netdev/net-next/c/19d1c0465ab7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v2 1/2] openvswitch: Fix double reporting of drops in dropwatch
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 17 Aug 2022 11:06:34 -0400 you wrote: > Frames sent to userspace can be reported as dropped in > ovs_dp_process_packet, however, if they are dropped in the netlink code > then netlink_attachskb will report the same frame as dropped. > > This patch checks for error codes which indicate that the frame has > already been freed. > > [...] Here is the summary with links: - [net-next,v2,1/2] openvswitch: Fix double reporting of drops in dropwatch https://git.kernel.org/netdev/net-next/c/1100248a5c5c - [net-next,v2,2/2] openvswitch: Fix overreporting of drops in dropwatch https://git.kernel.org/netdev/net-next/c/c21ab2afa2c6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] net: openvswitch: fix parsing of nw_proto for IPv6 fragments
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni : On Tue, 21 Jun 2022 16:48:45 -0400 you wrote: > When a packet enters the OVS datapath and does not match any existing > flows installed in the kernel flow cache, the packet will be sent to > userspace to be parsed, and a new flow will be created. The kernel and > OVS rely on each other to parse packet fields in the same way so that > packets will be handled properly. > > As per the design document linked below, OVS expects all later IPv6 > fragments to have nw_proto=44 in the flow key, so they can be correctly > matched on OpenFlow rules. OpenFlow controllers create pipelines based > on this design. > > [...] Here is the summary with links: - [net] net: openvswitch: fix parsing of nw_proto for IPv6 fragments https://git.kernel.org/netdev/net/c/12378a5a75e3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Tue, 7 Jun 2022 21:39:55 -0700 you wrote: > Netdev reference helpers have a dev_ prefix for historic > reasons. Renaming the old helpers would be too much churn > but we can rename the tracking ones which are relatively > recent and should be the default for new code. > > Rename: > dev_hold_track()-> netdev_hold() > dev_put_track() -> netdev_put() > dev_replace_track() -> netdev_ref_replace() > > [...] Here is the summary with links: - [net-next] net: rename reference+tracking helpers https://git.kernel.org/netdev/net-next/c/d62607c3fe45 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] net: openvswitch: fix misuse of the cached connection on tuple changes
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Tue, 7 Jun 2022 00:11:40 +0200 you wrote: > If packet headers changed, the cached nfct is no longer relevant > for the packet and attempt to re-use it leads to the incorrect packet > classification. > > This issue is causing broken connectivity in OpenStack deployments > with OVS/OVN due to hairpin traffic being unexpectedly dropped. > > [...] Here is the summary with links: - [net] net: openvswitch: fix misuse of the cached connection on tuple changes https://git.kernel.org/netdev/net/c/2061ecfdf235 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] openvswitch: fix OOB access in reserve_sfa_size()
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 15 Apr 2022 10:08:41 +0200 you wrote: > Given a sufficiently large number of actions, while copying and > reserving memory for a new action of a new flow, if next_offset is > greater than MAX_ACTIONS_BUFSIZE, the function reserve_sfa_size() does > not return -EMSGSIZE as expected, but it allocates MAX_ACTIONS_BUFSIZE > bytes increasing actions_len by req_size. This can then lead to an OOB > write access, especially when further actions need to be copied. > > [...] Here is the summary with links: - openvswitch: fix OOB access in reserve_sfa_size() https://git.kernel.org/netdev/net/c/cefa91b2332d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] net: openvswitch: fix leak of nested actions
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Mon, 4 Apr 2022 17:43:45 +0200 you wrote: > While parsing user-provided actions, openvswitch module may dynamically > allocate memory and store pointers in the internal copy of the actions. > So this memory has to be freed while destroying the actions. > > Currently there are only two such actions: ct() and set(). However, > there are many actions that can hold nested lists of actions and > ovs_nla_free_flow_actions() just jumps over them leaking the memory. > > [...] Here is the summary with links: - [net] net: openvswitch: fix leak of nested actions https://git.kernel.org/netdev/net/c/1f30fb9166d4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] net: openvswitch: don't send internal clone attribute to the userspace.
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Mon, 4 Apr 2022 12:41:50 +0200 you wrote: > 'OVS_CLONE_ATTR_EXEC' is an internal attribute that is used for > performance optimization inside the kernel. It's added by the kernel > while parsing user-provided actions and should not be sent during the > flow dump as it's not part of the uAPI. > > The issue doesn't cause any significant problems to the ovs-vswitchd > process, because reported actions are not really used in the > application lifecycle and only supposed to be shown to a human via > ovs-dpctl flow dump. However, the action list is still incorrect > and causes the following error if the user wants to look at the > datapath flows: > > [...] Here is the summary with links: - [net] net: openvswitch: don't send internal clone attribute to the userspace. https://git.kernel.org/netdev/net/c/3f2a3050b4a3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] openvswitch: Add recirc_id to recirc warning
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Wed, 30 Mar 2022 15:42:45 -0400 you wrote: > When hitting the recirculation limit, the kernel would currently log > something like this: > > [ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop > recirc action > > Which isn't all that useful to debug as we only have the interface name > to go on but can't track it down to a specific flow. > > [...] Here is the summary with links: - openvswitch: Add recirc_id to recirc warning https://git.kernel.org/netdev/net/c/ea07af2e71cd You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v2] openvswitch: always update flow key after nat
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski :
On Fri, 18 Mar 2022 08:43:19 -0400 you wrote:
> During NAT, a tuple collision may occur. When this happens, openvswitch
> will make a second pass through NAT which will perform additional packet
> modification. This will update the skb data, but not the flow key that
> OVS uses. This means that future flow lookups, and packet matches will
> have incorrect data. This has been supported since
> 5d50aa83e2c8 ("openvswitch: support asymmetric conntrack").
>
> [...]
Here is the summary with links:
- [net,v2] openvswitch: always update flow key after nat
https://git.kernel.org/netdev/net/c/60b44ca6bd75
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v2] net: openvswitch: fix uAPI incompatibility with existing user space
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 9 Mar 2022 23:20:33 +0100 you wrote: > Few years ago OVS user space made a strange choice in the commit [1] > to define types only valid for the user space inside the copy of a > kernel uAPI header. '#ifndef __KERNEL__' and another attribute was > added later. > > This leads to the inevitable clash between user space and kernel types > when the kernel uAPI is extended. The issue was unveiled with the > addition of a new type for IPv6 extension header in kernel uAPI. > > [...] Here is the summary with links: - [net-next,v2] net: openvswitch: fix uAPI incompatibility with existing user space https://git.kernel.org/netdev/net-next/c/1926407a4ab0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH -next] net: openvswitch: remove unneeded semicolon
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Sun, 27 Feb 2022 21:22:08 +0800 you wrote: > Eliminate the following coccicheck warning: > ./net/openvswitch/flow.c:379:2-3: Unneeded semicolon > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > net/openvswitch/flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [-next] net: openvswitch: remove unneeded semicolon https://git.kernel.org/netdev/net-next/c/cb1d8fba91f2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v8] net: openvswitch: IPv6: Add IPv6 extension header support
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 23 Feb 2022 16:54:09 -0800 you wrote: > This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and > packets can be filtered using ipv6_ext flag. > > Signed-off-by: Toms Atteka > Acked-by: Pravin B Shelar > --- > include/uapi/linux/openvswitch.h | 6 ++ > net/openvswitch/flow.c | 140 +++ > net/openvswitch/flow.h | 14 > net/openvswitch/flow_netlink.c | 26 +- > 4 files changed, 184 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next,v8] net: openvswitch: IPv6: Add IPv6 extension header support https://git.kernel.org/netdev/net-next/c/28a3f0601727 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v5 1/1] openvswitch: Fix setting ipv6 fields causing hw csum failure
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Wed, 23 Feb 2022 18:34:16 +0200 you wrote: > Ipv6 ttl, label and tos fields are modified without first > pulling/pushing the ipv6 header, which would have updated > the hw csum (if available). This might cause csum validation > when sending the packet to the stack, as can be seen in > the trace below. > > Fix this by updating skb->csum if available. > > [...] Here is the summary with links: - [net,v5,1/1] openvswitch: Fix setting ipv6 fields causing hw csum failure https://git.kernel.org/netdev/net/c/d9b5ae5c1b24 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net 1/1] net/sched: act_ct: Fix flow table lookup after ct clear or switching zones
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Thu, 17 Feb 2022 11:30:48 +0200 you wrote: > Flow table lookup is skipped if packet either went through ct clear > action (which set the IP_CT_UNTRACKED flag on the packet), or while > switching zones and there is already a connection associated with > the packet. This will result in no SW offload of the connection, > and the and connection not being removed from flow table with > TCP teardown (fin/rst packet). > > [...] Here is the summary with links: - [net,1/1] net/sched: act_ct: Fix flow table lookup after ct clear or switching zones https://git.kernel.org/netdev/net/c/2f131de361f6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v3 1/1] net/sched: Enable tc skb ext allocation on chain miss only when needed
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Thu, 3 Feb 2022 10:44:30 +0200 you wrote: > Currently tc skb extension is used to send miss info from > tc to ovs datapath module, and driver to tc. For the tc to ovs > miss it is currently always allocated even if it will not > be used by ovs datapath (as it depends on a requested feature). > > Export the static key which is used by openvswitch module to > guard this code path as well, so it will be skipped if ovs > datapath doesn't need it. Enable this code path once > ovs datapath needs it. > > [...] Here is the summary with links: - [net-next,v3,1/1] net/sched: Enable tc skb ext allocation on chain miss only when needed https://git.kernel.org/netdev/net-next/c/35d39fecbc24 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v2 1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 6 Jan 2022 17:38:04 +0200 you wrote: > Netfilter conntrack maintains NAT flags per connection indicating > whether NAT was configured for the connection. Openvswitch maintains > NAT flags on the per packet flow key ct_state field, indicating > whether NAT was actually executed on the packet. > > When a packet misses from tc to ovs the conntrack NAT flags are set. > However, NAT was not necessarily executed on the packet because the > connection's state might still be in NEW state. As such, openvswitch > wrongly assumes that NAT was executed and sets an incorrect flow key > NAT flags. > > [...] Here is the summary with links: - [net,v2,1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc https://git.kernel.org/netdev/net/c/6f022c2ddbce You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next 0/3] net/sched: Pass originating device to drivers offloading ct connection
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller : On Mon, 3 Jan 2022 13:44:49 +0200 you wrote: > Hi, > > Currently, drivers register to a ct zone that can be shared by multiple > devices. This can be inefficient for the driver to offload, as it > needs to handle all the cases where the tuple can come from, > instead of where it's most likely will arive from. > > [...] Here is the summary with links: - [net-next,1/3] net/sched: act_ct: Fill offloading tuple iifidx https://git.kernel.org/netdev/net-next/c/9795ded7f924 - [net-next,2/3] net: openvswitch: Fill act ct extension https://git.kernel.org/netdev/net-next/c/b702436a51df - [net-next,3/3] net/mlx5: CT: Set flow source hint from provided tuple device https://git.kernel.org/netdev/net-next/c/c9c079b4deaa You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v3 0/3] net/sched: Fix ct zone matching for invalid conntrack state
Hello: This series was applied to netdev/net.git (master) by Jakub Kicinski : On Tue, 14 Dec 2021 19:24:32 +0200 you wrote: > Hi, > > Currently, when a packet is marked as invalid conntrack_in in act_ct, > post_ct will be set, and connection info (nf_conn) will be removed > from the skb. Later openvswitch and flower matching will parse this > as ct_state=+trk+inv. But because the connection info is missing, > there is also no zone info to match against even though the packet > is tracked. > > [...] Here is the summary with links: - [net,v3,1/3] net/sched: Extend qdisc control block with tc control block https://git.kernel.org/netdev/net/c/ec624fe740b4 - [net,v3,2/3] net/sched: flow_dissector: Fix matching on zone id for invalid conns https://git.kernel.org/netdev/net/c/384959586616 - [net,v3,3/3] net: openvswitch: Fix matching zone id for invalid conns arriving from tc https://git.kernel.org/netdev/net/c/635d448a1cce You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] net: openvswitch: Remove redundant if statements
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Thu, 2 Dec 2021 07:51:48 + you wrote:
> The 'if (dev)' statement already move into dev_{put , hold}, so remove
> redundant if statements.
>
> Signed-off-by: Xu Wang
> ---
> net/openvswitch/vport-netdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
- net: openvswitch: Remove redundant if statements
https://git.kernel.org/netdev/net-next/c/98fa41d62760
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] cls_flower: Fix inability to match GRE/IPIP packets
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 29 Oct 2021 09:21:41 + you wrote: > When a packet of a new flow arrives in openvswitch kernel module, it dissects > the packet and passes the extracted flow key to ovs-vswtichd daemon. If hw- > offload configuration is enabled, the daemon creates a new TC flower entry to > bypass openvswitch kernel module for the flow (TC flower can also offload > flows > to NICs but this time that does not matter). > > In this processing flow, I found the following issue in cases of GRE/IPIP > packets. > > [...] Here is the summary with links: - [net] cls_flower: Fix inability to match GRE/IPIP packets https://git.kernel.org/netdev/net/c/6de6e46d27ef You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] ovs: clear skb->tstamp in forwarding path
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 18 Aug 2021 10:22:15 +0800 you wrote: > From: kaixi.fan > > fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs > doesn't clear skb->tstamp. We encountered a problem with linux > version 5.4.56 and ovs version 2.14.1, and packets failed to > dequeue from qdisc when fq qdisc was attached to ovs port. > > [...] Here is the summary with links: - ovs: clear skb->tstamp in forwarding path https://git.kernel.org/netdev/net/c/01634047bf0d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] net: openvswitch: fix kernel-doc warnings in flow.c
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 8 Aug 2021 12:08:34 -0700 you wrote: > Repair kernel-doc notation in a few places to make it conform to > the expected format. > > Fixes the following kernel-doc warnings: > > flow.c:296: warning: This comment starts with '/**', but isn't a kernel-doc > comment. Refer Documentation/doc-guide/kernel-doc.rst > * Parse vlan tag from vlan header. > flow.c:296: warning: missing initial short description on line: > * Parse vlan tag from vlan header. > flow.c:537: warning: No description found for return value of > 'key_extract_l3l4' > flow.c:769: warning: No description found for return value of 'key_extract' > > [...] Here is the summary with links: - net: openvswitch: fix kernel-doc warnings in flow.c https://git.kernel.org/netdev/net/c/d6e712aa7e6a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next 0/3] openvswitch: per-cpu upcall patchwork issues
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 23 Jul 2021 10:24:11 -0400 you wrote: > Some issues were raised by patchwork at: > https://patchwork.kernel.org/project/netdevbpf/patch/20210630095350.817785-1-mark.d.g...@redhat.com/#24285159 > > Mark Gray (3): > openvswitch: update kdoc OVS_DP_ATTR_PER_CPU_PIDS > openvswitch: fix alignment issues > openvswitch: fix sparse warning incorrect type > > [...] Here is the summary with links: - [net-next,1/3] openvswitch: update kdoc OVS_DP_ATTR_PER_CPU_PIDS https://git.kernel.org/netdev/net-next/c/e4252cb66637 - [net-next,2/3] openvswitch: fix alignment issues https://git.kernel.org/netdev/net-next/c/784dcfa56e04 - [net-next,3/3] openvswitch: fix sparse warning incorrect type https://git.kernel.org/netdev/net-next/c/076999e46027 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v2] openvswitch: Introduce per-cpu upcall dispatch
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 15 Jul 2021 08:27:54 -0400 you wrote: > The Open vSwitch kernel module uses the upcall mechanism to send > packets from kernel space to user space when it misses in the kernel > space flow table. The upcall sends packets via a Netlink socket. > Currently, a Netlink socket is created for every vport. In this way, > there is a 1:1 mapping between a vport and a Netlink socket. > When a packet is received by a vport, if it needs to be sent to > user space, it is sent via the corresponding Netlink socket. > > [...] Here is the summary with links: - [net-next,v2] openvswitch: Introduce per-cpu upcall dispatch https://git.kernel.org/netdev/net-next/c/b83d23a2a38b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] openvswitch: add trace points
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 22 Jun 2021 10:02:33 -0400 you wrote: > This makes openvswitch module use the event tracing framework > to log the upcall interface and action execution pipeline. When > using openvswitch as the packet forwarding engine, some types of > debugging are made possible simply by using the ovs-vswitchd's > ofproto/trace command. However, such a command has some > limitations: > > [...] Here is the summary with links: - [net-next] openvswitch: add trace points https://git.kernel.org/netdev/net-next/c/c4ab7b56be0f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v2] openvswitch: meter: fix race when getting now_ms.
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 13 May 2021 21:08:00 +0800 you wrote: > We have observed meters working unexpected if traffic is 3+Gbit/s > with multiple connections. > > now_ms is not pretected by meter->lock, we may get a negative > long_delta_ms when another cpu updated meter->used, then: > delta_ms = (u32)long_delta_ms; > which will be a large value. > > [...] Here is the summary with links: - [ovs-dev,net,v2] openvswitch: meter: fix race when getting now_ms. https://git.kernel.org/netdev/net/c/e4df1b0c2435 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] openvswitch: meter: remove rate from the bucket size calculation
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 21 Apr 2021 15:57:47 +0200 you wrote: > Implementation of meters supposed to be a classic token bucket with 2 > typical parameters: rate and burst size. > > Burst size in this schema is the maximum number of bytes/packets that > could pass without being rate limited. > > Recent changes to userspace datapath made meter implementation to be > in line with the kernel one, and this uncovered several issues. > > [...] Here is the summary with links: - [net] openvswitch: meter: remove rate from the bucket size calculation https://git.kernel.org/netdev/net/c/7d742b509dd7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] net: openvswitch: Use 'skb_push_rcsum()' instead of hand coding it
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 4 Apr 2021 09:11:03 +0200 you wrote: > 'skb_push()'/'skb_postpush_rcsum()' can be replaced by an equivalent > 'skb_push_rcsum()' which is less verbose. > > Signed-off-by: Christophe JAILLET > --- > net/openvswitch/conntrack.c| 6 ++ > net/openvswitch/vport-netdev.c | 7 +++ > 2 files changed, 5 insertions(+), 8 deletions(-) Here is the summary with links: - net: openvswitch: Use 'skb_push_rcsum()' instead of hand coding it https://git.kernel.org/netdev/net-next/c/7d42e84eb99d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next] net: openvswitch: add log message for error case
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 13 Jan 2021 14:50:00 +0100 you wrote: > As requested by upstream OVS, added some error messages in the > validate_and_copy_dec_ttl function. > > Includes a small cleanup, which removes an unnecessary parameter > from the dec_ttl_exception_handler() function. > > Reported-by: Flavio Leitner > Signed-off-by: Eelco Chaudron > > [...] Here is the summary with links: - [net-next] net: openvswitch: add log message for error case https://git.kernel.org/netdev/net-next/c/a5317f3b06b3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix TTL decrement action netlink message format
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 24 Nov 2020 07:34:44 -0500 you wrote: > Currently, the openvswitch module is not accepting the correctly formated > netlink message for the TTL decrement action. For both setting and getting > the dec_ttl action, the actions should be nested in the > OVS_DEC_TTL_ATTR_ACTION attribute as mentioned in the openvswitch.h uapi. > > When the original patch was sent, it was tested with a private OVS userspace > implementation. This implementation was unfortunately not upstreamed and > reviewed, hence an erroneous version of this patch was sent out. > > [...] Here is the summary with links: - [net,v2] net: openvswitch: fix TTL decrement action netlink message format https://git.kernel.org/netdev/net/c/69929d4c49e1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v3] net: openvswitch: use core API to update/provide stats
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 13 Nov 2020 23:53:36 +0200 you wrote:
> Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added
> function "dev_sw_netstats_tx_add()" to update net device per-cpu TX
> stats.
>
> Use this function instead of own code.
>
> While on it, remove internal_get_stats() and replace it
> with dev_get_tstats64().
>
> [...]
Here is the summary with links:
- [v3] net: openvswitch: use core API to update/provide stats
https://git.kernel.org/netdev/net-next/c/865e6ae02dd7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] openvswitch: handle DNAT tuple collision
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 7 Oct 2020 17:48:03 +0200 you wrote: > With multiple DNAT rules it's possible that after destination > translation the resulting tuples collide. > > For example, two openvswitch flows: > nw_dst=10.0.0.10,tp_dst=10, actions=ct(commit,table=2,nat(dst=20.0.0.1:20)) > nw_dst=10.0.0.20,tp_dst=10, actions=ct(commit,table=2,nat(dst=20.0.0.1:20)) > > [...] Here is the summary with links: - [net] openvswitch: handle DNAT tuple collision https://git.kernel.org/netdev/net/c/8aa7b526dc0b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
