Re: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined

2019-08-13 Thread aserdean 
Thanks! Applied on master and backported back until branch-2.10.

 

Alin.

 

From: Anand Kumar  
Sent: Thursday, August 1, 2019 5:41 AM
To: Alin Serdean ; d...@openvswitch.org
Cc: Danting Liu 
Subject: Re: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all 
ports defined

 

Acked-by: Anand Kumar mailto:kumaran...@vmware.com> >

 

Thanks,

Anand Kumar

 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined

2019-07-31 Thread Anand Kumar via dev 
Acked-by: Anand Kumar 

Thanks,
Anand Kumar

-- Forwarded message -
From: Alin Gabriel Serdean mailto:aserd...@ovn.org>>
Date: Mon, Mar 25, 2019 at 3:13 AM
Subject: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all 
ports defined
To: mailto:d...@openvswitch.org>>
Cc: Danting Liu mailto:danti...@vmware.com>>


This patch changes the way we try to figure out if a port is defined on a given 
switch.

Instead of looking only in the internal ports defined switch to all ports 
defined.

This caused issues when trying to add a Hyper-V container port to a given OVS 
bridge.

Reported-by: Danting Liu mailto:danti...@vmware.com>>
Signed-off-by: Alin Gabriel Serdean mailto:aserd...@ovn.org>>
---
 lib/wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/wmi.c b/lib/wmi.c
index e6dc63cde..44c1d75e9 100644
--- a/lib/wmi.c
+++ b/lib/wmi.c
@@ -686,7 +686,7 @@ create_wmi_port(char *name) {

 /* Check if the element already exists on the switch. */
 wchar_t internal_port_query[WMI_QUERY_COUNT] = L"SELECT * FROM "
-L"Msvm_InternalEthernetPort WHERE ElementName = \"";
+L"CIM_EthernetPort WHERE ElementName = \"";

 wide_name = xmalloc((strlen(name) + 1) * sizeof(wchar_t));

--
2.21.0.windows.1

___
dev mailing list
d...@openvswitch.org<mailto:d...@openvswitch.org>
https://mail.openvswitch.org/mailman/listinfo/ovs-dev<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&data=02%7C01%7Ckumaranand%40vmware.com%7Cd35c1331377b4dd3e23508d716292b12%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637002238380040756&sdata=po6WCKDv6AScLWTXk7IlQqqpLijzRiLZIuQlTqu%2BTBU%3D&reserved=0>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined

2019-03-25 Thread Alin Gabriel Serdean 
This patch changes the way we try to figure out if a port is defined on a given 
switch.

Instead of looking only in the internal ports defined switch to all ports 
defined.

This caused issues when trying to add a Hyper-V container port to a given OVS 
bridge.

Reported-by: Danting Liu 
Signed-off-by: Alin Gabriel Serdean 
---
 lib/wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/wmi.c b/lib/wmi.c
index e6dc63cde..44c1d75e9 100644
--- a/lib/wmi.c
+++ b/lib/wmi.c
@@ -686,7 +686,7 @@ create_wmi_port(char *name) {
 
 /* Check if the element already exists on the switch. */
 wchar_t internal_port_query[WMI_QUERY_COUNT] = L"SELECT * FROM "
-L"Msvm_InternalEthernetPort WHERE ElementName = \"";
+L"CIM_EthernetPort WHERE ElementName = \"";
 
 wide_name = xmalloc((strlen(name) + 1) * sizeof(wchar_t));
 
-- 
2.21.0.windows.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev