Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers
> On 1 Aug 2018, at 20:17, Ben Pfaff wrote:
>
> On Wed, Aug 01, 2018 at 04:01:36PM +0300, aserd...@ovn.org
> <mailto:aserd...@ovn.org> wrote:
>>> -Mesaj original-
>>> De la: ovs-dev-boun...@openvswitch.org >> boun...@openvswitch.org> În numele Ben Pfaff
>>> Trimis: Tuesday, July 31, 2018 7:37 PM
>>> Către: Alin Gabriel Serdean
>>> Cc: d...@openvswitch.org
>>> Subiect: Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers
>>>
>>> On Tue, Jul 31, 2018 at 03:08:13PM +0300, Alin Gabriel Serdean wrote:
>>>> Until now we only had optind defined in the header.
>>>>
>>>> Since we are using the BSD getopt variant add opterr and optopt.
>>>>
>>>> Fixes: current Windows build failures.
>>>
>>> Usually Fixes is used like this:
>>>
>>>CC: Jakub Sitnicki
>>>Fixes: 3ec06ea9c668 ("ovn-nbctl: Initial support for daemon mode.")
>>>
>>> I use the following script, installed under the name git-fixes, to
>> generate it:
>>>
>>> #! /bin/sh
>>> git --no-pager log -1 --pretty=format:"CC: %an <%ae>%nFixes: %h
>>> (\"%s\")%n" --abbrev=12 "$@"
>>>
>> Thanks or the script Ben. I updated the commit message and sent out a v2.
>
> Acked-by: Ben Pfaff mailto:b...@ovn.org>>
Thanks! Applied on master and branch-2.10
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers
On Wed, Aug 01, 2018 at 04:01:36PM +0300, aserd...@ovn.org wrote:
> > -Mesaj original-
> > De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Ben Pfaff
> > Trimis: Tuesday, July 31, 2018 7:37 PM
> > Către: Alin Gabriel Serdean
> > Cc: d...@openvswitch.org
> > Subiect: Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers
> >
> > On Tue, Jul 31, 2018 at 03:08:13PM +0300, Alin Gabriel Serdean wrote:
> > > Until now we only had optind defined in the header.
> > >
> > > Since we are using the BSD getopt variant add opterr and optopt.
> > >
> > > Fixes: current Windows build failures.
> >
> > Usually Fixes is used like this:
> >
> > CC: Jakub Sitnicki
> > Fixes: 3ec06ea9c668 ("ovn-nbctl: Initial support for daemon mode.")
> >
> > I use the following script, installed under the name git-fixes, to
> generate it:
> >
> > #! /bin/sh
> > git --no-pager log -1 --pretty=format:"CC: %an <%ae>%nFixes: %h
> > (\"%s\")%n" --abbrev=12 "$@"
> >
> Thanks or the script Ben. I updated the commit message and sent out a v2.
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers
> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff
> Trimis: Tuesday, July 31, 2018 7:37 PM
> Către: Alin Gabriel Serdean
> Cc: d...@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers
>
> On Tue, Jul 31, 2018 at 03:08:13PM +0300, Alin Gabriel Serdean wrote:
> > Until now we only had optind defined in the header.
> >
> > Since we are using the BSD getopt variant add opterr and optopt.
> >
> > Fixes: current Windows build failures.
>
> Usually Fixes is used like this:
>
> CC: Jakub Sitnicki
> Fixes: 3ec06ea9c668 ("ovn-nbctl: Initial support for daemon mode.")
>
> I use the following script, installed under the name git-fixes, to
generate it:
>
> #! /bin/sh
> git --no-pager log -1 --pretty=format:"CC: %an <%ae>%nFixes: %h
> (\"%s\")%n" --abbrev=12 "$@"
>
Thanks or the script Ben. I updated the commit message and sent out a v2.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers
On Tue, Jul 31, 2018 at 03:08:13PM +0300, Alin Gabriel Serdean wrote:
> Until now we only had optind defined in the header.
>
> Since we are using the BSD getopt variant add opterr and optopt.
>
> Fixes: current Windows build failures.
Usually Fixes is used like this:
CC: Jakub Sitnicki
Fixes: 3ec06ea9c668 ("ovn-nbctl: Initial support for daemon mode.")
I use the following script, installed under the name git-fixes, to
generate it:
#! /bin/sh
git --no-pager log -1 --pretty=format:"CC: %an <%ae>%nFixes: %h (\"%s\")%n"
--abbrev=12 "$@"
> Signed-off-by: Alin Gabriel Serdean
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH] Add opterr and optopt to Windows headers
Until now we only had optind defined in the header. Since we are using the BSD getopt variant add opterr and optopt. Fixes: current Windows build failures. Signed-off-by: Alin Gabriel Serdean --- include/windows/getopt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/windows/getopt.h b/include/windows/getopt.h index 9b526ff73..fc43be868 100644 --- a/include/windows/getopt.h +++ b/include/windows/getopt.h @@ -33,7 +33,7 @@ #include extern char *optarg; -extern int optind; +extern int optind, opterr, optopt; /* * Gnu like getopt_long() and BSD4.4 getsubopt()/optreset extensions -- 2.16.1.windows.1 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
