Re: [ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD
On 6/25/20 2:13 PM, Thomas Monjalon wrote: > 25/06/2020 13:28, Timothy Redaelli: >> On Thu, 25 Jun 2020 09:32:23 +0200 >> Thomas Monjalon wrote: >> >>> On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli >>> wrote: libmnl is not used anymore for MLX5 PMD since DPDK 19.08. >>> >>> Why don't you use pkg-config? >>> All these kind of dependencies are managed through libdpdk.pc >>> which is generated with meson. >> >> Because on Fedora/RHEL we don't use meson (yet) since it's not possible >> to choose the list of PMDs to build and testpmd links to some of the >> PMDs we don't ship > > Wrong: there is the option disable_drivers accepting a list. > Anyway, makefiles won't be part of DPDK 20.11. > You must switch to meson for DPDK compilation. Since OVS uses DPDK 19.11 and supports linking with 'make'-style DPDK builds on master branch, branch-2.13 and will continue to use it on upcoming branch-2.14, this change makes sense anyway. Applied to master and branch-2.13. Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD
25/06/2020 13:28, Timothy Redaelli: > On Thu, 25 Jun 2020 09:32:23 +0200 > Thomas Monjalon wrote: > > > On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli > > wrote: > > > > > > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > > > Why don't you use pkg-config? > > All these kind of dependencies are managed through libdpdk.pc > > which is generated with meson. > > Because on Fedora/RHEL we don't use meson (yet) since it's not possible > to choose the list of PMDs to build and testpmd links to some of the > PMDs we don't ship Wrong: there is the option disable_drivers accepting a list. Anyway, makefiles won't be part of DPDK 20.11. You must switch to meson for DPDK compilation. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD
On Thu, 25 Jun 2020 09:32:23 +0200 Thomas Monjalon wrote: > On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli wrote: > > > > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > Why don't you use pkg-config? > All these kind of dependencies are managed through libdpdk.pc > which is generated with meson. Because on Fedora/RHEL we don't use meson (yet) since it's not possible to choose the list of PMDs to build and testpmd links to some of the PMDs we don't ship ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD
On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli wrote: > > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. Why don't you use pkg-config? All these kind of dependencies are managed through libdpdk.pc which is generated with meson. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD
On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli wrote: > > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > Signed-off-by: Timothy Redaelli > --- > acinclude.m4 | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 8847b8145..5be2a2f1c 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -368,7 +368,6 @@ AC_DEFUN([OVS_CHECK_DPDK], [ > ], [], [[#include ]]) > > AC_CHECK_DECL([RTE_LIBRTE_MLX5_PMD], [dnl found > - OVS_FIND_DEPENDENCY([mnl_attr_put], [mnl], [libmnl]) >AC_CHECK_DECL([RTE_IBVERBS_LINK_DLOPEN], [], [dnl not found > OVS_FIND_DEPENDENCY([mlx5dv_create_wq], [mlx5], [libmlx5]) > OVS_FIND_DEPENDENCY([verbs_init_cq], [ibverbs], [libibverbs]) > -- > 2.26.2 Looks good to me. (I copied mlx guys for info.) Reviewed-by: David Marchand -- David Marchand ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD
On Tue, Jun 23, 2020 at 10:19 PM Timothy Redaelli wrote: > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > Signed-off-by: Timothy Redaelli > Acked-by: Numan Siddique This patch is needed to build OVS on Fedora rawhide successfully and the commit [1] is required in OVS for OVN openstack kolla-ansible bug - https://bugs.launchpad.net/kolla-ansible/+bug/1884734 [1] - https://github.com/openvswitch/ovs/commit/db5a066c17bdeaa Thanks Numan > --- > acinclude.m4 | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 8847b8145..5be2a2f1c 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -368,7 +368,6 @@ AC_DEFUN([OVS_CHECK_DPDK], [ > ], [], [[#include ]]) > > AC_CHECK_DECL([RTE_LIBRTE_MLX5_PMD], [dnl found > - OVS_FIND_DEPENDENCY([mnl_attr_put], [mnl], [libmnl]) >AC_CHECK_DECL([RTE_IBVERBS_LINK_DLOPEN], [], [dnl not found > OVS_FIND_DEPENDENCY([mlx5dv_create_wq], [mlx5], [libmlx5]) > OVS_FIND_DEPENDENCY([verbs_init_cq], [ibverbs], [libibverbs]) > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD
libmnl is not used anymore for MLX5 PMD since DPDK 19.08. Signed-off-by: Timothy Redaelli --- acinclude.m4 | 1 - 1 file changed, 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 8847b8145..5be2a2f1c 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -368,7 +368,6 @@ AC_DEFUN([OVS_CHECK_DPDK], [ ], [], [[#include ]]) AC_CHECK_DECL([RTE_LIBRTE_MLX5_PMD], [dnl found - OVS_FIND_DEPENDENCY([mnl_attr_put], [mnl], [libmnl]) AC_CHECK_DECL([RTE_IBVERBS_LINK_DLOPEN], [], [dnl not found OVS_FIND_DEPENDENCY([mlx5dv_create_wq], [mlx5], [libmlx5]) OVS_FIND_DEPENDENCY([verbs_init_cq], [ibverbs], [libibverbs]) -- 2.26.2 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
