Re: [ovs-dev] [PATCH] datapath-windows: Fix alignment in actions

2017-05-23 Thread Guru Shetty 
On 17 May 2017 at 05:57, Alin Serdean 
wrote:

> Found by inspection.
>
> Signed-off-by: Alin Gabriel Serdean 
>

Thanks, applied!



> ---
>  datapath-windows/ovsext/Actions.c | 24 
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/
> Actions.c
> index e2eae9a..ebfb8a3 100644
> --- a/datapath-windows/ovsext/Actions.c
> +++ b/datapath-windows/ovsext/Actions.c
> @@ -2035,18 +2035,18 @@ OvsDoExecuteActions(POVS_SWITCH_CONTEXT
> switchContext,
>  }
>  goto dropit;
>  } else if (oldNbl != ovsFwdCtx.curNbl) {
> -   /*
> -* OvsIpv4Reassemble consumes the original NBL and creates
> a
> -* new one and assigns it to the curNbl of ovsFwdCtx.
> -*/
> -   OvsInitForwardingCtx(,
> -ovsFwdCtx.switchContext,
> -ovsFwdCtx.curNbl,
> -ovsFwdCtx.srcVportNo,
> -ovsFwdCtx.sendFlags,
> -NET_BUFFER_LIST_SWITCH_
> FORWARDING_DETAIL(ovsFwdCtx.curNbl),
> -ovsFwdCtx.completionList,
> -, FALSE);
> +/*
> + * OvsIpv4Reassemble consumes the original NBL and
> creates a
> + * new one and assigns it to the curNbl of ovsFwdCtx.
> + */
> +OvsInitForwardingCtx(,
> + ovsFwdCtx.switchContext,
> + ovsFwdCtx.curNbl,
> + ovsFwdCtx.srcVportNo,
> + ovsFwdCtx.sendFlags,
> + NET_BUFFER_LIST_SWITCH_
> FORWARDING_DETAIL(ovsFwdCtx.curNbl),
> + ovsFwdCtx.completionList,
> + , FALSE);
>  }
>  break;
>  }
> --
> 2.10.2.windows.1
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Fix alignment in actions

2017-05-17 Thread Anand Kumar 
Acked-by: Anand Kumar 
 
Thanks,
Anand Kumar

On 5/17/17, 5:57 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin 
Serdean"  wrote:

Found by inspection.

Signed-off-by: Alin Gabriel Serdean 
---
 datapath-windows/ovsext/Actions.c | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/datapath-windows/ovsext/Actions.c 
b/datapath-windows/ovsext/Actions.c
index e2eae9a..ebfb8a3 100644
--- a/datapath-windows/ovsext/Actions.c
+++ b/datapath-windows/ovsext/Actions.c
@@ -2035,18 +2035,18 @@ OvsDoExecuteActions(POVS_SWITCH_CONTEXT 
switchContext,
 }
 goto dropit;
 } else if (oldNbl != ovsFwdCtx.curNbl) {
-   /*
-* OvsIpv4Reassemble consumes the original NBL and creates a
-* new one and assigns it to the curNbl of ovsFwdCtx.
-*/
-   OvsInitForwardingCtx(,
-ovsFwdCtx.switchContext,
-ovsFwdCtx.curNbl,
-ovsFwdCtx.srcVportNo,
-ovsFwdCtx.sendFlags,
-
NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(ovsFwdCtx.curNbl),
-ovsFwdCtx.completionList,
-, FALSE);
+/*
+ * OvsIpv4Reassemble consumes the original NBL and creates 
a
+ * new one and assigns it to the curNbl of ovsFwdCtx.
+ */
+OvsInitForwardingCtx(,
+ ovsFwdCtx.switchContext,
+ ovsFwdCtx.curNbl,
+ ovsFwdCtx.srcVportNo,
+ ovsFwdCtx.sendFlags,
+ 
NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(ovsFwdCtx.curNbl),
+ ovsFwdCtx.completionList,
+ , FALSE);
 }
 break;
 }
-- 
2.10.2.windows.1
___
dev mailing list
d...@openvswitch.org

https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev=DwICAg=uilaK90D4TOVoH58JNXRgQ=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us=UsxSsO9WSAnknHPl2cBu_yKunEVS7VT_t782bL9cOmA=MuqK1pQyzFQzIfS9GbpUMBaefUMDGLoH5YmQqmzIdyw=
 






___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath-windows: Fix alignment in actions

2017-05-17 Thread Alin Serdean 
Found by inspection.

Signed-off-by: Alin Gabriel Serdean 
---
 datapath-windows/ovsext/Actions.c | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/datapath-windows/ovsext/Actions.c 
b/datapath-windows/ovsext/Actions.c
index e2eae9a..ebfb8a3 100644
--- a/datapath-windows/ovsext/Actions.c
+++ b/datapath-windows/ovsext/Actions.c
@@ -2035,18 +2035,18 @@ OvsDoExecuteActions(POVS_SWITCH_CONTEXT switchContext,
 }
 goto dropit;
 } else if (oldNbl != ovsFwdCtx.curNbl) {
-   /*
-* OvsIpv4Reassemble consumes the original NBL and creates a
-* new one and assigns it to the curNbl of ovsFwdCtx.
-*/
-   OvsInitForwardingCtx(,
-ovsFwdCtx.switchContext,
-ovsFwdCtx.curNbl,
-ovsFwdCtx.srcVportNo,
-ovsFwdCtx.sendFlags,
-
NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(ovsFwdCtx.curNbl),
-ovsFwdCtx.completionList,
-, FALSE);
+/*
+ * OvsIpv4Reassemble consumes the original NBL and creates a
+ * new one and assigns it to the curNbl of ovsFwdCtx.
+ */
+OvsInitForwardingCtx(,
+ ovsFwdCtx.switchContext,
+ ovsFwdCtx.curNbl,
+ ovsFwdCtx.srcVportNo,
+ ovsFwdCtx.sendFlags,
+ 
NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(ovsFwdCtx.curNbl),
+ ovsFwdCtx.completionList,
+ , FALSE);
 }
 break;
 }
-- 
2.10.2.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev