Re: [ovs-dev] [PATCH] datapath-windows: Update OvsCompleteNbl argument to match definition

2017-10-31 Thread aserdean 
Thanks Shashank and Sai. I pushed this on master.

Alin.

> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Shashank Ram
> Sent: Wednesday, October 25, 2017 10:53 PM
> To: Sairam Venugopal ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Update OvsCompleteNbl
> argument to match definition
> 
> 
> Update the OvsCompleteNbl to take in a PVOID and explicitly cast to
> POVS_SWITCH_CONTEXT. This is useful when finding declarations in Visual
> Studio. The mismatch breaks this functionality.
> 
> Found by inspection.
> 
> Signed-off-by: Sairam Venugopal 
> ---
> 
> Acked-by: Shashank Ram 
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Update OvsCompleteNbl argument to match definition

2017-10-25 Thread Shashank Ram 

Update the OvsCompleteNbl to take in a PVOID and explicitly cast to
POVS_SWITCH_CONTEXT. This is useful when finding declarations in Visual
Studio. The mismatch breaks this functionality.

Found by inspection.

Signed-off-by: Sairam Venugopal 
---

Acked-by: Shashank Ram 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath-windows: Update OvsCompleteNbl argument to match definition

2017-10-24 Thread Sairam Venugopal 
Update the OvsCompleteNbl to take in a PVOID and explicitly cast to
POVS_SWITCH_CONTEXT. This is useful when finding declarations in Visual
Studio. The mismatch breaks this functionality.

Found by inspection.

Signed-off-by: Sairam Venugopal 
---
 datapath-windows/ovsext/BufferMgmt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/BufferMgmt.c 
b/datapath-windows/ovsext/BufferMgmt.c
index 5c9e562..ff4f9bb 100644
--- a/datapath-windows/ovsext/BufferMgmt.c
+++ b/datapath-windows/ovsext/BufferMgmt.c
@@ -1605,7 +1605,7 @@ copymultiple_error:
  * --
  */
 PNET_BUFFER_LIST
-OvsCompleteNBL(POVS_SWITCH_CONTEXT context,
+OvsCompleteNBL(PVOID switch_ctx,
PNET_BUFFER_LIST nbl,
BOOLEAN updateRef)
 {
@@ -1615,6 +1615,7 @@ OvsCompleteNBL(POVS_SWITCH_CONTEXT context,
 NDIS_STATUS status;
 NDIS_HANDLE poolHandle;
 LONG value;
+POVS_SWITCH_CONTEXT context = (POVS_SWITCH_CONTEXT)switch_ctx;
 POVS_NBL_POOL ovsPool = &context->ovsPool;
 PNET_BUFFER nb;
 
-- 
2.9.0.windows.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev