Re: [ovs-dev] [PATCH] netdev-dpdk: fix ingress_policer leak on error path

[zhangliping]

Hi Ian,

At 2018-01-06 02:29:50, "Stokes, Ian" <ian.sto...@intel.com> wrote:
>> Subject: [ovs-dev] [PATCH] netdev-dpdk: fix ingress_policer leak on error
>> path
>Patch looks ok to me, validated on my setup. 2 minor knits.
>
>I'd like to see an expanded commit message rather than just the subject header 
>above.
>
>> 
>> From: zhangliping <zhanglipin...@baidu.com>
>> 
>> Signed-off-by: zhangliping <zhanglipin...@baidu.com>
>Need to add a Fixes tag here, in this case it fixes commit 9509913a and 
>usually cc the original author (in this case myself), there are examples of 
>the of fixes tags in the git commit history you can follow.

Thanks for your reviewing.
All the suggestions are fine with me, I will send V2.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] netdev-dpdk: fix ingress_policer leak on error path

[zhangliping]

From: zhangliping 

Signed-off-by: zhangliping 
---
 lib/netdev-dpdk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 8f22264b3..a3eb3c720 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -2258,6 +2258,7 @@ netdev_dpdk_policer_construct(uint32_t rate, uint32_t 
burst)
 >app_srtcm_params);
 if (err) {
 VLOG_ERR("Could not create rte meter for ingress policer");
+free(policer);
 return NULL;
 }
 
-- 
2.13.4


___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev