Re: [ovs-dev] [PATCH] odp-execute: Bug Fix - missing break statement for CLONE action

2017-11-20 Thread Ben Pfaff 
On Thu, Nov 09, 2017 at 10:15:31AM +, Vishal Deep Ajmera wrote:
> Adding the break statement for CLONE action case.
> 
> Signed-off-by: Vishal Deep Ajmera 

Thanks, applied to master.

I adjusted the commit message to reflect that it doesn't fix an existing
bug, only makes future bugs less likely.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] odp-execute: Bug Fix - missing break statement for CLONE action

2017-11-19 Thread Vishal Deep Ajmera 
Hi,

Do any one sees issues with this patch ? If let loose, it may create issues 
once we have implementation of METER.

Warm Regards,
Vishal

From: Vishal Deep Ajmera
Sent: Thursday, November 09, 2017 3:45 PM
To: d...@openvswitch.org
Subject: [PATCH] odp-execute: Bug Fix - missing break statement for CLONE action

Adding the break statement for CLONE action case.

Signed-off-by: Vishal Deep Ajmera 
>
---
lib/odp-execute.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 3011479..2d20cd5 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -800,6 +800,7 @@ odp_execute_actions(void *dp, struct dp_packet_batch 
*batch, bool steal,
  * stolen them.  */
 return;
 }
+break;
 case OVS_ACTION_ATTR_METER:
 /* Not implemented yet. */
 break;

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] odp-execute: Bug Fix - missing break statement for CLONE action

2017-11-09 Thread Vishal Deep Ajmera 
Adding the break statement for CLONE action case.

Signed-off-by: Vishal Deep Ajmera 
---
lib/odp-execute.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 3011479..2d20cd5 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -800,6 +800,7 @@ odp_execute_actions(void *dp, struct dp_packet_batch 
*batch, bool steal,
  * stolen them.  */
 return;
 }
+break;
 case OVS_ACTION_ATTR_METER:
 /* Not implemented yet. */
 break;

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev