Re: [ovs-dev] [PATCH] ofproto-dpif: Check for EBUSY as well

2018-08-24 Thread Gregory Rose 



On 8/24/2018 12:39 PM, Ben Pfaff wrote:

On Wed, Aug 22, 2018 at 02:38:13PM -0700, Greg Rose wrote:

Sometimes a driver will return EBUSY as well as EEXIST for some
duplicate configurations.  Check for EBUSY too.

Fixes: 7521e0cf9e ("ofproto-dpif: Let the dpif report when a ...")
Reported by: Guru Shetty 
Signed-off-by: Greg Rose 

This fixes a larger issue, right?  If so please describe that in the
commit message or at least add a Reported-at: to the original report.


Sure, will do.  V2 upcoming.

- Greg



Thanks,

Ben.


___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ofproto-dpif: Check for EBUSY as well

2018-08-24 Thread Ben Pfaff 
On Wed, Aug 22, 2018 at 02:38:13PM -0700, Greg Rose wrote:
> Sometimes a driver will return EBUSY as well as EEXIST for some
> duplicate configurations.  Check for EBUSY too.
> 
> Fixes: 7521e0cf9e ("ofproto-dpif: Let the dpif report when a ...")
> Reported by: Guru Shetty 
> Signed-off-by: Greg Rose 

This fixes a larger issue, right?  If so please describe that in the
commit message or at least add a Reported-at: to the original report.

Thanks,

Ben.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] ofproto-dpif: Check for EBUSY as well

2018-08-22 Thread Greg Rose 
Sometimes a driver will return EBUSY as well as EEXIST for some
duplicate configurations.  Check for EBUSY too.

Fixes: 7521e0cf9e ("ofproto-dpif: Let the dpif report when a ...")
Reported by: Guru Shetty 
Signed-off-by: Greg Rose 
---
 ofproto/ofproto-dpif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index e3abda5..0a0c69a 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -3687,7 +3687,7 @@ port_add(struct ofproto *ofproto_, struct netdev *netdev)
 
 odp_port_t port_no = ODPP_NONE;
 int error = dpif_port_add(ofproto->backer->dpif, netdev, _no);
-if (error != EEXIST) {
+if (error != EEXIST && error != EBUSY) {
 if (error) {
 return error;
 }
-- 
1.8.3.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev