Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Check the right IPv6 address in is_nd_dst_correct().

2018-07-11 Thread Ben Pfaff 
On Tue, Jul 10, 2018 at 08:23:17PM -0400, Aaron Conole wrote:
> Ben Pfaff  writes:
> 
> > Fixes test 815 "tunnel_push_pop_ipv6 - action".
> >
> > CC: Aaron Conole 
> > Fixes: 6f231f7c3a9e ("xlate: use const struct in6_addr in linklocal check")
> > Signed-off-by: Ben Pfaff 
> > ---
> 
> D'oh!  The names killed me.  Sorry :-(
> 
> Acked-by: Aaron Conole 

Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Check the right IPv6 address in is_nd_dst_correct().

2018-07-10 Thread Aaron Conole 
Ben Pfaff  writes:

> Fixes test 815 "tunnel_push_pop_ipv6 - action".
>
> CC: Aaron Conole 
> Fixes: 6f231f7c3a9e ("xlate: use const struct in6_addr in linklocal check")
> Signed-off-by: Ben Pfaff 
> ---

D'oh!  The names killed me.  Sorry :-(

Acked-by: Aaron Conole 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] ofproto-dpif-xlate: Check the right IPv6 address in is_nd_dst_correct().

2018-07-10 Thread Ben Pfaff 
Fixes test 815 "tunnel_push_pop_ipv6 - action".

CC: Aaron Conole 
Fixes: 6f231f7c3a9e ("xlate: use const struct in6_addr in linklocal check")
Signed-off-by: Ben Pfaff 
---
 ofproto/ofproto-dpif-xlate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index f8741d446116..dc63afa35a6b 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -3831,7 +3831,7 @@ is_nd_dst_correct(const struct flow *flow, const struct 
in6_addr *ipv6_addr)
 const uint8_t *flow_ipv6_addr = (uint8_t *) >ipv6_dst;
 const uint8_t *addr = (uint8_t *) ipv6_addr;
 
-return (IN6_IS_ADDR_MC_LINKLOCAL(ipv6_addr) &&
+return (IN6_IS_ADDR_MC_LINKLOCAL(>ipv6_dst) &&
 flow_ipv6_addr[11] == 0x01 &&
 flow_ipv6_addr[12] == 0xff &&
 flow_ipv6_addr[13] == addr[13] &&
-- 
2.16.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev