Re: [ovs-dev] [PATCH] utilities: Install ovs-tcp{dump, undump} also when only Python3 is enabled
On Tue, Aug 07, 2018 at 08:08:32PM +0200, Timothy Redaelli wrote: > On Sat, 4 Aug 2018 19:19:53 -0700 > Ben Pfaff wrote: > [...] > > > > Thanks for the explanation. I applied this to master; let me know if > > you want backports. > > I'd like a backport on branch-2.10, since commit 793bdb6c0500 and > commit 227abb77d3d1 are included in the branch. Done! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] utilities: Install ovs-tcp{dump, undump} also when only Python3 is enabled
On Sat, 4 Aug 2018 19:19:53 -0700 Ben Pfaff wrote: [...] > > Thanks for the explanation. I applied this to master; let me know if > you want backports. I'd like a backport on branch-2.10, since commit 793bdb6c0500 and commit 227abb77d3d1 are included in the branch. Thank you ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] utilities: Install ovs-tcp{dump, undump} also when only Python3 is enabled
On Fri, 3 Aug 2018 16:57:48 -0700
Ben Pfaff wrote:
> On Fri, Aug 03, 2018 at 08:28:08PM +0200, Timothy Redaelli wrote:
> > Since commit 793bdb6c0500 ("ovs-tcpdump: Fix incompatibilities with
> > python3") and commit 227abb77d3d1 ("ovs-tcpundump: Fix
> > incompatibilities with python3") ovs-tcpdump and ovs-tcpdump works
> > with Python3 as well.
> >
> > This commit allows ovs-tcpdump and ovs-tcpundump to be installed
> > also when only Python3 is enabled.
> >
> > Signed-off-by: Timothy Redaelli
>
> Often, when new programs start getting installed, we need updates to
> the rpm spec files. Do we need an update in this case?
Usually yes, but in this case it's no needed since, currently, the spec
files doesn't allow to build OVS with only Python3 enabled and so
ovs-tcp{,un}dump were always installed.
In rhel/openvswitch-fedora.spec.in and rhel/openvswitch.spec.you can
see that ovs-tcp{,un}dump are already present in %files section without
any if.
I'll probably send a patch to openvswitch-fedora.spec.in in order to
add a "--with only_python3" option to build with only Python3 enabled.
This option will eventually proposed as the default option for the
distributions that uses Python3 by default (like Fedora 32, first half
of 2020).
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] utilities: Install ovs-tcp{dump, undump} also when only Python3 is enabled
On Fri, Aug 03, 2018 at 08:28:08PM +0200, Timothy Redaelli wrote:
> Since commit 793bdb6c0500 ("ovs-tcpdump: Fix incompatibilities with python3")
> and commit 227abb77d3d1 ("ovs-tcpundump: Fix incompatibilities with python3")
> ovs-tcpdump and ovs-tcpdump works with Python3 as well.
>
> This commit allows ovs-tcpdump and ovs-tcpundump to be installed also when
> only Python3 is enabled.
>
> Signed-off-by: Timothy Redaelli
Often, when new programs start getting installed, we need updates to the
rpm spec files. Do we need an update in this case?
Thanks,
Ben.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH] utilities: Install ovs-tcp{dump, undump} also when only Python3 is enabled
Since commit 793bdb6c0500 ("ovs-tcpdump: Fix incompatibilities with python3")
and commit 227abb77d3d1 ("ovs-tcpundump: Fix incompatibilities with python3")
ovs-tcpdump and ovs-tcpdump works with Python3 as well.
This commit allows ovs-tcpdump and ovs-tcpundump to be installed also when
only Python3 is enabled.
Signed-off-by: Timothy Redaelli
---
utilities/automake.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/utilities/automake.mk b/utilities/automake.mk
index 6d7c15490..a5bb27e2b 100644
--- a/utilities/automake.mk
+++ b/utilities/automake.mk
@@ -6,14 +6,14 @@ bin_PROGRAMS += \
utilities/ovs-vsctl
bin_SCRIPTS += utilities/ovs-docker \
utilities/ovs-pki \
- utilities/ovs-pcap
+ utilities/ovs-pcap \
+ utilities/ovs-tcpdump \
+ utilities/ovs-tcpundump
if HAVE_PYTHON2
bin_SCRIPTS += \
utilities/ovs-dpctl-top \
utilities/ovs-l3ping \
utilities/ovs-parse-backtrace \
- utilities/ovs-tcpdump \
- utilities/ovs-tcpundump \
utilities/ovs-test \
utilities/ovs-vlan-test
endif
--
2.17.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
