Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error.

2024-04-26 Thread Simon Horman 
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote:
> When failing to get flow control parameters use VLOG_WARN_BUF()
> to expose the error string in ovs-vsctl show.
> 
> Signed-off-by: Roi Dayan 
> Suggested-by: Simon Horman 
> Acked-by: Eli Britstein 

Thanks Roi,

Applied to main.

- netdev-dpdk: Improve error print to the user for flow control error.
  https://github.com/openvswitch/ovs/commit/fb46f5d29ab8

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error.

2024-04-23 Thread Simon Horman 
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote:
> When failing to get flow control parameters use VLOG_WARN_BUF()
> to expose the error string in ovs-vsctl show.
> 
> Signed-off-by: Roi Dayan 
> Suggested-by: Simon Horman 
> Acked-by: Eli Britstein 

Acked-by: Simon Horman 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error.

2024-04-17 Thread Roi Dayan via dev 
When failing to get flow control parameters use VLOG_WARN_BUF()
to expose the error string in ovs-vsctl show.

Signed-off-by: Roi Dayan 
Suggested-by: Simon Horman 
Acked-by: Eli Britstein 
---
 lib/netdev-dpdk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 2111f776810b..32d4193d24af 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -2426,8 +2426,8 @@ netdev_dpdk_set_config(struct netdev *netdev, const 
struct smap *args,
 }
 err = 0; /* Not fatal. */
 } else {
-VLOG_WARN("%s: Cannot get flow control parameters: %s",
-  netdev_get_name(netdev), rte_strerror(err));
+VLOG_WARN_BUF(errp, "%s: Cannot get flow control parameters: %s",
+  netdev_get_name(netdev), rte_strerror(err));
 }
 goto out;
 }
-- 
2.21.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev