Re: [ovs-dev] [PATCH 1/2] test: Fix fragment-related tests that fail due to small-sized packets
I've create a pull request on github as v2 because this patch contains long lines that can't be handled by email protocol. https://github.com/openvswitch/ovs/pull/278 Thanks, Yifeng On Mon, Mar 18, 2019 at 10:42 AM Yifeng Sun wrote: > > Thanks Darrell for the review. Will do. > Yifeng > > On Sat, Mar 16, 2019 at 11:43 AM Darrell Ball wrote: >> >> Hi Yifeng >> >> Thanks for the patch. >> >> Your patch is corrupted; if this is due to transmit via e-mail, you can post >> a pull request. >> Other comments inline >> >> >> On Fri, Mar 15, 2019 at 7:20 PM Yifeng Sun wrote: >>> >>> These fragment-related tests are failing on later kernels (4.19.x) >>> because kernel quietly drops any packet fragment that is not the last >>> but has a size smaller than IPV6_MIN_MTU. This patch fixes >>> them by increasing their sizes to IPV6_MIN_MTU. >>> >>> Signed-off-by: Yifeng Sun >>> --- >>> tests/system-traffic.at | 30 +++--- >>> 1 file changed, 15 insertions(+), 15 deletions(-) >>> >>> diff --git a/tests/system-traffic.at b/tests/system-traffic.at >>> index b1241812e..42bf09815 100644 >>> --- a/tests/system-traffic.at >>> +++ b/tests/system-traffic.at >>> @@ -2611,7 +2611,7 @@ packet-out in_port=1, >>> packet=5054000a505400090800453100310011a48 >>> ]) >>> >>> AT_CHECK([ovs-ofctl bundle br0 bundle.txt]) >>> -# There is one byte of overlap, hence the no packet gets thru. conntrack. >>> +dnl There is one byte of overlap, hence the no packet gets thru. conntrack. >> >> >> s/hence the no packet/hence no packet/ >> >> >>> >>> AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(10.1.1.2)], [0], [dnl >>> ]) >>> >>> @@ -2635,7 +2635,7 @@ packet-out in_port=1, >>> packet=5054000a505400090800450001a400012011834 >>> ]) >>> >>> AT_CHECK([ovs-ofctl bundle br0 bundle.txt]) >>> -# There is one byte of overlap, hence the no packet gets thru. conntrack. >>> +dnl There is one byte of overlap, hence the no packet gets thru. conntrack. >> >> >> s/hence the no packet/hence no packet/ >> >>> >>> AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(10.1.1.2)], [0], [dnl >>> ]) >>> >>> @@ -2827,7 +2827,7 @@ ADD_VETH(p0, at_ns0, br0, "fc00::1/96") >>> ADD_VETH(p1, at_ns1, br0, "fc00::2/96") >> >> >> >> Don't change the packet size in these two tests >> >> AT_SETUP([conntrack - IPv6 fragmentation with fragments specified]) >> AT_SETUP([conntrack - IPv6 fragmentation out of order]) >> >> Add a macro >> 'CHECK_SMALL_V6_FRAG' >> and check for it in these tests. >> >> AT_SETUP([conntrack - IPv6 fragmentation with fragments specified]) >> AT_SETUP([conntrack - IPv6 fragmentation out of order]) >> >> and skip the kernel tests for kernel versions (>=4.19) where the check >> IPV6_MIN_MTU=1280 is enforced. >> >>> >>> >>> AT_DATA([bundle.txt], [dnl >>> -packet-out in_port=1, >>> packet=5054000a5054000986dd61a02cfffc01fc0211010001000100020008f62900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809, >>> actions=ct(co mmit >>> ) >>> +packet-out in_port=1, >>> packet=5054000a5054000986dd65002cfffc01fc0211010001000100020008f629000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090010203040506070 8090 >>> >>>
Re: [ovs-dev] [PATCH 1/2] test: Fix fragment-related tests that fail due to small-sized packets
Thanks Darrell for the review. Will do. Yifeng On Sat, Mar 16, 2019 at 11:43 AM Darrell Ball wrote: > Hi Yifeng > > Thanks for the patch. > > Your patch is corrupted; if this is due to transmit via e-mail, you can > post a pull request. > Other comments inline > > > On Fri, Mar 15, 2019 at 7:20 PM Yifeng Sun wrote: > >> These fragment-related tests are failing on later kernels (4.19.x) >> because kernel quietly drops any packet fragment that is not the last >> but has a size smaller than IPV6_MIN_MTU. This patch fixes >> them by increasing their sizes to IPV6_MIN_MTU. >> >> Signed-off-by: Yifeng Sun >> --- >> tests/system-traffic.at | 30 +++--- >> 1 file changed, 15 insertions(+), 15 deletions(-) >> >> diff --git a/tests/system-traffic.at b/tests/system-traffic.at >> index b1241812e..42bf09815 100644 >> --- a/tests/system-traffic.at >> +++ b/tests/system-traffic.at >> @@ -2611,7 +2611,7 @@ packet-out in_port=1, >> packet=5054000a505400090800453100310011a48 >> ]) >> >> AT_CHECK([ovs-ofctl bundle br0 bundle.txt]) >> -# There is one byte of overlap, hence the no packet gets thru. conntrack. >> +dnl There is one byte of overlap, hence the no packet gets thru. >> conntrack. >> > > s/hence the no packet/hence no packet/ > > > >> AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(10.1.1.2)], [0], >> [dnl >> ]) >> >> @@ -2635,7 +2635,7 @@ packet-out in_port=1, >> packet=5054000a505400090800450001a400012011834 >> ]) >> >> AT_CHECK([ovs-ofctl bundle br0 bundle.txt]) >> -# There is one byte of overlap, hence the no packet gets thru. conntrack. >> +dnl There is one byte of overlap, hence the no packet gets thru. >> conntrack. >> > > s/hence the no packet/hence no packet/ > > >> AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(10.1.1.2)], [0], >> [dnl >> ]) >> >> @@ -2827,7 +2827,7 @@ ADD_VETH(p0, at_ns0, br0, "fc00::1/96") >> ADD_VETH(p1, at_ns1, br0, "fc00::2/96") >> > > > Don't change the packet size in these two tests > > AT_SETUP([conntrack - IPv6 fragmentation with fragments specified]) > AT_SETUP([conntrack - IPv6 fragmentation out of order]) > > Add a macro > 'CHECK_SMALL_V6_FRAG' > and check for it in these tests. > > AT_SETUP([conntrack - IPv6 fragmentation with fragments specified]) > AT_SETUP([conntrack - IPv6 fragmentation out of order]) > > and skip the kernel tests for kernel versions (>=4.19) where the check > IPV6_MIN_MTU=1280 is enforced. > > >> >> AT_DATA([bundle.txt], [dnl >> -packet-out in_port=1, >> packet=5054000a5054000986dd61a02cfffc01fc0211010001000100020008f62900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809, >> actions=ct(commit >> ) >> +packet-out in_port=1, >> packet=5054000a5054000986dd65002cfffc01fc0211010001000100020008f6290001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900102030405060708090 >> >> >>
Re: [ovs-dev] [PATCH 1/2] test: Fix fragment-related tests that fail due to small-sized packets
Hi Yifeng Thanks for the patch. Your patch is corrupted; if this is due to transmit via e-mail, you can post a pull request. Other comments inline On Fri, Mar 15, 2019 at 7:20 PM Yifeng Sun wrote: > These fragment-related tests are failing on later kernels (4.19.x) > because kernel quietly drops any packet fragment that is not the last > but has a size smaller than IPV6_MIN_MTU. This patch fixes > them by increasing their sizes to IPV6_MIN_MTU. > > Signed-off-by: Yifeng Sun > --- > tests/system-traffic.at | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > index b1241812e..42bf09815 100644 > --- a/tests/system-traffic.at > +++ b/tests/system-traffic.at > @@ -2611,7 +2611,7 @@ packet-out in_port=1, > packet=5054000a505400090800453100310011a48 > ]) > > AT_CHECK([ovs-ofctl bundle br0 bundle.txt]) > -# There is one byte of overlap, hence the no packet gets thru. conntrack. > +dnl There is one byte of overlap, hence the no packet gets thru. > conntrack. > s/hence the no packet/hence no packet/ > AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(10.1.1.2)], [0], > [dnl > ]) > > @@ -2635,7 +2635,7 @@ packet-out in_port=1, > packet=5054000a505400090800450001a400012011834 > ]) > > AT_CHECK([ovs-ofctl bundle br0 bundle.txt]) > -# There is one byte of overlap, hence the no packet gets thru. conntrack. > +dnl There is one byte of overlap, hence the no packet gets thru. > conntrack. > s/hence the no packet/hence no packet/ > AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(10.1.1.2)], [0], > [dnl > ]) > > @@ -2827,7 +2827,7 @@ ADD_VETH(p0, at_ns0, br0, "fc00::1/96") > ADD_VETH(p1, at_ns1, br0, "fc00::2/96") > Don't change the packet size in these two tests AT_SETUP([conntrack - IPv6 fragmentation with fragments specified]) AT_SETUP([conntrack - IPv6 fragmentation out of order]) Add a macro 'CHECK_SMALL_V6_FRAG' and check for it in these tests. AT_SETUP([conntrack - IPv6 fragmentation with fragments specified]) AT_SETUP([conntrack - IPv6 fragmentation out of order]) and skip the kernel tests for kernel versions (>=4.19) where the check IPV6_MIN_MTU=1280 is enforced. > > AT_DATA([bundle.txt], [dnl > -packet-out in_port=1, > packet=5054000a5054000986dd61a02cfffc01fc0211010001000100020008f62900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809, > actions=ct(commit > ) > +packet-out in_port=1, > packet=5054000a5054000986dd65002cfffc01fc0211010001000100020008f6290001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900102030405060708090 > > >
[ovs-dev] [PATCH 1/2] test: Fix fragment-related tests that fail due to small-sized packets
These fragment-related tests are failing on later kernels (4.19.x) because kernel quietly drops any packet fragment that is not the last but has a size smaller than IPV6_MIN_MTU. This patch fixes them by increasing their sizes to IPV6_MIN_MTU. Signed-off-by: Yifeng Sun --- tests/system-traffic.at | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index b1241812e..42bf09815 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2611,7 +2611,7 @@ packet-out in_port=1, packet=5054000a505400090800453100310011a48 ]) AT_CHECK([ovs-ofctl bundle br0 bundle.txt]) -# There is one byte of overlap, hence the no packet gets thru. conntrack. +dnl There is one byte of overlap, hence the no packet gets thru. conntrack. AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(10.1.1.2)], [0], [dnl ]) @@ -2635,7 +2635,7 @@ packet-out in_port=1, packet=5054000a505400090800450001a400012011834 ]) AT_CHECK([ovs-ofctl bundle br0 bundle.txt]) -# There is one byte of overlap, hence the no packet gets thru. conntrack. +dnl There is one byte of overlap, hence the no packet gets thru. conntrack. AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(10.1.1.2)], [0], [dnl ]) @@ -2827,7 +2827,7 @@ ADD_VETH(p0, at_ns0, br0, "fc00::1/96") ADD_VETH(p1, at_ns1, br0, "fc00::2/96") AT_DATA([bundle.txt], [dnl -packet-out in_port=1, packet=5054000a5054000986dd61a02cfffc01fc0211010001000100020008f62900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809, actions=ct(commit ) +packet-out in_port=1, packet=5054000a5054000986dd65002cfffc01fc0211010001000100020008f6290001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900102030405060708090 00102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040
