Re: [ovs-dev] [PATCH 2/2] tests: Use $(MKDIR_P) instead of mkdir -p.

2017-12-06 Thread Ben Pfaff 
On Wed, Dec 06, 2017 at 09:42:35AM -0800, Gregory Rose wrote:
> On 12/5/2017 4:27 PM, Ben Pfaff wrote:
> >It is more portable.
> >
> >Signed-off-by: Ben Pfaff 
> >---
> >  tests/automake.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/tests/automake.mk b/tests/automake.mk
> >index c5cc95251207..ad5362ff1f5b 100644
> >--- a/tests/automake.mk
> >+++ b/tests/automake.mk
> >@@ -167,7 +167,7 @@ check-lcov: all $(check_DATA) clean-lcov
> > find . -name '*.gcda' | xargs -n1 rm -f
> > -set $(SHELL) '$(TESTSUITE)' -C tests AUTOTEST_PATH=$(AUTOTEST_PATH) 
> > $(TESTSUITEFLAGS); \
> > "$$@" || (test X'$(RECHECK)' = Xyes && "$$@" --recheck)
> >-mkdir -p tests/lcov
> >+$(MKDIR_P) tests/lcov
> > lcov $(LCOV_OPTS) -o tests/lcov/coverage.info
> > genhtml $(GENHTML_OPTS) -o tests/lcov tests/lcov/coverage.info
> > @echo "coverage report generated at tests/lcov/index.html"
> 
> Reviewed-by: Greg Rose 

Thanks for the reviews.  I applied these to master and backported as far
as branch-2.5.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] tests: Use $(MKDIR_P) instead of mkdir -p.

2017-12-06 Thread Gregory Rose 

On 12/5/2017 4:27 PM, Ben Pfaff wrote:

It is more portable.

Signed-off-by: Ben Pfaff 
---
  tests/automake.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/automake.mk b/tests/automake.mk
index c5cc95251207..ad5362ff1f5b 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -167,7 +167,7 @@ check-lcov: all $(check_DATA) clean-lcov
find . -name '*.gcda' | xargs -n1 rm -f
-set $(SHELL) '$(TESTSUITE)' -C tests AUTOTEST_PATH=$(AUTOTEST_PATH) 
$(TESTSUITEFLAGS); \
"$$@" || (test X'$(RECHECK)' = Xyes && "$$@" --recheck)
-   mkdir -p tests/lcov
+   $(MKDIR_P) tests/lcov
lcov $(LCOV_OPTS) -o tests/lcov/coverage.info
genhtml $(GENHTML_OPTS) -o tests/lcov tests/lcov/coverage.info
@echo "coverage report generated at tests/lcov/index.html"


Reviewed-by: Greg Rose 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 2/2] tests: Use $(MKDIR_P) instead of mkdir -p.

2017-12-05 Thread Ben Pfaff 
It is more portable.

Signed-off-by: Ben Pfaff 
---
 tests/automake.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/automake.mk b/tests/automake.mk
index c5cc95251207..ad5362ff1f5b 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -167,7 +167,7 @@ check-lcov: all $(check_DATA) clean-lcov
find . -name '*.gcda' | xargs -n1 rm -f
-set $(SHELL) '$(TESTSUITE)' -C tests AUTOTEST_PATH=$(AUTOTEST_PATH) 
$(TESTSUITEFLAGS); \
"$$@" || (test X'$(RECHECK)' = Xyes && "$$@" --recheck)
-   mkdir -p tests/lcov
+   $(MKDIR_P) tests/lcov
lcov $(LCOV_OPTS) -o tests/lcov/coverage.info
genhtml $(GENHTML_OPTS) -o tests/lcov tests/lcov/coverage.info
@echo "coverage report generated at tests/lcov/index.html"
-- 
2.10.2

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev