Re: [ovs-dev] [PATCH 2/3] datapath-windows: add two new build targets for code analysis

[Anand Kumar]

Acked-by: Anand Kumar 

Thanks,
Anand Kumar

On 5/23/17, 10:59 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin 
Serdean"  wrote:

Add two new build targets: 'Win8Analyze' and 'Win8.1Analyze'.
The new build targets have the static code analyzer (built in Visual
Studio feature).

This patch also introduces a new make target ('datapath_windows_analyze')
this can be added to the CI jobs to get a list warnings/errors issued
by the code analyzer.

Signed-off-by: Alin Gabriel Serdean 
---
 datapath-windows/Package/package.VcxProj  | 28 
 datapath-windows/Package/package.VcxProj.user |  6 +++
 datapath-windows/automake.mk  |  4 ++
 datapath-windows/ovsext.sln   | 14 ++
 datapath-windows/ovsext/ovsext.vcxproj| 62 
+++
 datapath-windows/ovsext/ovsext.vcxproj.user   |  6 +++
 6 files changed, 120 insertions(+)

diff --git a/datapath-windows/Package/package.VcxProj 
b/datapath-windows/Package/package.VcxProj
index 24bb914..4d6db59 100644
--- a/datapath-windows/Package/package.VcxProj
+++ b/datapath-windows/Package/package.VcxProj
@@ -25,6 +25,14 @@
   Win8 Release
   x64
 
+
+  Win8.1Analyze
+  x64
+
+
+  Win8Analyze
+  x64
+
   
   
 Utility
@@ -46,6 +54,11 @@
 true
 WindowsKernelModeDriver8.1
   
+  
+WindowsV6.3
+true
+WindowsKernelModeDriver8.1
+  
   
 
 
@@ -58,6 +71,11 @@
 true
 WindowsKernelModeDriver8.1
   
+  
+Windows8
+true
+WindowsKernelModeDriver8.1
+  
   
 
 
@@ -105,6 +123,11 @@
   true
 
   
+  
+
+  true
+
+  
   
 
   true
@@ -115,6 +138,11 @@
   true
 
   
+  
+
+  true
+
+  
   
 
   true
diff --git a/datapath-windows/Package/package.VcxProj.user 
b/datapath-windows/Package/package.VcxProj.user
index 75ea9d7..6231d93 100644
--- a/datapath-windows/Package/package.VcxProj.user
+++ b/datapath-windows/Package/package.VcxProj.user
@@ -3,9 +3,15 @@
   
 TestSign
   
+  
+TestSign
+  
   
 TestSign
   
+  
+TestSign
+  
   
 TestSign
   
diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk
index 4f7b55a..49011f1 100644
--- a/datapath-windows/automake.mk
+++ b/datapath-windows/automake.mk
@@ -82,3 +82,7 @@ EXTRA_DIST += \
datapath-windows/ovsext/precomp.h \
datapath-windows/ovsext/precompsrc.c \
datapath-windows/ovsext/resource.h
+
+datapath_windows_analyze: all
+   MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build 
/property:Configuration="Win8.1Analyze"
+   MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build 
/property:Configuration="Win8Analyze"
diff --git a/datapath-windows/ovsext.sln b/datapath-windows/ovsext.sln
index 6cf441b..1000104 100644
--- a/datapath-windows/ovsext.sln
+++ b/datapath-windows/ovsext.sln
@@ -14,8 +14,10 @@ Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Win10Debug|x64 = Win10Debug|x64
Win10Release|x64 = Win10Release|x64
+   Win8.1Analyze|x64 = Win8.1Analyze|x64
Win8.1Debug|x64 = Win8.1Debug|x64
Win8.1Release|x64 = Win8.1Release|x64
+   Win8Analyze|x64 = Win8Analyze|x64
Win8Debug|x64 = Win8Debug|x64
Win8Release|x64 = Win8Release|x64
EndGlobalSection
@@ -26,10 +28,16 @@ Global

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Release|x64.ActiveCfg = Win10 
Release|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Release|x64.Build.0 
= Win10 Release|x64

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Release|x64.Deploy.0 = Win10 
Release|x64
+   
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Analyze|x64.ActiveCfg = 
Win8.1Analyze|x64
+   
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Analyze|x64.Build.0 = 
Win8.1Analyze|x64
+   
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Analyze|x64.Deploy.0 = 
Win8.1Analyze|x64

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Debug|x64.ActiveCfg = Win8.1 
Debug|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Debug|x64.Build.0 
= Win8.1 Debug|x64

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Release|x64.ActiveCfg = Win8.1 

[ovs-dev] [PATCH 2/3] datapath-windows: add two new build targets for code analysis

[Alin Serdean]

Add two new build targets: 'Win8Analyze' and 'Win8.1Analyze'.
The new build targets have the static code analyzer (built in Visual
Studio feature).

This patch also introduces a new make target ('datapath_windows_analyze')
this can be added to the CI jobs to get a list warnings/errors issued
by the code analyzer.

Signed-off-by: Alin Gabriel Serdean 
---
 datapath-windows/Package/package.VcxProj  | 28 
 datapath-windows/Package/package.VcxProj.user |  6 +++
 datapath-windows/automake.mk  |  4 ++
 datapath-windows/ovsext.sln   | 14 ++
 datapath-windows/ovsext/ovsext.vcxproj| 62 +++
 datapath-windows/ovsext/ovsext.vcxproj.user   |  6 +++
 6 files changed, 120 insertions(+)

diff --git a/datapath-windows/Package/package.VcxProj 
b/datapath-windows/Package/package.VcxProj
index 24bb914..4d6db59 100644
--- a/datapath-windows/Package/package.VcxProj
+++ b/datapath-windows/Package/package.VcxProj
@@ -25,6 +25,14 @@
   Win8 Release
   x64
 
+
+  Win8.1Analyze
+  x64
+
+
+  Win8Analyze
+  x64
+
   
   
 Utility
@@ -46,6 +54,11 @@
 true
 WindowsKernelModeDriver8.1
   
+  
+WindowsV6.3
+true
+WindowsKernelModeDriver8.1
+  
   
 
 
@@ -58,6 +71,11 @@
 true
 WindowsKernelModeDriver8.1
   
+  
+Windows8
+true
+WindowsKernelModeDriver8.1
+  
   
 
 
@@ -105,6 +123,11 @@
   true
 
   
+  
+
+  true
+
+  
   
 
   true
@@ -115,6 +138,11 @@
   true
 
   
+  
+
+  true
+
+  
   
 
   true
diff --git a/datapath-windows/Package/package.VcxProj.user 
b/datapath-windows/Package/package.VcxProj.user
index 75ea9d7..6231d93 100644
--- a/datapath-windows/Package/package.VcxProj.user
+++ b/datapath-windows/Package/package.VcxProj.user
@@ -3,9 +3,15 @@
   
 TestSign
   
+  
+TestSign
+  
   
 TestSign
   
+  
+TestSign
+  
   
 TestSign
   
diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk
index 4f7b55a..49011f1 100644
--- a/datapath-windows/automake.mk
+++ b/datapath-windows/automake.mk
@@ -82,3 +82,7 @@ EXTRA_DIST += \
datapath-windows/ovsext/precomp.h \
datapath-windows/ovsext/precompsrc.c \
datapath-windows/ovsext/resource.h
+
+datapath_windows_analyze: all
+   MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build 
/property:Configuration="Win8.1Analyze"
+   MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build 
/property:Configuration="Win8Analyze"
diff --git a/datapath-windows/ovsext.sln b/datapath-windows/ovsext.sln
index 6cf441b..1000104 100644
--- a/datapath-windows/ovsext.sln
+++ b/datapath-windows/ovsext.sln
@@ -14,8 +14,10 @@ Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Win10Debug|x64 = Win10Debug|x64
Win10Release|x64 = Win10Release|x64
+   Win8.1Analyze|x64 = Win8.1Analyze|x64
Win8.1Debug|x64 = Win8.1Debug|x64
Win8.1Release|x64 = Win8.1Release|x64
+   Win8Analyze|x64 = Win8Analyze|x64
Win8Debug|x64 = Win8Debug|x64
Win8Release|x64 = Win8Release|x64
EndGlobalSection
@@ -26,10 +28,16 @@ Global

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Release|x64.ActiveCfg = Win10 
Release|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Release|x64.Build.0 
= Win10 Release|x64

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Release|x64.Deploy.0 = Win10 
Release|x64
+   
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Analyze|x64.ActiveCfg = 
Win8.1Analyze|x64
+   
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Analyze|x64.Build.0 = 
Win8.1Analyze|x64
+   
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Analyze|x64.Deploy.0 = 
Win8.1Analyze|x64

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Debug|x64.ActiveCfg = Win8.1 
Debug|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Debug|x64.Build.0 
= Win8.1 Debug|x64

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Release|x64.ActiveCfg = Win8.1 
Release|x64

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Release|x64.Build.0 = Win8.1 
Release|x64
+   
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Analyze|x64.ActiveCfg = 
Win8Analyze|x64
+   {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Analyze|x64.Build.0 
= Win8Analyze|x64
+   {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Analyze|x64.Deploy.0 
= Win8Analyze|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Debug|x64.ActiveCfg 
= Win8 Debug|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Debug|x64.Build.0 = 
Win8 Debug|x64

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Release|x64.ActiveCfg = Win8 
Release|x64
@@ -40,12