Re: [ovs-dev] [PATCH ovn] ci: Fix OPTS not being passed to OSX builds.

2024-04-25 Thread Ilya Maximets 
On 4/25/24 18:35, Numan Siddique wrote:
> On Thu, Apr 25, 2024 at 12:24 PM Ales Musil  wrote:
>>
>> On Thu, Apr 25, 2024 at 4:44 PM  wrote:
>>
>>> From: Numan Siddique 
>>>
>>> OSX job is failing with the below error even though the job
>>> disables SSL.
>>> 
>>> ld: library 'ssl' not found
>>> 
>>> Passing OPTS to the OSX build fixes this issue.
>>>
>>> This issue is already addressed in ovs [1].
>>>
>>> [1] -
>>> https://github.com/openvswitch/ovs/commit/2f34475a9708617eaa484044a5b485980b734b38
>>>
>>> Signed-off-by: Numan Siddique 
>>> ---
>>>  .ci/osx-build.sh | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/.ci/osx-build.sh b/.ci/osx-build.sh
>>> index 4b78b66dd1..3fcc801e7f 100755
>>> --- a/.ci/osx-build.sh
>>> +++ b/.ci/osx-build.sh
>>> @@ -19,7 +19,7 @@ function configure_ovn()
>>>  ./boot.sh && ./configure $*
>>>  }
>>>
>>> -configure_ovn $EXTRA_OPTS $*
>>> +configure_ovn $EXTRA_OPTS $OPTS $*
>>>
>>>  if [ "$CC" = "clang" ]; then
>>>  set make CFLAGS="$CFLAGS -Wno-error=unused-command-line-argument"
>>> --
>>> 2.44.0
>>>
>>> ___
>>> dev mailing list
>>> d...@openvswitch.org
>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>>
>>>
>>
>> Looks good to me, thanks.
>>
>> Acked-by: Ales Musil 
> 
> Thanks. I applied to main.


Should be applied to all supported branches, I suppose.
Otherwise, CI will be broken on those.

Best regards, Ilya Maximets.

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] ci: Fix OPTS not being passed to OSX builds.

2024-04-25 Thread Numan Siddique 
On Thu, Apr 25, 2024 at 12:24 PM Ales Musil  wrote:
>
> On Thu, Apr 25, 2024 at 4:44 PM  wrote:
>
> > From: Numan Siddique 
> >
> > OSX job is failing with the below error even though the job
> > disables SSL.
> > 
> > ld: library 'ssl' not found
> > 
> > Passing OPTS to the OSX build fixes this issue.
> >
> > This issue is already addressed in ovs [1].
> >
> > [1] -
> > https://github.com/openvswitch/ovs/commit/2f34475a9708617eaa484044a5b485980b734b38
> >
> > Signed-off-by: Numan Siddique 
> > ---
> >  .ci/osx-build.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.ci/osx-build.sh b/.ci/osx-build.sh
> > index 4b78b66dd1..3fcc801e7f 100755
> > --- a/.ci/osx-build.sh
> > +++ b/.ci/osx-build.sh
> > @@ -19,7 +19,7 @@ function configure_ovn()
> >  ./boot.sh && ./configure $*
> >  }
> >
> > -configure_ovn $EXTRA_OPTS $*
> > +configure_ovn $EXTRA_OPTS $OPTS $*
> >
> >  if [ "$CC" = "clang" ]; then
> >  set make CFLAGS="$CFLAGS -Wno-error=unused-command-line-argument"
> > --
> > 2.44.0
> >
> > ___
> > dev mailing list
> > d...@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
> >
>
> Looks good to me, thanks.
>
> Acked-by: Ales Musil 

Thanks. I applied to main.

Numan

> --
>
> Ales Musil
>
> Senior Software Engineer - OVN Core
>
> Red Hat EMEA 
>
> amu...@redhat.com
> 
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] ci: Fix OPTS not being passed to OSX builds.

2024-04-25 Thread Ales Musil 
On Thu, Apr 25, 2024 at 4:44 PM  wrote:

> From: Numan Siddique 
>
> OSX job is failing with the below error even though the job
> disables SSL.
> 
> ld: library 'ssl' not found
> 
> Passing OPTS to the OSX build fixes this issue.
>
> This issue is already addressed in ovs [1].
>
> [1] -
> https://github.com/openvswitch/ovs/commit/2f34475a9708617eaa484044a5b485980b734b38
>
> Signed-off-by: Numan Siddique 
> ---
>  .ci/osx-build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.ci/osx-build.sh b/.ci/osx-build.sh
> index 4b78b66dd1..3fcc801e7f 100755
> --- a/.ci/osx-build.sh
> +++ b/.ci/osx-build.sh
> @@ -19,7 +19,7 @@ function configure_ovn()
>  ./boot.sh && ./configure $*
>  }
>
> -configure_ovn $EXTRA_OPTS $*
> +configure_ovn $EXTRA_OPTS $OPTS $*
>
>  if [ "$CC" = "clang" ]; then
>  set make CFLAGS="$CFLAGS -Wno-error=unused-command-line-argument"
> --
> 2.44.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>

Looks good to me, thanks.

Acked-by: Ales Musil 
-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA 

amu...@redhat.com

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] ci: Fix OPTS not being passed to OSX builds.

2024-04-25 Thread numans 
From: Numan Siddique 

OSX job is failing with the below error even though the job
disables SSL.

ld: library 'ssl' not found

Passing OPTS to the OSX build fixes this issue.

This issue is already addressed in ovs [1].

[1] - 
https://github.com/openvswitch/ovs/commit/2f34475a9708617eaa484044a5b485980b734b38

Signed-off-by: Numan Siddique 
---
 .ci/osx-build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.ci/osx-build.sh b/.ci/osx-build.sh
index 4b78b66dd1..3fcc801e7f 100755
--- a/.ci/osx-build.sh
+++ b/.ci/osx-build.sh
@@ -19,7 +19,7 @@ function configure_ovn()
 ./boot.sh && ./configure $*
 }
 
-configure_ovn $EXTRA_OPTS $*
+configure_ovn $EXTRA_OPTS $OPTS $*
 
 if [ "$CC" = "clang" ]; then
 set make CFLAGS="$CFLAGS -Wno-error=unused-command-line-argument"
-- 
2.44.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev