Re: [ovs-dev] [PATCH v1 4/5] rhel: allow passing more flags to configure, fedora

2018-09-04 Thread Markos Chandras 
On 03/09/18 19:34, Flavio Leitner wrote:
> On Fri, Aug 31, 2018 at 11:52:42AM -0700, Martin Xu wrote:
>> Define a variable _ovs_config_extra_flags to allow passing more flags to
>> configure when building OVS kmod RPM. For example, to build with a
>> non-standard openssl and add an RPATH, use the following command
>>
>> make rpm-fedora-kmod RPMBUILD_OPT='-D "_ovs_config_extra_flags
>> --with-openssl= LDFLAGS=\"\${LDFLAGS} -Xlinker
>> -rpath=\""'
>>
>> Signed-off-by: Martin Xu 
>> CC: Greg Rose 
>> CC: Flavio Leitner 
> 
> No objections from me.
> Acked-by: Flavio Leitner 
> 
> 

Looks good to me

Reviewed-by: Markos Chandras 

-- 
markos

SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1 4/5] rhel: allow passing more flags to configure, fedora

2018-09-03 Thread Flavio Leitner 
On Fri, Aug 31, 2018 at 11:52:42AM -0700, Martin Xu wrote:
> Define a variable _ovs_config_extra_flags to allow passing more flags to
> configure when building OVS kmod RPM. For example, to build with a
> non-standard openssl and add an RPATH, use the following command
> 
> make rpm-fedora-kmod RPMBUILD_OPT='-D "_ovs_config_extra_flags
> --with-openssl= LDFLAGS=\"\${LDFLAGS} -Xlinker
> -rpath=\""'
> 
> Signed-off-by: Martin Xu 
> CC: Greg Rose 
> CC: Flavio Leitner 

No objections from me.
Acked-by: Flavio Leitner 



> ---
>  rhel/openvswitch-kmod-fedora.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rhel/openvswitch-kmod-fedora.spec.in 
> b/rhel/openvswitch-kmod-fedora.spec.in
> index bf045b585..6656da630 100644
> --- a/rhel/openvswitch-kmod-fedora.spec.in
> +++ b/rhel/openvswitch-kmod-fedora.spec.in
> @@ -50,7 +50,7 @@ traffic. This package contains the kernel modules.
>  for kv in %{kversion}; do
>  mkdir -p _$kv
>  (cd _$kv && /bin/cp -f ../configure . && %configure --srcdir=.. \
> ---with-linux=/lib/modules/${kv}/build --enable-ssl)
> +--with-linux=/lib/modules/${kv}/build --enable-ssl 
> %{_ovs_config_extra_flags})
>  make %{_smp_mflags} -C _$kv/datapath/linux
>  done
>  
> -- 
> 2.12.3
> 
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

-- 
Flavio

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v1 4/5] rhel: allow passing more flags to configure, fedora

2018-08-31 Thread Martin Xu 
Define a variable _ovs_config_extra_flags to allow passing more flags to
configure when building OVS kmod RPM. For example, to build with a
non-standard openssl and add an RPATH, use the following command

make rpm-fedora-kmod RPMBUILD_OPT='-D "_ovs_config_extra_flags
--with-openssl= LDFLAGS=\"\${LDFLAGS} -Xlinker
-rpath=\""'

Signed-off-by: Martin Xu 
CC: Greg Rose 
CC: Flavio Leitner 
---
 rhel/openvswitch-kmod-fedora.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rhel/openvswitch-kmod-fedora.spec.in 
b/rhel/openvswitch-kmod-fedora.spec.in
index bf045b585..6656da630 100644
--- a/rhel/openvswitch-kmod-fedora.spec.in
+++ b/rhel/openvswitch-kmod-fedora.spec.in
@@ -50,7 +50,7 @@ traffic. This package contains the kernel modules.
 for kv in %{kversion}; do
 mkdir -p _$kv
 (cd _$kv && /bin/cp -f ../configure . && %configure --srcdir=.. \
---with-linux=/lib/modules/${kv}/build --enable-ssl)
+--with-linux=/lib/modules/${kv}/build --enable-ssl 
%{_ovs_config_extra_flags})
 make %{_smp_mflags} -C _$kv/datapath/linux
 done
 
-- 
2.12.3

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev