Re: [ovs-dev] [PATCH v2] Add multi-column index support for the Python IDL

[Ben Pfaff]

On Thu, Apr 12, 2018 at 07:24:27PM -0500, twil...@redhat.com wrote:
> From: Terry Wilson 
> 
> This adds multi-column index support for the Python IDL that is
> similar to the feature in the C IDL. Since it adds sortedcontainers
> as a dependency and some distros don't yet package it, the library
> is copied in-tree and used if sortedcontainers is not installed.
> 
> Signed-off-by: Terry Wilson 

Thank you!

flake8 complained bitterly about some of the new files, so I folded in
the following, and applied this to master.

Thanks again,

Ben.

--8<--cut here-->8--

diff --git a/python/automake.mk b/python/automake.mk
index 458a2c3d20b4..5a1e1da8a79a 100644
--- a/python/automake.mk
+++ b/python/automake.mk
@@ -63,7 +63,7 @@ EXTRA_DIST += $(PYFILES)
 PYCOV_CLEAN_FILES += $(PYFILES:.py=.py,cover)
 
 FLAKE8_PYFILES += \
-   $(filter-out python/ovs/dirs.py,$(PYFILES)) \
+   $(filter-out python/ovs/compat/% python/ovs/dirs.py,$(PYFILES)) \
python/setup.py \
python/build/__init__.py \
python/build/nroff.py \
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] Add multi-column index support for the Python IDL

[Raymond Burkholder]

On 04/13/2018 02:52 PM, Ben Pfaff wrote:

On Fri, Apr 13, 2018 at 10:27:03AM -0500, Terry Wilson wrote:

One could argue that if if distro packaging is the issue, then distros
could patch in the simple try/except ImportError and add the
sortedcontainer code like I did above.


I'm quite sympathetic to that viewpoint--I think that OVS currently has
far too much distro-specific stuff in it.  In the long run I'd like to
drop the Debian and Red Hat and XenServer packaging from the tree.  As a


How would it work then, if, ..  I enjoy the fact that I can run Master, 
use the tools in the tree to build my Debian packages, and then install 
those packages on the machines where they need to be?



Debian developer myself, I know that it's not actually helpful for
upstream to provide packaging.


And if by upstream, you mean the distribution?  They can be quite behind 
at times.  Debian Stretch has 2.6, and nothing in Stretch-Backports. 
Buster does have 2.8 at the moment, but Buster can be very unstable for 
consistently building environments on demand.





--
Raymond Burkholder
r...@oneunified.net
https://blog.raymond.burkholder.net

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] Add multi-column index support for the Python IDL

[Ben Pfaff]

On Fri, Apr 13, 2018 at 10:27:03AM -0500, Terry Wilson wrote:
> One could argue that if if distro packaging is the issue, then distros
> could patch in the simple try/except ImportError and add the
> sortedcontainer code like I did above. 

I'm quite sympathetic to that viewpoint--I think that OVS currently has
far too much distro-specific stuff in it.  In the long run I'd like to
drop the Debian and Red Hat and XenServer packaging from the tree.  As a
Debian developer myself, I know that it's not actually helpful for
upstream to provide packaging.

> But, if this works for the ovs team and distro folks, I'm happy with
> it.

Seems OK for now.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] Add multi-column index support for the Python IDL

[Terry Wilson]

One could argue that if if distro packaging is the issue, then distros
could patch in the simple try/except ImportError and add the
sortedcontainer code like I did above. But, if this works for the ovs
team and distro folks, I'm happy with it.

Terry
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev